Commit graph

491790 commits

Author SHA1 Message Date
Michael Stahl
1d22186903 tdf#105844 sfx2: add another consistency check
SfxMedium::TryEncryptedInnerPackage() checks same mimetype of inner and
outer package for ODF wholesome encryption.

Change-Id: I8a5ef463c5f604a59573fb0f9e15453f22d867d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160767
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-14 18:31:44 +01:00
Michael Stahl
fb9c58a2f3 tdf#105844 package: check for unexpected zip entries on loading ...
... ODF wholesome encrypted package.

There can only be "mimetype", "encrypted-package", and files in
"META-INF".

Change-Id: I5eb46ba29a1a62e25af09e189e0a075a871c71c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160718
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-14 17:59:35 +01:00
Xisco Fauli
dcd46a0ff9 tdf#158551: sc_uicalc: Add unittest
Change-Id: I66d62651a8f8295265e4bfbfc5395e0f400d726b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160769
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-14 16:48:42 +01:00
Samuel Mehrbrodt
2486eaf671 Save with newer Glade
Change-Id: Id506e00f737b72f40448aacb6c23e64c09a0670d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160763
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-14 16:06:02 +01:00
Weblate
a056dee76e android-viewer translated using Weblate
Turkish currently translated at 93.9% (124 of 132 strings)

Change-Id: I67905c448a119c99417a465ff90968dbf842c4d5

android-viewer translated using Weblate

German currently translated at 97.7% (129 of 132 strings)

Change-Id: I5b64bae8809d6a0c1366191c00b086ea003dd95a

Added translation for android-viewer using Weblate (Kazakh)

Change-Id: I3f0a39884167fce6e7bcfde22ee582cdc53115cb

android-viewer translated using Weblate

Turkish currently translated at 93.1% (123 of 132 strings)

Change-Id: I4d5a8084d56fa5c3f803b26ccc31d905d477d504

android-viewer translated using Weblate

Catalan currently translated at 56.0% (74 of 132 strings)

Change-Id: I5296250e71d015b65f5704cc2ae088f157a5c888

android-viewer translated using Weblate

Catalan currently translated at 49.2% (65 of 132 strings)

Change-Id: Icfb62bf6f5d1e26efea090726f2379d72238fd6e
Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
Co-authored-by: Baurzhan Muftakhidinov <baurthefirst@gmail.com>
Co-authored-by: Christian Lohmaier <cloph@documentfoundation.org>
Co-authored-by: Michael Weghorn <m.weghorn@posteo.de>
Co-authored-by: Weblate <noreply@documentfoundation.org>
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tr/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160770
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-14 15:53:11 +01:00
Michael Stahl
a44a6ab7a5 OFFICE-3708: package: produce correct SHA256 URL
Old versions of LO or other consumers can't read wholesome ODF encrypted
documents anyway, so start using the correct W3C SHA256 URL (see commit
1015d35f23).

Change-Id: Id82ab2c9f605eb2084ff01a26e8186223dd46763
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160764
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-14 15:41:08 +01:00
Michael Stahl
91f35f22f0 tdf#105844 package: remove root document from manifest ...
... for ODF wholesome encryption.

  4.3  <manifest:file-entry>
  For directories, the manifest file should contain a <manifest:file-entry> element only if a directory contains a document or a sub document.

Because the "encrypted-package" is not a document but a package, we
should probably omit the file-entry for the root document.

ZipPackage::writeTempFile() always generates the root document becuase
it's needed for GPG properties, and ManifestExport filters it out.

A bit tricky to implement, because there isn't a clean distinction
between the package and the root document/storage in the package module,
in particular there's no other place than the root storage to store the
MediaType property.

Change-Id: Id7e72a64e2faa074dce80cd5fefb2fa189e2e3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160717
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-14 15:38:13 +01:00
Julien Nabet
f618e9b8c1 Regression typo closewise->clockwise in sd/CustomAnimationDialog
Regression from a756bd31dd
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a756bd31dd2da1ef134d80b2dc276cb0be228aba

Change-Id: Ia5fc84250eb64016f028f3ffe8b3dc581733904d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160778
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-14 15:27:24 +01:00
Mike Kaganski
df6a8667e6 tdf#131575: in repair mode, match names ASCII case-insensitively
It would work for the bugdoc in tdf#131575; but not if the wrong case
is the only problem in the package, because then there would be no
repairment mode active. An alternative could be to use case insensitive
match always, but that looks wrong.

Change-Id: Ie405d37e1dc639482bd2608e4479de5b707a07d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160761
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-14 15:21:35 +01:00
Mike Kaganski
975bbafaae Related: tdf#76115 Also pass RepairPackage to FilterDetect
And drop the default argument value from ZipStorage ctor.
Always pass it explicitly.

Change-Id: I8bcf78dc4db7763567f9d6873841d75c328ede7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160760
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-14 14:11:07 +01:00
Mike Kaganski
27632654fe tdf#76115: pass RepairPackage property from media descriptor to ZipStorage
See commit 86c682273d.

Change-Id: I51a3beb00f635554ac73cc9ea957e18fb8e84349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160757
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-14 14:10:55 +01:00
Michael Weghorn
806ee5b224 android lint: Dont' fail on TypographyEllipsis warning
After new translations got added in

    commit 40f850279d
    Author: Weblate <noreply@documentfoundation.org>
    Date:   Wed Dec 13 15:33:50 2023 +0100

        android-viewer translated using Weblate (Welsh)

, the android build started failing like this:

    > Task :lintReportStrippedUIEditingDebug
    Wrote HTML report to file:///home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/reports/lint-results-strippedUIEditingDebug.html

    > Task :lintStrippedUIEditingDebug FAILED
    Lint found 3 errors, 0 warnings (232 errors, 3 warnings filtered by baseline lint-baseline.xml). First failure:

    /home/michi/development/git/libreoffice-WORKTREE-android/android/source/res/values-hy/strings.xml:36: Error: Replace "..." with ellipsis character (…, &#8230;) ? [TypographyEllipsis]
        <string name="action_save_as">Պահել որպես...</string>
                                      ~~~~~~~~~~~~~~

    The full lint text report is located at:
      /home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/intermediates/lint_intermediate_text_report/strippedUIEditingDebug/lint-results-strippedUIEditingDebug.txt

    FAILURE: Build failed with an exception.

Downgrade that type of lint check to severity informational
to not cause the build to fail.
(Changes to address these will need to be done in Weblate,
which is now the source of truth for translations.)

Change-Id: Ibc82f96d29c8ac76f98db0259e1ee3cae4a986f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160772
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-14 13:54:56 +01:00
Miklos Vajna
6c1ea9d5c8 CppunitTest_sw_core_layout: remove duplicated assert
See
<https://gerrit.libreoffice.org/c/core/+/160756/2#message-9a43d741ca1307aa796eda092bd3857614c63a6f>.

Change-Id: I6db7128240b344a8169214a70fdcaff3cab57286
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160759
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-12-14 13:53:35 +01:00
Rafael Lima
3e88c7c1df Update git submodules
* Update helpcontent2 from branch 'master'
  to e99617c55d064c67d0caa82adb53925f5589c6bb
  - Related tdf#142926 Create help page about built-in help installation
    
    Change-Id: Ie71d9e5427a0bcdfeb9c20474e76635ca68a3f2a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160696
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-14 13:18:20 +01:00
Weblate
40f850279d android-viewer translated using Weblate (Welsh)
Currently translated at 100.0% (132 of 132 strings)

Change-Id: I84d27bd881bb9d9a28d4770aaff50cae81c217a2

android-viewer translated using Weblate (Catalan)

Currently translated at 48.4% (64 of 132 strings)

Change-Id: Iba9603def2e2ebd3beb993e7188f226a4b3fa260

Added translation for android-viewer using Weblate (Welsh)

Change-Id: I2852724a5f0267a7108aca3b4fb887d15c8421bb

android-viewer translated using Weblate (Catalan)

Currently translated at 46.2% (61 of 132 strings)

Change-Id: I148ee4d2ad33aa43dce5ce44ff5eff18df7239b9

Added translation for android-viewer using Weblate (Catalan)

Change-Id: I808e3a956f5758959cf9e708e6a3047f779cc024

android-viewer translated using Weblate (Spanish)

Currently translated at 100.0% (132 of 132 strings)

Change-Id: Id83ee9b9d69499604e7bf3ac15a52e5e4264192e

android-viewer translated using Weblate (Spanish)

Currently translated at 98.4% (130 of 132 strings)

Change-Id: I17e6b0385edb32a6da1871893c646488ec35419f

Added translation for android-viewer using Weblate (Spanish)

Change-Id: I572a602e665f896905d378294d5485b262b4b934

android-viewer translated using Weblate (Galician)

Currently translated at 100.0% (132 of 132 strings)

Change-Id: Ic3026fb57a2042e45506d7507223c0b007271fe6

Added translation for android-viewer using Weblate (Galician)

Change-Id: I7af380682508b4a12c902c58002884750f4dc5d3

android-viewer translated using Weblate (Armenian)

Currently translated at 100.0% (132 of 132 strings)

Change-Id: Ia57e0477acc8f14ee597b0b6961e2a3067064a89

Added translation using Weblate (Armenian)

Change-Id: Id0c85ec1236b4a9c8a0f95c0d9510db4639e777a
Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
Co-authored-by: Rhoslyn Prys <post@meddal.com>
Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com>
Co-authored-by: Weblate <noreply@documentfoundation.org>
Co-authored-by: Xosé <xosecalvo@gmail.com>
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cy/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/es/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hy/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160614
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-14 13:04:38 +01:00
Caolán McNamara
7dd028c0e4 cid#1545211 COPY_INSTEAD_OF_MOVE
and

cid#1545218 COPY_INSTEAD_OF_MOVE
cid#1545232 COPY_INSTEAD_OF_MOVE
cid#1545243 COPY_INSTEAD_OF_MOVE
cid#1545246 COPY_INSTEAD_OF_MOVE
cid#1545251 COPY_INSTEAD_OF_MOVE
cid#1545260 COPY_INSTEAD_OF_MOVE
cid#1545261 COPY_INSTEAD_OF_MOVE
cid#1545276 COPY_INSTEAD_OF_MOVE
cid#1545295 COPY_INSTEAD_OF_MOVE
cid#1545297 COPY_INSTEAD_OF_MOVE
cid#1545301 COPY_INSTEAD_OF_MOVE
cid#1545302 COPY_INSTEAD_OF_MOVE

Change-Id: I97ba935a4a2b8715b55ebbf6e853a66260b2eb90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160686
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-14 12:28:46 +01:00
Samuel Mehrbrodt
2ee0500b60 tdf#158576 Explain why OK btn is disabled
User needs to view (verify) the cert first

Change-Id: I52ce64678abc3b9f95a384e4082eaee1abf0549a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160747
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-14 12:15:06 +01:00
Caolán McNamara
b9846d15bb cid#1545734 COPY_INSTEAD_OF_MOVE
and

cid#1545723 COPY_INSTEAD_OF_MOVE
cid#1545708 COPY_INSTEAD_OF_MOVE
cid#1545705 COPY_INSTEAD_OF_MOVE
cid#1545684 COPY_INSTEAD_OF_MOVE
cid#1545674 COPY_INSTEAD_OF_MOVE
cid#1545673 COPY_INSTEAD_OF_MOVE
cid#1545667 COPY_INSTEAD_OF_MOVE
cid#1545661 COPY_INSTEAD_OF_MOVE
cid#1545660 COPY_INSTEAD_OF_MOVE
cid#1545657 COPY_INSTEAD_OF_MOVE
cid#1545653 COPY_INSTEAD_OF_MOVE
cid#1545636 COPY_INSTEAD_OF_MOVE
cid#1545624 COPY_INSTEAD_OF_MOVE
cid#1546124 COPY_INSTEAD_OF_MOVE

Change-Id: I7d50594e046a022147d9ddf077b8b2d8027f9bca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160721
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-14 11:48:47 +01:00
Michael Stahl
77ceeb844a package: GPG encryption: prevent manifest:start-key-generation ...
... completely, as currently it was generated for the first file-entry
due to too late setting of bStoreStartKeyGeneration.

Change-Id: I0cc80169deeea133bff45545fdf20fab6a6bedaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160716
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-14 10:36:44 +01:00
Julien Nabet
3282756b79 tdf#158551: fix crash Paste Special with Operation (mdds)
Change-Id: I0be1056261c6ef7f90fe9244265aa038c36a7dd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160389
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-14 10:27:22 +01:00
Miklos Vajna
5fec60b473 sw floattable: fix outdated text frame portions after split
The document has a floating table of 2 pages, with some anchor text on
page 2. Split of the anchor text resulted in 2 paragraphs: the first
still hosts the floating table and now lacks a fly portion (overlap of
text and floating table) and the second still wraps around the floating
table but has the correct position.

What happens is that we format the first text frame, then its flys
(which moves the follow fly from page 1 to page 2) and then we format
the second text frame. This means that the first text frame should have
a fly portion to wrap around the floating table, but it does not have,
because SwTextFrame::Format() is called for the first text frame, then
SwPageFrame::MoveFly() is called, then SwTextFrame::Format() for the
second text frame, i.e. no reformat of the first text frame after moving
the fly.

Fix the problem somewhat similar to what commit
cf2c070de2 (sw layout: invalidate margins
of body content when moving a fly from page, 2022-12-09) did, but here
what's outdated is the portions of the text frame, and only for the
anchor text frame.

This fixes the problem in practice, but note that in theory this could
affect non-split flys and also other, non-anchor text frames as well.
Limit the update of the portion list to the anchor of the split fly, but
we may want to do the same for all lowers of the body frame if there is
a practical need for it.

Change-Id: I3067e78d30e16ed3d2f02a80cff4cd84d9bdcf3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160748
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-12-14 10:21:54 +01:00
Darshan11
a5aa5c7fad Disable Select/Unselect-current Filter Checkboxes in Calc
Change-Id: I99a3d78bfbb65e751328452d7405d7844f810dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160082
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 5788f73657)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160697
Tested-by: Jenkins
2023-12-14 09:31:41 +01:00
Darshan11
1ad7c71892 Fix posx and posy for Filter by color in autofilter jsDialog
Change-Id: I2d4cd198197250495cc87eb1ee68407baf8e6a1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160216
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 8b08a9927b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160698
Tested-by: Jenkins
2023-12-14 09:31:23 +01:00
Ilmari Lauhakangas
bcffed442b Fix typo: I10N -> L10N
Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Jenkins
2023-12-14 09:04:26 +01:00
Julien Nabet
4eb875d956 tdf#158684: CHART XY Scatter Chart: line type "stepped" ignores parameters
Regression from 65752e6498
Date:   Fri Mar 24 10:52:13 2023 +0100
jsdialog: enable and make async chart line prop dialog

Change-Id: I1532c45ae72d2c45ace72bcc099fcc8baa265b99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160715
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-14 08:48:48 +01:00
Miklos Vajna
c5b71a7f6c CppunitTest_sw_ww8export: avoid external fonts
- sw/qa/extras/ww8export/data/cell-bg-color.odt:
  - missing font: 'Helvetica' try: Liberation Sans instead
- sw/qa/extras/ww8export/data/tdf46441-2.odt:
  - missing font: 'Times Regular' try: Noto Sans instead
- sw/qa/extras/ww8export/data/ooo92948-1.doc:
  - missing font: 'Baskerville MT' try: Noto Sans instead
  - missing font: 'Futura Book' try: Noto Sans instead
- sw/qa/extras/ww8export/data/i120158.doc:
  - missing font: 'SimSun' try: Noto Serif instead
- sw/qa/extras/ww8export/data/fdo68967.doc:
  - missing font: 'Arial Rounded MT Bold' try: Noto Sans instead
- sw/qa/extras/ww8export/data/n760294.doc:
  - missing font: 'Thorndale AMT' try: Liberation Serif instead
- sw/qa/extras/ww8export/data/new-page-styles.doc:
  - missing font: 'Raytheon Corporate Logo' try: Noto Sans instead
- sw/qa/extras/ww8export/data/redline-export-1.odt:
  - missing font: 'Helvetica' try: Liberation Sans instead
- sw/qa/extras/ww8export/data/redline-export-2.odt:
  - missing font: 'Helvetica' try: Liberation Sans instead
- sw/qa/extras/ww8export/data/redline-export-3.odt:
  - missing font: 'Helvetica' try: Liberation Sans instead
- sw/qa/extras/ww8export/data/tdf118564.doc:
  - missing font: 'FangSong_GB2312' try: Noto Sans instead
  - missing font: 'SimSun' try: Noto Serif instead
  - missing font: 'FangSong' try: Noto Sans instead
- sw/qa/extras/ww8export/data/tdf130262.doc:
  - missing font: 'Univers' try: Noto Sans instead
- sw/qa/extras/ww8export/data/tdf59896.doc (WW6):
  - missing font: 'MS Sans Serif' try: DejaVu Sans instead
- sw/qa/extras/ww8export/data/tdf95576.doc:
  - missing font: 'Calibri Light' try: Noto Sans instead
- sw/qa/extras/ww8export/data/cjklist30.doc:
  - missing font: '新細明體' try: Noto Sans instead
  - missing font: 'PMingLiU' try: Noto Sans instead
- sw/qa/extras/ww8export/data/cjklist31.doc:
  - missing font: '新細明體' try: Noto Sans instead
  - missing font: 'PMingLiU' try: Noto Sans instead
- sw/qa/extras/ww8export/data/cjklist34.doc:
  - missing font: '新細明體' try: Noto Sans instead
  - missing font: 'PMingLiU' try: Noto Sans instead
- sw/qa/extras/ww8export/data/cjklist35.doc:
  - missing font: '新細明體' try: Noto Sans instead
  - missing font: 'PMingLiU' try: Noto Sans instead

The .doc files are edited with Word (convert to DOCX, edit there,
convert back), the single WW6 file is binary patched, using spaces as
padding for the shorter new font name.

Change-Id: Ic023a0ba6e542ac0f3782dfef5986bdcf69f3056
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160713
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-14 08:20:25 +01:00
Samuel Mehrbrodt
a383794fba tdf#158576 This button shows a certificate when only one signature found
"Show signatures" should only be shown when there are multiple signatures,
otherwise the button label must be "Show certificate"

Change-Id: Iaed2d10b8e94bf6decad937dafef4795b7ed40dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160596
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-14 08:19:35 +01:00
Samuel Mehrbrodt
37b381e287 tdf#158576 Allow trusting certificates only once
Macro mode "high" says that only signed macros from trusted sources can be run.

When opening a document with a signed macro from an untrusted certificate,
the user can either disable macros, or add the certificate to the list of
trusted sources permanently and enable macros.

This adds the possibility to trust the certificate only for the current document
in the given scenario.

Change-Id: Idf272498d930afc8a3f8be7f30889b77bf402d52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160598
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-14 08:11:04 +01:00
Samuel Mehrbrodt
4a859b3d2f This dialog is no longer called when MacroTrustedAuthors is readonly
Change-Id: I73bc43cf57f6a1ed3613f2cf30e469ce6d841248
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160591
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-14 08:10:06 +01:00
Samuel Mehrbrodt
69814fc26f tdf#158576 Show warning when cert is not yet/no longer valid
Change-Id: I4f517a5e2b33d508d1a501323c4d97dc025edfbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160566
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-14 08:09:51 +01:00
Julien Nabet
b2fd2c247f tdf#152929: Sparkline ignore "High points" color when all values are negative
See https://en.cppreference.com/w/cpp/types/numeric_limits/min
"min() returns the minimum positive value"

https://en.cppreference.com/w/cpp/types/numeric_limits/lowest (since C++11)
"Returns the lowest finite value representable by the numeric type T, that is, a finite value x such that there is no other finite value y where y < x."

Change-Id: I322cd84f8124aa6f3f306c168f33cb633418b3f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160719
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-14 01:40:05 +01:00
Justin Luth
6cd6df7e0d tdf#158681 Revert "tdf#153613 writerfilter: don't always split para
... for shape w/ pagebreak"

This reverts 7.6 commit a9bc19c2d4.

The commit in general is probably fine. However, it fails in case
of an empty paragraph (with only anchors).
Unfortunately, there is no way of knowing ahead of time,
so either everything needs to be processed after a delay,
or else the paragraph needs to be split and then re-joined
in case it is not an empty paragraph.
Both options are extremely non-trivial - I don't know how
to do either of them.

In this case it is also the last paragraph in the document,
again something not known during import and which has
special-casing in MSO.

make CppunitTest_sw_ooxmlexport18 \
    CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak3

Change-Id: I4471e216b6523032b85178d85795434694cc1e22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160720
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2023-12-14 00:31:23 +01:00
Stephan Bergmann
297a667317 Work around strange error seen at least with VS 2022 Preview 17.9.0 Preview 2.0
> vcl/source/pdf/XmpMetadata.cxx(39): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'rtl::OStringLiteral<55>'
> vcl/source/pdf/XmpMetadata.cxx(39): note: Invalid aggregate initialization
> vcl/source/pdf/XmpMetadata.cxx(39): note: too many initializers

(Smells like a bug in that compiler's u8"..." handling, where it maybe gets
tripped by the 3-byte UTF-8 encoding of \uFEFF?)

Change-Id: I1c6a856a67c8328ed5fcc2f2fa6bb26f16319f55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160681
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-13 23:15:01 +01:00
Michael Stahl
09f23a3dc5 tdf#105844 package,sfx2: remove checksum infoleak when using AEAD
AEAD provides the verification of the password automatically, by reading
the entire stream the tag at the end will be verified.

The existing attributes manifest:checksum-type/manifest:checksum leak
information about the plain text.

This was mitigated with the addChaffWhenEncryptedStorage() functions
(see commit f57baefbd3) but a better
solution that also works for non-XML streams is to simply omit the
attributes; authenticated encryption provides better verification
without any leak.

* "ChecksumAlgorithm" property can be set to void now to remove the
  checksum
* change a bunch of members in EncryptionData, ZipPackage,
  ZipPackageStream to optional
* change ZipFile::checkValidPassword() to open the stream and return it

Change-Id: Id95288d0c238c4f9940fc5a185df814e8edcbad3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160711
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-13 22:02:52 +01:00
Michael Stahl
df23f57053 sfx2: remove wrong asserts
Mike Kaganski points out that "soffice -n anything.docx" triggers the
one in GetOutStream(), called from SfxMedium::CreateTempFile()
!bTransferSuccess path, so the assumption of which parts of SfxMedium
can be in use concurrently was wrong.

Change-Id: I40f321d71297cadcdf4bf9ba6f07c4db3d2ac523
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160712
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-13 22:02:20 +01:00
Patrick Luby
1956bd5f27 Fix unit test failure when using Skia in debug builds
Calling aBitmap.HasGreyPalette8Bit() hits an assert when
using Skia in a debug build so query the palette through
the bitmap read access object.

Change-Id: I12fad6783ec7d6df6c99db197aaa52fd4b01ed69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160684
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-13 21:37:51 +01:00
Stephan Bergmann
13b7905ba1 Remove misleading comment
...that had been added with 33fa50e119 "Drop some
pointless assertions" back in 2011, but is no longer meaningful now that this is
a proper assert since 6e35794cad "terminate
XDesktop properly in unit tests"

Change-Id: Id8592df03f2a4c070af3cc691a0aa65ba8c2c061
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160675
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-13 20:48:27 +01:00
Caolán McNamara
8dd210c442 add a notifier for the "Edit Existing Cond Formats" warning dialog
otherwise in --enable-dbgutil this assert with:

vcl::Window::SetLOKNotifier(vcl::Window * const this, const vcl::ILibreOfficeKitNotifier * pNotifier, bool bParent) (vcl/source/window/window.cxx:3193)
libmergedlo.so!Dialog::ImplStartExecute(Dialog * const this) (vcl/source/window/dialog.cxx:940)
libmergedlo.so!Dialog::StartExecuteAsync(Dialog * const this, VclAbstractDialog::AsyncContext & rCtx) (vcl/source/window/dialog.cxx:1111)
...
libsclo.so!ScCellShell::ExecuteEdit(ScCellShell * const this, SfxRequest & rReq) (sc/source/ui/view/cellsh1.cxx:2352)

Change-Id: I8be89a1e5d7fa2498118bad7a94ed6aad743095b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160634
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-13 20:35:35 +01:00
Noel Grandin
6ba9e3323d loplugin:unusedfields
The sPassword field in SvtHistoryOptions became redundant
after
    commit c0fffdc36d
    Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
    Date:   Mon Oct 2 12:35:21 2023 +0200
    [API CHANGE] Remove deprecated Password config item

Change-Id: Ie0c4597da5cd510f405400c215110c1e357cb497
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160615
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-13 18:09:16 +01:00
Noel Grandin
92691a5b0a loplugin:unusedmethods
Change-Id: Id0aed0077ed121fdaef574248427a3425248e7d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160617
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-13 18:09:04 +01:00
Michael Stahl
152e10996f sfx2: reduce warning spam from IsDocEncrypted()
Change-Id: I76b9d550c297db7c6f8d1d9a2739fbe050727faf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160680
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-13 17:49:24 +01:00
Michael Stahl
e45cfa7391 uui: remove use of org.openoffice.ucb.InteractionHandler/InteractionHandlers
Since the configuration schema was removed in commit
c48e810f1a this can now fail with:

com.sun.star.uno.RuntimeException message: "cannot find /org.openoffice.ucb.InteractionHandler/InteractionHandlers at /home/ms/lo/master/configmgr/source/rootaccess.cxx:214"

Just remove the code, there has been a better replacement since commit
af66a011a4 in 2010.

Change-Id: I80582f77dfb1f301fa7fe4ccd2d5931e1c8771ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160678
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-13 17:48:25 +01:00
Miklos Vajna
d852e27ed2 sw floattable: fix split of anchor text at para start
The document has a floating table with some anchor text. If we hit enter
at the end of the anchor text, the anchor text remains in the old text
node and a new text node is inserted after it, still wrapping around the
floating table. If you do the same at the start of the anchor text, then
a new paragraph is inserted before the floating table, which is
unexpected.

The OOXML concept we try to model here is that a floating table is a
table-in-fly that's followed by a paragraph that hosts the anchor text,
so the anchor position of the floating table should never change. This
behavior was even locked down in the testSplitFlyMoveMaster testcase,
but there the motivation was to make sure the fly chain is consistent.

Fix the problem by removing the special-casing in
SwTextNode::SplitContentNode() for the "at para start" case that was
added just to please the testcase. Instead update the test assert the
bad 1 -> 4 -> 2 chain is not there, so it still covers the old fix but
allows the new behavior.

With this, the Word and Writer UI behaves the same when inserting a new
para right after a floating table. The layout position problem of the
empty text node (should be wrapped, is not) still needs fixing.

Change-Id: Ib9a1f07eeb144ea929183cdc72a22bc23042fee1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160669
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-12-13 17:18:14 +01:00
Michael Stahl
6e3a6ca050 package: move function down
Change-Id: I92742a28cf60a9dfc80001f9ca3c5551fe94472d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160677
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-13 16:51:28 +01:00
Stephan Bergmann
c358da05eb Fix number of actual arguments
Change-Id: I04bb3462948aeab24d46ee7ee910fdae8da2aa65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160674
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-13 16:31:53 +01:00
Vojtěch Doležal
94d18ea557 tdf#158505 - Fix PDF export when bibliography is last paragraph
Change-Id: Iadafff97ba19d5c24be768238bddb4d684edde1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160509
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-13 15:25:11 +01:00
Michael Weghorn
6b788f8baf android: Make the build fail on new lint warnings
In order to avoid introducing new lint errors,
also run the `lint<buildVariant>` gradle target when building
Android Viewer and set the `warningsAsErrors true`
lint option.
This makes the build fail on (new) lint errors.

See [1] for more details.

Downgrade missing translations and issues that can "suddenly"
appear without any code changes to the app itself to informational,
to prevent (CI) builds from suddenly starting to fail just because
a new Android Gradle Plugin version or external library becomes
available etc.

To be able to avoid introducing new issues without having to address
all existing ones right now, use a baseline file ("lint-baseline.xml")
as described at [2] which lists all existing issues, so they don't
result in a failing build.
Those should still be looked into at some point.

Updating the baseline file can be done by just removing the
existing one and running the build again. (Build will create the
new baseline file and fail on first run after deleting the file,
then find the new file and succeed in subsequent builds.)

[1] https://developer.android.com/studio/write/lint
[2] https://developer.android.com/studio/write/lint#customize-the-baseline

Change-Id: Iddbe432519ab3040c83c0e977a584b51d3ef1e5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160199
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-13 10:50:26 +01:00
Andrea Gelmini
5757588c44 Fix typo
Change-Id: I464395f7aae8574bf81d2da7facd28e48bd04515
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160629
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-13 09:04:04 +01:00
Andrea Gelmini
ddedd5a751 Update git submodules
* Update helpcontent2 from branch 'master'
  to 463b64614aed4bb4bce500f782f131d9f88308e9
  - Fix typo
    
    Change-Id: Ic83d89754136ff476eb2f39aeb764cff03188784
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160670
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-13 08:59:35 +01:00
Matt K
5b06b87991 tdf#142695 Update tooltips for tools in Draw/Impress
This change simply updates the tooltips for tool icons
in Draw/Impress to inform the user that they can
double-click the icon to continue using that specific
action.

Change-Id: I516cf9f110bd3c7dcb1545989b86155cc84617f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160555
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-13 08:31:59 +01:00