Commit graph

491790 commits

Author SHA1 Message Date
Caolán McNamara
27a24fc1eb cid#1545577 COPY_INSTEAD_OF_MOVE
and

cid#1545679 COPY_INSTEAD_OF_MOVE
cid#1545691 COPY_INSTEAD_OF_MOVE
cid#1545697 COPY_INSTEAD_OF_MOVE
cid#1545711 COPY_INSTEAD_OF_MOVE
cid#1545730 COPY_INSTEAD_OF_MOVE

Change-Id: Ic0777a8ba532b00b021ffed81243505fbb7250f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160568
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-11 14:06:54 +01:00
Samuel Mehrbrodt
53c21bbea0 macrowarnmedium: Save with newer Glade
Change-Id: Ida8f4be081fb3b695a6c87354b2862ec103bd432
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160565
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-11 12:36:51 +01:00
Stephan Bergmann
d2346c3d4d -Werror,-Wdeprecated-declarations
> compilerplugins/clang/pluginhandler.cxx:67:71: error: 'getName' is deprecated: Use FileEntryRef::getName() instead. [-Werror,-Wdeprecated-declarations]
>    67 |         compiler.getASTContext().getSourceManager().getMainFileID())->getName());
>       |                                                                       ^
> ~/llvm/inst/include/clang/Basic/FileEntry.h:331:3: note: 'getName' has been explicitly marked deprecated here
>   331 |   LLVM_DEPRECATED("Use FileEntryRef::getName() instead.", "")
>       |   ^
> ~/llvm/inst/include/llvm/Support/Compiler.h:155:50: note: expanded from macro 'LLVM_DEPRECATED'
>   155 | #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
>       |                                                  ^
> compilerplugins/clang/pluginhandler.cxx:355:35: error: 'getName' is deprecated: Use FileEntryRef::getName() instead. [-Werror,-Wdeprecated-declarations]
>   355 |         StringRef const name = e->getName();
>       |                                   ^
> ~/llvm/inst/include/clang/Basic/FileEntry.h:331:3: note: 'getName' has been explicitly marked deprecated here
>   331 |   LLVM_DEPRECATED("Use FileEntryRef::getName() instead.", "")
>       |   ^
> ~/llvm/inst/include/llvm/Support/Compiler.h:155:50: note: expanded from macro 'LLVM_DEPRECATED'
>   155 | #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
>       |                                                  ^

since
<d1f86c3d03>
"[clang] NFC: Deprecate `FileEntry::getName()` (#68157)" on LLVM 18 trunk.
(clang::SourceManager::getFileEntryRefForID exists since
<4dc5573acc>
"Introduce FileEntryRef and use it when handling includes to report correct
dependencies when the FileManager is reused across invocations" towards
Clang 10, even when it changed its return type from Optional<FileEntryRef> to
OptionalFileEntryRef along the way.)

Change-Id: Ie37ba20c18f5ec33bab9ca2a96a9bcf722558c7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160561
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11 12:31:27 +01:00
Xisco Fauli
423ff918cd symbolstore: update to python3
Otherwise, it fails on new AlmaLinux 8 baseline

rm -fr /home/buildslave/build/workdir/symbols/
mkdir -p /home/buildslave/build/workdir/symbols/
/home/buildslave/source/libo-core/bin/symbolstore.py /home/buildslave/build/workdir/UnpackedTarball/breakpad/src/tools/linux/dump_syms/dump_syms /home/buildslave/build/workdir/symbols/ /home/buildslave/build/instdir/program/*
/usr/bin/env: 'python': No such file or directory
make: *** [Makefile:478: symbols] Error 127

Change-Id: I27a57a24a2f4bc7067041b2d4045ae0844e22d55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160113
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-11 11:40:43 +01:00
Armin Le Grand (allotropia)
6c986c7186 tdf#158421 use correct awt:Gradient2 in Chart lists
Change-Id: I5fa02c2660d59981f540cde8bd6eaaaaddb30e65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160463
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-12-11 10:29:32 +01:00
Armin Le Grand (allotropia)
ece6c0eef5 3D SW-Renderer: Add functionality to balance quality/speed
For this purpose allow reduced 3D quality in some circumstances
and make a compromize between quality and speed. This is
balanced between those two targets, fine-tuning/experimenting
can be done with some static local values if needed.

Change-Id: Ib00b6e9c3c3ff165d82ff12d23bf15196f0a0ee0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160467
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-12-11 10:29:14 +01:00
Miklos Vajna
3db4228c59 svx: prefix members of SdrDragStat
See tdf#94879 for motivation.

Change-Id: Ie3870e511a95c8b2862424cf538cebb0f5fce5dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160558
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-12-11 10:10:42 +01:00
Balazs Varga
5e8c0575e8 tdf#158472 - UI: Part 54 - Unify lockdown behavior of Options dialog
for Calc - Print Page.

Change-Id: Ie5ee611552185662f4a1081415a2c6493cf58301
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160502
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-11 08:27:26 +01:00
Balazs Varga
9ed541b82a Resave with newer Glade version
Change-Id: Ic95805c397b7a6e71d80d0f0c976e9c432238b2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160501
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-11 08:26:47 +01:00
Balazs Varga
67fcf13889 tdf#158471 - UI: Part 53 - Unify lockdown behavior of Options dialog
for Calc - Compatibility Page.

Change-Id: I43780c8b29de42a765b1d1110dbfe90efb173b4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160499
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-11 08:26:25 +01:00
Stephan Bergmann
befc51e1ad external/clucene: operation between different enumeration types
> workdir/UnpackedTarball/clucene/src/core/CLucene/index/FieldsReader.cpp:233:58: error: invalid bitwise operation between different enumeration types ('lucene::document::Field::Store' and 'lucene::document::Field::Index')
>   233 |                         f = _CLNEW LazyField(this, fi->name, Field::STORE_YES | getIndexType(fi, tokenize) | getTermVectorType(fi), length, pointer);
>       |                                                              ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~

as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk
since
<1cbd52f791>
"[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
Enumerations (#73105)"

Change-Id: I2d48298bc64e05271ee5c33255d7d57fed6221cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160549
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11 08:23:47 +01:00
Stephan Bergmann
27d72f286a external/libetonyek: operation between different enumeration types
> IWORKDiscardContext.cpp:85:30: error: invalid bitwise operation between different enumeration types ('libetonyek::IWORKToken::Namespace' and 'libetonyek::IWORKToken::(unnamed enum at ./IWORKToken.h:25:1)')
>    85 |   case IWORKToken::NS_URI_SF | IWORKToken::bezier :
>       |        ~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~

etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
trunk since
<1cbd52f791>
"[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
Enumerations (#73105)"

Change-Id: I28bfd1f90df048acea23d9fddd2010bcb537b251
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160553
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11 07:59:26 +01:00
Stephan Bergmann
053c549fdd external/libwps: operation between different enumeration types
> MSWrite.cpp:1424:63: error: invalid arithmetic between different enumeration types ('MSWriteParserInternal::BitmapFileHeaderOffset' and 'MSWriteParserInternal::BitmapInfoHeaderV2Offset')
>  1424 |         unsigned offset = MSWriteParserInternal::BM_FILE_STRUCT_SIZE + MSWriteParserInternal::BM_INFO_V2_STRUCT_SIZE + colors * unsigned(sizeof(MSWriteParserInternal::BitmapPalette));
>       |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
trunk since
<1cbd52f791>
"[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
Enumerations (#73105)"

Change-Id: I6307978bc39e0f965144e0df3ac9a28eb817fe10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160552
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11 07:59:09 +01:00
Stephan Bergmann
cd13a57256 external/libebook: operation between different enumeration types
> EBOOKDocument.cpp:150:37: error: invalid bitwise operation between different enumeration types ('libebook::EBOOKHTMLToken::(unnamed enum at ./EBOOKHTMLToken.h:21:1)' and 'libebook::EBOOKHTMLToken::Namespace')
>   150 |           if ((EBOOKHTMLToken::html | EBOOKHTMLToken::NS_html) == getHTMLTokenId(name, uri))
>       |                ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~

etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
trunk since
<1cbd52f791>
"[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
Enumerations (#73105)"

Change-Id: I799932d0dffec5e9345f29e14a2ee3f9a2add133
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160551
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11 07:58:54 +01:00
Stephan Bergmann
fe99cac649 external/graphite: operation between different enumeration types
> workdir/UnpackedTarball/graphite/src/Pass.cpp:197:92: error: invalid arithmetic between different enumeration types ('status_t' and 'graphite2::errors')
>   197 |                 || e.test(m_cPConstraint.status() != Code::loaded, m_cPConstraint.status() + E_CODEFAILURE))
>       |                                                                    ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~

etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
trunk since
<1cbd52f791>
"[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
Enumerations (#73105)"

Change-Id: I34b2743d46b8f46b1f39b2af812f95876e4b9e38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160550
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-11 07:58:38 +01:00
Mike Kaganski
2b4094195e Clean up SvStream API a bit
Change-Id: Ic9847185e8f551eeb05715902374d7a9a9032f60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160546
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-11 07:10:31 +01:00
Matt K
90d732a531 tdf#117651 Fix AutoCorrect crash for italic, strike, bold, and underline
This change fixes correction of indices when autocorrecting for one
of the categories of bold, italic, strike, or underline.  Previously,
the code would hit a debug assert when selecting "Apply" because of
incorrect indices into the string being autocorrected.

Change-Id: I5484c589ff43cd2fc78332cdc0d63e74cdc8e256
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160547
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-11 05:38:43 +01:00
Matt K
dc8b69e339 tdf#117651 Fix AutoCorrect support for italic, strike, bold, and underline
The previous change for italic had a "break" for "/", but it turns out
that code path is hit when trying to "Apply" with slashes around
some text, so we just move the "break" inside the check for French
language handling.  Note that trying "Apply" with this change will
crash on a debug build -- there is another fix for that problem
in a subsequent change.

Change-Id: I4bd76505b3fdfc9f5660eb6ae4a5c5c23e9672ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160529
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-11 05:35:53 +01:00
Balazs Varga
0024b7e392 Resave with newer Glade version
Change-Id: I080b742ae6dcfa8a67ee90c7b611736121355806
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160498
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10 22:37:26 +01:00
Caolán McNamara
95e12eaebc cid#1545789 COPY_INSTEAD_OF_MOVE
and

cid#1545791 COPY_INSTEAD_OF_MOVE
cid#1545800 COPY_INSTEAD_OF_MOVE
cid#1545806 COPY_INSTEAD_OF_MOVE
cid#1545817 COPY_INSTEAD_OF_MOVE
cid#1545832 COPY_INSTEAD_OF_MOVE
cid#1545834 COPY_INSTEAD_OF_MOVE
cid#1545841 COPY_INSTEAD_OF_MOVE
cid#1545848 COPY_INSTEAD_OF_MOVE
cid#1545852 COPY_INSTEAD_OF_MOVE
cid#1545854 COPY_INSTEAD_OF_MOVE
cid#1545864 COPY_INSTEAD_OF_MOVE
cid#1545875 COPY_INSTEAD_OF_MOVE
cid#1545882 COPY_INSTEAD_OF_MOVE
cid#1545900 COPY_INSTEAD_OF_MOVE
cid#1545901 COPY_INSTEAD_OF_MOVE
cid#1545908 COPY_INSTEAD_OF_MOVE
cid#1545921 COPY_INSTEAD_OF_MOVE
cid#1546054 COPY_INSTEAD_OF_MOVE
cid#1546145 COPY_INSTEAD_OF_MOVE
cid#1546146 COPY_INSTEAD_OF_MOVE

Change-Id: I8b23d0457cb293aa0e33593131224c1cdd1d8eb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160545
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 20:27:43 +01:00
Patrick Luby
9531f83cc7 tdf#140401 check if attribute is a nullptr
Change-Id: Ie6e33fc1dca525553bb4237204666835d335b13f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160524
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-10 19:40:57 +01:00
Rafael Lima
b5526d4e95 Update Portuguese translation of ScriptForge
Change-Id: Ic16b782d63e84581134f2238454aa9599819f146
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160359
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2023-12-10 19:06:41 +01:00
Balazs Varga
99c7a2a6a0 tdf#158469 - UI: Part 51 - Unify lockdown behavior of Options dialog
for Calc - Sort Lists Page.

Change-Id: I857b49caf8fa6823ae2582212885b317a34ff1df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160494
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10 17:59:20 +01:00
Balazs Varga
9c923b5c74 Resave with newer Glade version
Change-Id: Ibf9a565587a5af02f6cb8ba9194e25d2f5b66c8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160493
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10 17:58:39 +01:00
Balazs Varga
60cb604efe tdf#158470 - UI: Part 52 - Unify lockdown behavior of Options dialog
for Calc - Changes Page.

Change-Id: I2d352915b2804411f0bbee62c967de77ad4bbba7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160496
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10 17:57:54 +01:00
Balazs Varga
98b1eb2523 Resave with newer Glade version
Change-Id: I6bb6dbfe977987e592b87abc5e1f0f3dc4b789cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160495
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10 17:57:02 +01:00
Balazs Varga
a6ead255af tdf#158467 - UI: Part 50 - Unify lockdown behavior of Options dialog
for Calc - Calculate Page.

Change-Id: Ibe728e2ffc122879ee66abb88927be355d41348a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160462
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-10 17:56:31 +01:00
Caolán McNamara
283aa103b9 cid#1545177 COPY_INSTEAD_OF_MOVE
and

cid#1545179 COPY_INSTEAD_OF_MOVE
cid#1545187 COPY_INSTEAD_OF_MOVE
cid#1545188 COPY_INSTEAD_OF_MOVE
cid#1545189 COPY_INSTEAD_OF_MOVE
cid#1545196 COPY_INSTEAD_OF_MOVE
cid#1545197 COPY_INSTEAD_OF_MOVE
cid#1545204 COPY_INSTEAD_OF_MOVE
cid#1545223 COPY_INSTEAD_OF_MOVE
cid#1545236 COPY_INSTEAD_OF_MOVE
cid#1545239 COPY_INSTEAD_OF_MOVE
cid#1545253 COPY_INSTEAD_OF_MOVE
cid#1545274 COPY_INSTEAD_OF_MOVE
cid#1545286 COPY_INSTEAD_OF_MOVE
cid#1545309 COPY_INSTEAD_OF_MOVE
cid#1545311 COPY_INSTEAD_OF_MOVE
cid#1545345 COPY_INSTEAD_OF_MOVE
cid#1545358 COPY_INSTEAD_OF_MOVE
cid#1545361 COPY_INSTEAD_OF_MOVE
cid#1545365 COPY_INSTEAD_OF_MOVE
cid#1545367 COPY_INSTEAD_OF_MOVE
cid#1545372 COPY_INSTEAD_OF_MOVE
cid#1545373 COPY_INSTEAD_OF_MOVE
cid#1545377 COPY_INSTEAD_OF_MOVE
cid#1545392 COPY_INSTEAD_OF_MOVE
cid#1545399 COPY_INSTEAD_OF_MOVE
cid#1545404 COPY_INSTEAD_OF_MOVE
cid#1545408 COPY_INSTEAD_OF_MOVE
cid#1545430 COPY_INSTEAD_OF_MOVE
cid#1545439 COPY_INSTEAD_OF_MOVE
cid#1545449 COPY_INSTEAD_OF_MOVE

Change-Id: I3afe836a0bbc8bd70937035e60eb020435e413d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160539
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 17:41:18 +01:00
Laurent Balland
7cfd3da36b tdf#158250 Blueprint Plans template: update images
Contribution from Jérôme Bouat
Replace pictures with grey level and indexed colours

Change-Id: I5e253af65529d45b3c9ed2e30f6e2f018cbe03e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160532
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-10 17:18:32 +01:00
Laurent Balland
9168109f39 tdf#158250 Yellow Idea template: replace pictures
Contribution from Jérôme Bouat
Replace pictures with grey level

Change-Id: I933b20ad7b06d60e8039caaf8ce777bb52ce4225
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160534
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-10 17:18:19 +01:00
Laurent Balland
b91d7649a6 tdf#158250 Grey Elegant template: replace pictures
Contribution from Jérôme Bouat
Replace pictures with grey level

Change-Id: If56958228085a77a61e867622a7a1a48e127745c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160535
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-10 17:18:06 +01:00
Laurent Balland
6fda99d874 tdf#158250 Vivid, Piano templates: replace pictures
Contribution from Jérôme Bouat
Replace pictures with grey level

Change-Id: Ib8522871404261e81c25b50ac1ee073058e0dce5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160533
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-10 17:17:52 +01:00
Mike Kaganski
d88d113c7d Simplify SvStream::WriteDouble
Change-Id: I0ece791b5571d3839c936e104016f53cc3b6d5e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160537
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-10 17:08:06 +01:00
Mike Kaganski
1d21ecc90c Use SvStream methods
Change-Id: I11a98b32ab176c1e30480186123b21bc04b9500f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160536
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-10 17:07:50 +01:00
Caolán McNamara
3f02996475 cid#1558174 Bad bit shift operation
and

cid#1558175 Bad bit shift operation

Change-Id: I44d6f351716cf722abcd19ff866bc247ba9f5cd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160538
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 16:52:26 +01:00
Mike Kaganski
b4fda935de Keep original error
Fix several SetError implementations, to make sure that original
errors are not rewritten, but OTOH warnings could be replaced by
errors.

Change-Id: Ic5e71b791ff3426ff1144778a610ab77fcbf24d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160530
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-10 12:38:17 +01:00
Olivier Hallot
884b294df6 Update git submodules
* Update helpcontent2 from branch 'master'
  to c487633e84637e8b71bb92001f16a2ff4051c11c
  - tdf#155876 UI cmds Calc-Sheet menu (28)
    
    + Sheet menu for Calc, delete row/column/breaks
    + refactoring
    
    Change-Id: I0905cfc84ccb9c2e914b4fdd65d4897e6f6f62f6
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160527
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-10 12:21:50 +01:00
Olivier Hallot
51bdf40390 Update git submodules
* Update helpcontent2 from branch 'master'
  to 56d67dfd7ef0df8768ad2f4975333ad633cde27f
  - tdf#155876 UI cmds Calc-Sheet menu (27)
    
    + Sheet menu for Calc, insert row/column/breaks
    + refactoring
    
    Change-Id: Ie8ecd21877f960206616489e9113144bd37dd96a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160526
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-10 12:21:36 +01:00
Olivier Hallot
3df8c3dd5a Update git submodules
* Update helpcontent2 from branch 'master'
  to 4fd56ae1b229043b9fbcaf035cd19b0a4b5950af
  - tdf#155876 UI cmds Calc-Sheet menu (26)
    
    + Sheet menu for Calc
    + refactoring
    
    Change-Id: I227b221aa3093dd352a8801ea83b4558f35755ab
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160525
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-10 12:21:21 +01:00
Caolán McNamara
d03dc3dfce cid#1545912 std::swap COPY_INSTEAD_OF_MOVE
Change-Id: Ib3468b43015821225d0236fca5550392f69e1154
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160523
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 11:57:42 +01:00
Caolán McNamara
15ff0c3828 cid#1545975 COPY_INSTEAD_OF_MOVE
and

cid#1545955 COPY_INSTEAD_OF_MOVE
cid#1545954 COPY_INSTEAD_OF_MOVE
cid#1545952 COPY_INSTEAD_OF_MOVE
cid#1545948 COPY_INSTEAD_OF_MOVE
cid#1545943 COPY_INSTEAD_OF_MOVE
cid#1545935 COPY_INSTEAD_OF_MOVE
cid#1545930 COPY_INSTEAD_OF_MOVE
cid#1545928 COPY_INSTEAD_OF_MOVE
cid#1545925 COPY_INSTEAD_OF_MOVE
cid#1545922 COPY_INSTEAD_OF_MOVE

Change-Id: I28d830504337f417829c675b1eb9c763b83b30c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160522
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 11:57:35 +01:00
Caolán McNamara
9c2c815d85 cid#1545987 std::swap COPY_INSTEAD_OF_MOVE
Change-Id: I34413f941aa5eded457ad5a3a5ffb4c9e1104590
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160521
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 11:57:27 +01:00
Caolán McNamara
5d3d7cd656 cid#1546281 COPY_INSTEAD_OF_MOVE
and

cid#1546278 COPY_INSTEAD_OF_MOVE
cid#1546276 COPY_INSTEAD_OF_MOVE
cid#1546247 COPY_INSTEAD_OF_MOVE
cid#1546244 COPY_INSTEAD_OF_MOVE
cid#1546243 COPY_INSTEAD_OF_MOVE
cid#1546220 COPY_INSTEAD_OF_MOVE
cid#1546209 COPY_INSTEAD_OF_MOVE
cid#1546207 COPY_INSTEAD_OF_MOVE
cid#1546206 COPY_INSTEAD_OF_MOVE
cid#1546205 COPY_INSTEAD_OF_MOVE
cid#1546197 COPY_INSTEAD_OF_MOVE
cid#1546180 COPY_INSTEAD_OF_MOVE
cid#1546172 COPY_INSTEAD_OF_MOVE
cid#1546165 COPY_INSTEAD_OF_MOVE
cid#1546164 COPY_INSTEAD_OF_MOVE
cid#1546158 COPY_INSTEAD_OF_MOVE
cid#1546151 COPY_INSTEAD_OF_MOVE
cid#1546135 COPY_INSTEAD_OF_MOVE
cid#1546132 COPY_INSTEAD_OF_MOVE
cid#1546129 COPY_INSTEAD_OF_MOVE
cid#1546128 COPY_INSTEAD_OF_MOVE
cid#1546122 COPY_INSTEAD_OF_MOVE
cid#1546117 COPY_INSTEAD_OF_MOVE
cid#1546113 COPY_INSTEAD_OF_MOVE
cid#1546106 COPY_INSTEAD_OF_MOVE
cid#1546099 COPY_INSTEAD_OF_MOVE
cid#1546091 COPY_INSTEAD_OF_MOVE
cid#1546085 COPY_INSTEAD_OF_MOVE
cid#1546069 COPY_INSTEAD_OF_MOVE
cid#1546063 COPY_INSTEAD_OF_MOVE
cid#1546062 COPY_INSTEAD_OF_MOVE
cid#1546058 COPY_INSTEAD_OF_MOVE
cid#1546056 COPY_INSTEAD_OF_MOVE
cid#1546051 COPY_INSTEAD_OF_MOVE
cid#1546040 COPY_INSTEAD_OF_MOVE
cid#1546030 COPY_INSTEAD_OF_MOVE
cid#1546028 COPY_INSTEAD_OF_MOVE
cid#1546015 COPY_INSTEAD_OF_MOVE
cid#1546001 COPY_INSTEAD_OF_MOVE

Change-Id: Ib954c92a300fc323b29f27880fdf8bc46ed98862
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160520
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 11:57:12 +01:00
Caolán McNamara
0afed1a481 cid#1546285 this copy is dead-code
since:

commit 9be3c3724c
Date:   Mon Aug 17 17:34:28 2009 +0000

    #i92516# handle pageoffset in vcl instead of application

Change-Id: I9548d15d57284a2d826239de57d0d1650bac4b82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160518
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 11:56:48 +01:00
Caolán McNamara
936fa218dd cid#1546298 COPY_INSTEAD_OF_MOVE
and

cid#1546297 COPY_INSTEAD_OF_MOVE

Change-Id: I8fbb2bb1692cc822a79652312c6268379226a9c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160517
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10 11:56:40 +01:00
Sahil
6e712d5bfa tdf#33210 Directly call the method, as it is inherited
ScTabViewShell inherits ScTabView, therefore HighlightOverlay()
can directly be called from ScTabViewShell instance.

Change-Id: I3804ee2fd8598a338bbafe01df7756190ade660c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159365
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-10 10:29:31 +01:00
Sarper Akdemir
9bc8918cf0 add explainer for the reasoning of fMaxPassStrengthEntropyBits
also fixes the typo in the fMaxPassStrengthEntropyBits variable name.

Change-Id: I7c9cfcea7253a3e07428c83008b0c072033f33c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160425
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2023-12-10 10:13:31 +01:00
Rene Engelhard
94d0cf4d4e add missing #if MORE_FONTS
since it nededs Source Han Sans since 9b5964cf59

Change-Id: I35bd30048b298e8cbdaf6de22ae2022d51415aa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160512
Tested-by: Jenkins
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-by: René Engelhard <rene@debian.org>
2023-12-10 09:05:54 +01:00
Thorsten Behrens
6fa6599963 Remove hard limit to c89 for clang
This seems no longer true: "Windows MSVC only supports C90 so force gnu89"

With that said, also do a revert:
 "external/libeot internally uses --std=c99, do not overrule that"

 This reverts commit 61a66b612e.

Change-Id: Id628131b4fa6b61e19da6d862d773ab36f201729
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160454
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-10 00:37:58 +01:00
Patrick Luby
f7e81a321b tdf#158461 eliminate flicker during live resizing
When using Skia/Metal, the window content will flicker while
live resizing a window if we don't send a paint event.

Change-Id: Ib3edc497e26e6abfdfd17a34f9269a3eae090805
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160519
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-09 23:07:58 +01:00