since vector is a moveable type, and we always initialise this field
Change-Id: Icd598ad942dcfbdf77c7c8eef9fa0b6b7c6fe1be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135134
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
and destroy when it is fully faded out. Otherwise windows runs out of
gdi handles with document with large number of page breaks
todo: rename some things in a follow up commit after this more easily
backportable commit is merged
Change-Id: Ibbe3cd00d1027ac34915c4bff73e3a330e300f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
make an owner for the PropertyMapEntries
Change-Id: Ie915a8a312f2b24488566814ad67fdeef89b5941
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135123
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update helpcontent2 from branch 'master'
to 76f954f62ccd344d1760970d13a84645ceb6dd5e
- tdf#91344 help for Writer "View" menu is not updated
Writer View menu Help page was already updated modulo
one minor correction in an embedded file.
Change-Id: I7eac912669a30b9d675a51b966dcf6497269f502
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135092
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Fixing z-order was incomplete for textboxes
(shape + frame pair), because only the frame
moved to back, but not the shape, covering the
textbox.
Regression from commit 504d78acb8
"tdf#143574 sw: textboxes in group shapes - part 1".
See also commit 0e6d963fbc
"tdf#138141 sw: fix textbox z-order".
Change-Id: I03e3b55302c984e5968e579e77ccd5ed0a336dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134942
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
to avoid of detaching connections between shapes,
when these connections were created in Impress.
Change-Id: I1bc90bb8a408546b303b70bcfb27d3549d5e72d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134940
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
As reported by Julien, once the mediawiki extension is installed, the
xHandler in framework::DispatchProvider::implts_searchProtocolHandler()
points to an UNO component implemented in Java, and we crash in
dynamic_cast<>(), at least on Linux with gcc 7.5 and libstdc++.
This dynamic_cast<>() call was added in commit
c0fa456436 (tdf#149261 sdext: fix crash on
starting the presenter console for the 2nd time, 2022-05-26), to allow
the presenter console to opt out from protocol handler caching. It was
expected that the proxy object created for a Java UNO component would
simply return nullptr when we try to dynamic_cast<>() it down to a C++
interface.
Fix the problem by moving the interface to an UNO one: this side-steps
the dynamic_cast<>() crash at the price of introducing an UNO interface,
which is not meant to be part of the public UNO API (but at least it's
not published).
It may still make sense to improve the bridges/ code at some stage to
not crash in dynamic_cast<>() on generated Java proxy objects.
Change-Id: Iaac44515339e0dc15dddc3be45ef7dee7331e47a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135114
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
If there is no color value we should not also try to write
transparency information: otherwise w:srgbClr will have no
parameter value and MS Word won't open such documents.
Change-Id: Id67f174c5ae9aadf90ae54c126aef9a43ff3ba17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134945
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
if there is a max/min set.
Change-Id: I2dc7ccccad9ec2aa7eb89d8b5fa137e077a846fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135105
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
and just feed the data in as we create it
Change-Id: I5112e0b61bc4f4976978d5e4724053ab9ffc97e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135102
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which lets me move data around instead of copying
Change-Id: Ibc7d8c2b5e0244537aa66561132facd93b424d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135101
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Removed unused variables in the 'with' statement as the syntax
allows the statement to be used without a variable.
Removed variables like 'xcomments' and 'xseedspin', which seem
to have been copied and not cleaned up.
Removed variables 'gridwin' and 'xCalcDoc' if 'gridwin' is not used.
Change-Id: Ia97692a0fb2e2af1d2693e09ac8f7c614360ade8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135042
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- map
<w:date>
<w:dateFormat w:val="..."/>
<w:lid w:val="..."/>
</w:date>
to the Date, DateFormat and DateLanguage UNO properties of content
controls instead of fieldmarks, which model content controls poorly
- fix CppunitTest_sw_ooxmlexport8's testN820509: date SDT is now a
content control
- add current date DOCX import
- fix CppunitTest_sw_ooxmlexport13's testDateControl: date SDT is now a
content control
- fix CppunitTest_sw_ooxmlexport13's testInvalidDateFormField: date SDT
is now a content control
- fix CppunitTest_sw_ooxmlexport5's testfdo83048: minimal support for
nested SDTs in DomainMapper::lcl_attribute()
- fix CppunitTest_sw_ooxmlfieldexport's testDateFieldAtEndOfParagraph:
date SDT is now a content control
- fix CppunitTest_sw_ooxmlfieldexport's testDateFieldInShape: date SDT
is now a content control
- fix CppunitTest_sw_ooxmlfieldexport's testSdtDateDuplicate: date SDT
is now a content control
- fix CppunitTest_sw_ooxmlfieldexport's testSdtDatePicker:
- retain placeholder
- retain data binding
- retain color
- fix CppunitTest_sw_ooxmlimport2's testTdf121203: date SDT is now a
content control
- fix CppunitTest_sw_globalfilter's
testDateFormFieldCharacterFormatting: date SDT is now a content control
- fix CppunitTest_sw_globalfilter's testDateFormField: date SDT is now a
content control
Change-Id: I5a4c34217d23ed6fa0916e4dd6290351456b7232
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135109
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 580f62a41db6366a3ab13bf16a96a643710605a3
- tdf#149253 improve help about anchoring
shared/01/05260000.xhp (Anchor)
* corrected entries for "to page" and "to character"
- removed double presentation of "Anchor" icon
+ add <relatedtopics> for Writer, with link to guide page
on positioning objects
- moved "note" on "Frame", which has been present since
initial checkin in 2004, to after the option "To Frame"
There is nothing special or unusual about anchoring to frame
that needs attention. Maybe this note should be deleted, but
have left it for now.
+ added variable to <h1> so heading and link can be embedded
* refactor to <h1>,<note>
shared/01/05260100.xhp (To Page)
* elaborate explanation of this option
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260200.xhp (To Paragraph)
+ add information about what positioning regions can be used.
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260300.xhp (To Character)
- remove incorrect limitation
* generalize the tip from ”image” to include frame and OLE object
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260400.xhp (To Cell)
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260500.xhp (To Frame)
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260600.xhp (As Character)
* correction to what changes the height of the current line
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/02/03200000.xhp (Change Anchor)
* Update command name
* refactor to <h1>,<menuitem>
swriter/guide/anchor_object.xhp
* make explanation more general than image
+ adding headings for ”Moving an Anchor” and ”Changing an Anchor”
+ added section ids so these can be embedded elsewhere.
* refactor to <h1>
shared/00/00040501.xhp
+ add additional toolbars that have Anchor icon, and make
an switchinline because Calc and Writer are different
+ add context menu access
+ indicated need to select an object before using command
* rename German ids
Change-Id: I43881be154163f71ca188a5446385e2dc5805f1e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134786
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
...introducing o3tl::cmp_equal etc. implementing C++23 std::cmp_equal etc., plus
an o3tl::IntCmp wrapper around it for convenient operator syntax
Change-Id: I1d2e0d1aef99c531039fb83de31ed8e6036fde03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135095
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
which we can std::move the data around, instead of copying
Change-Id: Id7aaad3970b942599807b7fda73d028f082a0f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
and save some copying
Change-Id: I34cbc2edfd53fcc440d1765dba471fcbb05b2b7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135088
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
...and simplify the remaining code using the (now const) nCacheSize
Change-Id: I4468cf223c158a318ba56ba63f5f60121c94f42d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134879
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Update helpcontent2 from branch 'master'
to 7bea4ecaa0fdc5dd19077c63f8901a4dde78cc67
- Consistently capitalize acronyms
Small follow-up/fixup for commit 2df65a1ff7072dc0ec866f5dfe11846c15208199
Change-Id: I16f4c999c03af3828d6a279e862cc4c88c642138
instead of Primitive2DContainer, because I want to change
Primitive2DContainer into a different data structure that
does not support cheap random access
Change-Id: I1bc55f2e21d9d5c4529c87be57a46aee63e04589
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135087
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The stack trace at the moment of calling implLookupClient with
nClient == -1 was:
> ucrtbased.dll!abort() Line 61 C++
> ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187 C++
> ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420 C++
> ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444 C++
> comphelper.dll!`anonymous namespace'::implLookupClient(const unsigned long nClient, std::_Tree_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<unsigned long const ,comphelper::OInterfaceContainerHelper4<com::sun:⭐:accessibility::XAccessibleEventListener> *>>>> & rPos) Line 139 C++
> comphelper.dll!comphelper::AccessibleEventNotifier::addEvent(const unsigned long _nClient, const com::sun:⭐:accessibility::AccessibleEventObject & _rEvent) Line 249 C++
> svxlo.dll!accessibility::AccessibleTextHelper_Impl::FireEvent(const com::sun:⭐:accessibility::AccessibleEventObject & rEvent) Line 1416 C++
> svxlo.dll!accessibility::AccessibleTextHelper_Impl::FireEvent(const short nEventId, const com::sun:⭐:uno::Any & rNewValue, const com::sun:⭐:uno::Any & rOldValue) Line 1408 C++
> svxlo.dll!accessibility::AccessibleTextHelper_Impl::ShutdownEditSource() Line 700 C++
> svxlo.dll!accessibility::AccessibleTextHelper_Impl::SetEditSource(std::unique_ptr<SvxEditSource,std::default_delete<SvxEditSource>> && pEditSource) Line 717 C++
> svxlo.dll!accessibility::AccessibleTextHelper::SetEditSource(std::unique_ptr<SvxEditSource,std::default_delete<SvxEditSource>> && pEditSource) Line 1548 C++
> svxlo.dll!WeldEditAccessible::ClearWin() Line 552 C++
> svxlo.dll!WeldEditView::~WeldEditView() Line 864 C++
> smlo.dll!SmEditTextWindow::~SmEditTextWindow() Line 85 C++
> smlo.dll!SmEditTextWindow::`scalar deleting destructor'(unsigned int) C++
> smlo.dll!std::default_delete<SmEditTextWindow>::operator()(SmEditTextWindow * _Ptr) Line 3129 C++
> smlo.dll!std::unique_ptr<SmEditTextWindow,std::default_delete<SmEditTextWindow>>::reset(SmEditTextWindow * _Ptr) Line 3276 C++
> smlo.dll!SmEditWindow::DeleteEditView() Line 853 C++
> smlo.dll!SmEditWindow::~SmEditWindow() Line 139 C++
> smlo.dll!SmEditWindow::`scalar deleting destructor'(unsigned int) C++
> smlo.dll!o3tl::default_delete<SmEditWindow>::operator()(SmEditWindow * p) Line 46 C++
> smlo.dll!std::unique_ptr<SmEditWindow,o3tl::default_delete<SmEditWindow>>::reset(SmEditWindow * _Ptr) Line 3276 C++
> smlo.dll!SmCmdBoxWindow::dispose() Line 931 C++
> vcllo.dll!VclReferenceBase::disposeOnce() Line 39 C++
> sfxlo.dll!VclPtr<vcl::Window>::disposeAndClear() Line 206 C++
> sfxlo.dll!SfxChildWindow::~SfxChildWindow() Line 198 C++
> smlo.dll!SmCmdBoxWrapper::~SmCmdBoxWrapper() C++
> smlo.dll!SmCmdBoxWrapper::`scalar deleting destructor'(unsigned int) C++
> sfxlo.dll!SfxChildWindow::Destroy() Line 176 C++
> sfxlo.dll!SfxWorkWindow::DeleteControllers_Impl() Line 599 C++
> sfxlo.dll!SfxFrame::DoClose_Impl() Line 133 C++
> sfxlo.dll!SfxBaseController::dispose() Line 981 C++
> fwklo.dll!`anonymous namespace'::XFrameImpl::setComponent(const com::sun:⭐:uno::Reference<com::sun:⭐:awt::XWindow> & xComponentWindow, const com::sun:⭐:uno::Reference<com::sun:⭐:frame::XController> & xController) Line 1485 C++
> fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Line 1696 C++
> fwklo.dll!framework::Desktop::impl_closeFrames(bool bAllowUI) Line 1702 C++
> fwklo.dll!framework::Desktop::terminate() Line 214 C++
> fwklo.dll!framework::CloseDispatcher::implts_terminateApplication() Line 543 C++
> fwklo.dll!framework::CloseDispatcher::impl_asyncCallback(LinkParamNone * __formal) Line 397 C++
> fwklo.dll!framework::CloseDispatcher::LinkStubimpl_asyncCallback(void * instance, LinkParamNone * data) Line 245 C++
> vcllo.dll!Link<LinkParamNone *,void>::Call(LinkParamNone * data) Line 111 C++
> vcllo.dll!vcl::EventPoster::DoEvent_Impl(void * __formal) Line 53 C++
> vcllo.dll!vcl::EventPoster::LinkStubDoEvent_Impl(void * instance, void * data) Line 48 C++
> vcllo.dll!Link<void *,void>::Call(void * data) Line 111 C++
> vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 2232 C++
> vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2800 C++
> vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 308 C++
> vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4214 C++
> vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5865 C++
> vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5972 C++
> user32.dll!UserCallWinProcCheckWow() Unknown
> user32.dll!DispatchMessageWorker() Unknown
> vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 475 C++
> vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 506 C++
> vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581 C++
> vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 474 C++
> vcllo.dll!Application::Yield() Line 559 C++
> vcllo.dll!Application::Execute() Line 452 C++
> sofficeapp.dll!desktop::Desktop::Main() Line 1600 C++
> vcllo.dll!ImplSVMain() Line 202 C++
> vcllo.dll!SVMain() Line 235 C++
> sofficeapp.dll!soffice_main() Line 94 C++
> soffice.bin!sal_main() Line 51 C
> soffice.bin!main(int argc, char * * argv) Line 49 C
Firing the event when we already set the id to mean "revoked"
seems wrong. Also use the correct type for the id.
Change-Id: Ie2e180c0c8c112023f789968ffa785f046de9d76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135058
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(*) we can move the data rather than copying
(*) it should definitely not be const
(*) we can use STL functions to do most of the work
Change-Id: I02b4cbbdeed0588d592f24942d31608f2119561c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135083
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Update helpcontent2 from branch 'master'
to 2df65a1ff7072dc0ec866f5dfe11846c15208199
- tdf#149010,tdf#148941,tdf#149012,tdf#149130 update to reflect changes
New labels were given to some controls on the Options tab for
Image, Frame, and OLE Object in tdf#149010 and tdf#148941.
This patch updates the relevant help page (the Options tab)
in the Properties dialog to reflect those changes.
Because some of the controls in the Options tab also appear
in the Descriptions dialog, and UI changes were made in that
dialog (tdf#148941), then the help page for that dialog is
updated as part of this patch.
Have also updated some access commands to OLE Object, which
were changed in tdf#149018
swriter/01/05060900.xhp (Options tab)
* "Names"-> "Accessibility" (tdf#149010)
and corrections to description
+ added an <embed> from the Description dialog page to provide
the new control label
"Alternate (Text Only)" -> "Text Alternative" (tdf#148941)
and the "Description" control, as well as the corrections
to the control descriptions.
+ add "Sequences" section heading, in anticipation of tdf#149010
(comment 7)
* corrections made to descriptions of "Previous Link" and "Next Link"
shared/01/05190100.xhp (Description dialog)
* Corrections made to Description dialog page, and control
descriptions embedded in the Options tab page. These corrections
were promised in 61b4b76000bd5adca504df0966ecef3410765ab3.
* "Title" -> "Text Alternative" (tdf#148941)
and corrections to description
+ added separate <section>s for "Text Alternative" and "Description"
so that they can be embedded in Options tab. By keeping them
separate, it is possible to move their position in the embedded
file or use separately, if necessary.
+ add <relatedtopics> and link to Options tab, so show an alternative
way to access the Text Alternative and Description fields.
simpress/guide/table_insert.xhp
* move two bookmarks out of <ol>, because it disturbed formatting.
* "Insert - Object" -> "Insert - OLE Object"
* refactor changed items to <menuitem>
* refactor to <h1>,<h2>,<note>
shared/01/04150000.xhp (OLE Object menu)
* "Object" -> "OLE Object"
* corrections to menu contents
* rename German id
swriter/00/00000405.xhp (access for Options)
+ added "right-click" instructions to howtoget
shared/00/00040502.xhp (access for Description)
+ added menu instructions for howtoget
* make corrections in what objects can be accessed by context menu
shared/00/00000404.xhp
* "Object" -> "OLE Object" for menu access
* "Formula" -> "Formula Object" for menu access
* "Insert - Object - Chart" -> "Insert - Chart" for menu access
* refactor changed items to <menuitem>
* rename German id
Change-Id: I1ddeb8d532b81f22eba2b1e480759775ff96969f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134191
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
