Commit graph

477423 commits

Author SHA1 Message Date
Andrea Gelmini
c3ac0f80b7 Fix typo
Change-Id: I8ebd08019541a22acfe763330c2579b9b5c4c7bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137638
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30 23:26:39 +02:00
Andrea Gelmini
10a213572b Fix typo
Change-Id: I55558e5252c238be2417d370040760ed9c450a4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137641
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30 23:25:48 +02:00
Hossein
67615c8461 Improve vcl scheduler documentation
* Fixed a heading problem
* Marked variables, functions and identifiers as fixed width
* Added several related links

Change-Id: If5e56c1e2a474fcfa52601ccda7911bf9e80c913
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137636
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-30 20:34:50 +02:00
Caolán McNamara
0482f156a0 gtk4: convert AtkObject::accessible-role to something else
we only use AtkObject::accessible-role for "static", but there doesn't
seem to be a good match to anything I can see in gtk4. convert it
to accessible-role of "alert" for lack of a better idea.

Change-Id: Ic0795fed006b827914f1319150a915187188a4db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137617
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-30 13:11:16 +02:00
Noel Grandin
640a6488a3 sc: allow undo of typing in 2 views independent from each other
This commit follows the same pattern as
    commit c72e500cca
    sw: allow undo of typing in 2 views independent from each other

with some changes since calc and writer have different undo/redo
infrastructure on top of SfxUndoManager.

Change-Id: Ib6e7e21caccb94752c01c529b5013553dba8b4f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-30 09:02:07 +02:00
Jim Raykowski
be32cb9210 Assert downcast
In this case it should be guaranteed that pField is a pointer to
SwGetRefField by:

else if (pField->GetTypeId() == SwFieldTypesEnum::GetRef)

To follow best practice to allow some diagnostic in debug mode,
assert(dynamic_cast) before using static_cast to downcast.

Change-Id: Ib2c6fb4259b66d5059f1886e23d05fc1c2aa3682
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137578
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-30 07:07:22 +02:00
Hossein
c2746a6656 Add help and list executables options for bin/run script
bin/run script is described as:

"simple wrapper script to run non-installed executables from workdir".

When the bin/run script was used without parameters, it was generating
error as it could not run the folder workdir/LinkTarget/Executable.
Now, we print usage instructions in this case, or when help is
requested with -h, -help or --help.

Also, now user can get the list of executables with -l, -list or --list.

In normal execution, the script's name is also printed. For example:

$ ./bin/run minvcl
Setting env variables and running workdir/LinkTarget/Executable/minvcl
...

Change-Id: I5c62c300d5247f55d1d1cfd095cecffc979d494b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137626
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-30 06:35:50 +02:00
Matt K
07250a8327 tdf#117967 Fixes Save confirmation dialog for user cancel
The "Confirm save" dialog is launched from SfxMedium::CheckFileDate
via "xHandler->handle( xInteractionRequestImpl );" and if the user
canceled it the error is saved in the SfxMedium via
"SetError(ERRCODE_ABORT);".  Then, control is returned to the
calling function SfxObjectShell::SaveTo_Impl which currently
doesn't handle the cancel error condition, so this change just adds
a check to detect it and return instead of doing more "save"
processing.  This return then goes to the calling function
SfxObjectShell::DoSave_Impl which also does some save processing
after cancel, in particular it updates the timestamps of the
current SfxMedium (which are checked in SfxMedium::CheckFileDate
from above and determines whether the "Confirm save" dialog will be
launched), so this change prevents the updates to the timestamps by
exiting early (i.e. before "DoSaveCompleted();" is called) if the
abort error condition is seen so as to avoid a timestamp comparison
result of equality which would prevent the "Confirm save" dialog
from showing on every subsequent save action from the user.  Now
the behavior is for the timestamp comparison to fail equality (as
would be expected if the file changed underneath the user) so as to
ensure the "Confirm save" dialog continues to show for every
subsequent save action by the user.

Change-Id: I9c4aefc163a06029c80a8a28cdf4a09dff0031a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137540
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2022-07-30 06:27:05 +02:00
Jim Raykowski
4531236933 tdf#149467 fix re-entrance crash
This crash is caused by an odd re-entrance happening. In this case
re-entrance to SwContentTree::UpdateTracking happens when
SfxHintId::DocChanged is broadcast from SwDocShell::SetModified when
GetContentAtPos is called from SwContentTree::UpdateTracking which
eventually causes a stack crash.

Getting model position for view point when getting content at
position (GetContentAtPos call to GetModelPositionForViewPoint)
shouldn't set the document modification state. Which is what happens
using the steps to repro this crash.

This patch disallows setting document modification state during the
DocumentStylePoolManager::GetFormatFromPool call from
SwTextINetFormat::GetCharFormat.

backtrace of last 100 levels before crash:

1   SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
551  0x7fffbddbde96
2   SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
665  0x7fffbddbe891
3   SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
4   SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
5   SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
211  0x7fffbdcf6f2f
6   SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
452  0x7fffbdcf7fa0
7   SwCursorShell::GetContentAtPos                      crstrvl.cxx
1370 0x7fffbd581050
8   SwContentTree::UpdateTracking                       content.cxx
3700 0x7fffbe9864a0
9   SwContentTree::TimerUpdate                          content.cxx
3589 0x7fffbe985474
10  SwContentTree::Notify                               content.cxx
3047 0x7fffbe9811ad
11  SfxBroadcaster::Broadcast
SfxBroadcaster.cxx           40   0x7ffff4180f32
12  SwDocShell::SetModified                             docsh2.cxx
1446 0x7fffbe53b663
13  SwDocShell::Ole2ModifiedHdl                         docsh.cxx
1150 0x7fffbe52d660
14  SwDocShell::LinkStubOle2ModifiedHdl                 docsh.cxx
1131 0x7fffbe52d597
15  Link<bool, void>::Call                              link.hxx
111  0x7fffbd8889f5
16  sw::DocumentStateManager::SetModified
DocumentStateManager.cxx     50   0x7fffbd888729
17  SwDoc::MakeCharFormat                               docfmt.cxx
861  0x7fffbd6ef2b8
18  SwDoc::MakeCharFormat_                              docfmt.cxx
883  0x7fffbd6ef43a
19  sw::DocumentStylePoolManager::GetFormatFromPool
DocumentStylePoolManager.cxx 1514 0x7fffbd89132c
20  sw::DocumentStylePoolManager::GetCharFormatFromPool
DocumentStylePoolManager.cxx 1718 0x7fffbd892d86
21  SwTextINetFormat::GetCharFormat                     txtatr2.cxx
144  0x7fffbdfa1a03
22  SwTextINetFormat::GetCharFormat                     txtinet.hxx
52   0x7fffbddb4f4e
23  CharFormat::GetItemSet                              atrstck.cxx
145  0x7fffbddb07e5
24  SwAttrHandler::PushAndChg                           atrstck.cxx
345  0x7fffbddb1047
25  SwAttrIter::Chg                                     itratr.cxx
102  0x7fffbddf02db
26  SwAttrIter::SeekFwd                                 itratr.cxx
296  0x7fffbddf1104
27  SwAttrIter::Seek                                    itratr.cxx
419  0x7fffbddf17b3
28  SwAttrIter::SeekAndChgAttrIter                      itratr.cxx
158  0x7fffbddf06e2
29  SwTextIter::SeekAndChg                              itrtxt.hxx
313  0x7fffbde01791
30  SwTextCursor::GetModelPositionForViewPoint          itrcrsr.cxx
1658 0x7fffbddff83f
31  SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
604  0x7fffbddbe337
32  SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
665  0x7fffbddbe891
33  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
34  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
35  SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
211  0x7fffbdcf6f2f
36  SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
452  0x7fffbdcf7fa0
37  SwCursorShell::GetContentAtPos                      crstrvl.cxx
1370 0x7fffbd581050
38  SwContentTree::UpdateTracking                       content.cxx
3700 0x7fffbe9864a0
39  SwContentTree::TimerUpdate                          content.cxx
3589 0x7fffbe985474
40  SwContentTree::Notify                               content.cxx
3047 0x7fffbe9811ad
41  SfxBroadcaster::Broadcast
SfxBroadcaster.cxx           40   0x7ffff4180f32
42  SwDocShell::SetModified                             docsh2.cxx
1446 0x7fffbe53b663
43  SwDocShell::Ole2ModifiedHdl                         docsh.cxx
1150 0x7fffbe52d660
44  SwDocShell::LinkStubOle2ModifiedHdl                 docsh.cxx
1131 0x7fffbe52d597
45  Link<bool, void>::Call                              link.hxx
111  0x7fffbd8889f5
46  sw::DocumentStateManager::SetModified
DocumentStateManager.cxx     50   0x7fffbd888729
47  SwDoc::MakeCharFormat                               docfmt.cxx
861  0x7fffbd6ef2b8
48  SwDoc::MakeCharFormat_                              docfmt.cxx
883  0x7fffbd6ef43a
49  sw::DocumentStylePoolManager::GetFormatFromPool
DocumentStylePoolManager.cxx 1514 0x7fffbd89132c
50  sw::DocumentStylePoolManager::GetCharFormatFromPool
DocumentStylePoolManager.cxx 1718 0x7fffbd892d86
51  SwTextINetFormat::GetCharFormat                     txtatr2.cxx
144  0x7fffbdfa1a03
52  SwTextINetFormat::GetCharFormat                     txtinet.hxx
52   0x7fffbddb4f4e
53  CharFormat::GetItemSet                              atrstck.cxx
145  0x7fffbddb07e5
54  SwAttrHandler::PushAndChg                           atrstck.cxx
345  0x7fffbddb1047
55  SwAttrIter::Chg                                     itratr.cxx
102  0x7fffbddf02db
56  SwAttrIter::SeekFwd                                 itratr.cxx
296  0x7fffbddf1104
57  SwAttrIter::Seek                                    itratr.cxx
419  0x7fffbddf17b3
58  SwAttrIter::SeekAndChgAttrIter                      itratr.cxx
158  0x7fffbddf06e2
59  SwTextIter::SeekAndChg                              itrtxt.hxx
313  0x7fffbde01791
60  SwTextCursor::GetModelPositionForViewPoint          itrcrsr.cxx
1658 0x7fffbddff83f
61  SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
604  0x7fffbddbe337
62  SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
665  0x7fffbddbe891
63  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
64  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
65  SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
211  0x7fffbdcf6f2f
66  SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
452  0x7fffbdcf7fa0
67  SwCursorShell::GetContentAtPos                      crstrvl.cxx
1370 0x7fffbd581050
68  SwContentTree::UpdateTracking                       content.cxx
3700 0x7fffbe9864a0
69  SwContentTree::TimerUpdate                          content.cxx
3589 0x7fffbe985474
70  SwContentTree::Notify                               content.cxx
3047 0x7fffbe9811ad
71  SfxBroadcaster::Broadcast
SfxBroadcaster.cxx           40   0x7ffff4180f32
72  SwDocShell::SetModified                             docsh2.cxx
1446 0x7fffbe53b663
73  SwDocShell::Ole2ModifiedHdl                         docsh.cxx
1150 0x7fffbe52d660
74  SwDocShell::LinkStubOle2ModifiedHdl                 docsh.cxx
1131 0x7fffbe52d597
75  Link<bool, void>::Call                              link.hxx
111  0x7fffbd8889f5
76  sw::DocumentStateManager::SetModified
DocumentStateManager.cxx     50   0x7fffbd888729
77  SwDoc::MakeCharFormat                               docfmt.cxx
861  0x7fffbd6ef2b8
78  SwDoc::MakeCharFormat_                              docfmt.cxx
883  0x7fffbd6ef43a
79  sw::DocumentStylePoolManager::GetFormatFromPool
DocumentStylePoolManager.cxx 1514 0x7fffbd89132c
80  sw::DocumentStylePoolManager::GetCharFormatFromPool
DocumentStylePoolManager.cxx 1718 0x7fffbd892d86
81  SwTextINetFormat::GetCharFormat                     txtatr2.cxx
144  0x7fffbdfa1a03
82  SwTextINetFormat::GetCharFormat                     txtinet.hxx
52   0x7fffbddb4f4e
83  CharFormat::GetItemSet                              atrstck.cxx
145  0x7fffbddb07e5
84  SwAttrHandler::PushAndChg                           atrstck.cxx
345  0x7fffbddb1047
85  SwAttrIter::Chg                                     itratr.cxx
102  0x7fffbddf02db
86  SwAttrIter::SeekFwd                                 itratr.cxx
296  0x7fffbddf1104
87  SwAttrIter::Seek                                    itratr.cxx
419  0x7fffbddf17b3
88  SwAttrIter::SeekAndChgAttrIter                      itratr.cxx
158  0x7fffbddf06e2
89  SwTextIter::SeekAndChg                              itrtxt.hxx
313  0x7fffbde01791
90  SwTextCursor::GetModelPositionForViewPoint          itrcrsr.cxx
1658 0x7fffbddff83f
91  SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
604  0x7fffbddbe337
92  SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
665  0x7fffbddbe891
93  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
94  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
168  0x7fffbdcf6c08
95  SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
211  0x7fffbdcf6f2f
96  SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
452  0x7fffbdcf7fa0
97  SwCursorShell::GetContentAtPos                      crstrvl.cxx
1370 0x7fffbd581050
98  SwContentTree::UpdateTracking                       content.cxx
3700 0x7fffbe9864a0
99  SwContentTree::TimerUpdate                          content.cxx
3589 0x7fffbe985474
100 SwContentTree::Notify                               content.cxx
3047 0x7fffbe9811ad

Change-Id: I7e0814cf3a42dc876dd60c926d4b2245a036cc3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135802
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-07-30 06:10:36 +02:00
Jim Raykowski
d87f69cc7e tdf#118696 better fix for sd Navigator object selection
resulting in unexpected view movement

This fix reverts commit 3c86ffd8de and
reintroduces DrawViewShell::MakeVisible with change made to the
passed object rectangle always being the snap rectangle instead of
the rectangle returned from a call to object GetLogicRect.

Change-Id: I05e777545fb1093838c05618e87ad4d4f5ec003c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137008
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-07-30 05:24:38 +02:00
Andrea Gelmini
597d21d0d0 Fix typo
Change-Id: I1b6c7eccebffc80b057eb2730428b20047ee685b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137625
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-30 04:44:26 +02:00
Andrea Gelmini
d4809b45c1 Fix typo
Change-Id: Ic4929dd699b4b28572e46c99ce49d95371b54bfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137624
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-30 04:43:59 +02:00
Adolfo Jayme Barrientos
1bdd72e2d7 tdf#150045 Set secondary/explanatory labels apart
Rationale in commit 0ebbe1f008,
of which this is a follow-up.

Change-Id: If75aa32bf02aeb8761f5b7f4ddbbeaa3bdcaab3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137618
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-30 04:21:21 +02:00
Mike Kaganski
bee22fd433 Verify signing certificate cryptographically before use in tests
Documents signed using an invalid (e.g., not having a trusted root)
certificate give signatures that obviously can't pass validity tests.

Change-Id: Id4b097516e06c548ea42cad65d76bbd8a6853cc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137620
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-29 22:55:07 +02:00
Caolán McNamara
d6c6fee69c Resolves: tdf#147782 restore focus to launching frame asynchronously
Change-Id: I7ebde70e4e1aae861f6ac7d70a91741596cb2cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137572
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29 21:36:13 +02:00
Caolán McNamara
275e05cc23 gtk4: update vcl when popup was closed by some external means
Change-Id: Ie580cd0b42ca1c928bfea20a4a9f1494021047d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137560
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29 20:54:04 +02:00
Caolán McNamara
ed4bf43b0b cid#1507489 Big parameter passed by value
and

cid#1507490 Big parameter passed by value

Change-Id: I53a8ee3fd0312de6fecd39238eff90cfff5b3261
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137588
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29 20:53:40 +02:00
Caolán McNamara
09607592b9 cid#1507491 cut and paste typo triggering 'Constant' variable guards dead code
Change-Id: I9b833575f3cc3ba886b355eefdfa9155d2dffae1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137587
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2022-07-29 20:53:05 +02:00
Tomaž Vajngerl
ce2003a672 svx: manipulate SdrObject::m_aOutRect indirectly
Change-Id: I0d8a8e4df06595250c07a61181fbd76fe1da5662
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137571
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-29 20:48:49 +02:00
Tomaž Vajngerl
f1436b235c svx: remove using namespace and unneeded "css::" ns declarations
Change-Id: If2eb5f61798e4efbcc845957fc1345b1560bcbe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137570
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-29 20:48:35 +02:00
Balazs Varga
7321db3cad Related tdf#117276 sc: Show hidden filter elements as inactive elements
Ignoring filtered-out value when we unselecting All, re-selecting All button,
hitting the Cross-button ("Hide only the current item") or hitting the
Check-button ("Show only the current item").

Followed up commit of 2d1df9f3dc

Change-Id: I33e169a08054f1afec887915730eeae9a26d4739
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137558
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2022-07-29 18:17:20 +02:00
Caolán McNamara
3777a1e769 cid#1507492 Improper use of negative value
Change-Id: I7c44307917df3397cfc9c99a982c54f51693e660
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137589
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29 18:05:08 +02:00
nazanin yadi
12f2622a69 tdf#87605 Add new words to technical dictionary.
Change-Id: Ic9eaf11c75f91812d3feb839f47e0898e12d65e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135455
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-07-29 16:37:56 +02:00
Mike Kaganski
8fc338f2af Better valid certificate check, consider filter data
Otherwise, testSignCertificateSubjectName that has an explicit certificate
subject name requirement would fail when user has other valid certificates,
but not this one.

Change-Id: Ic3c440a8316314c922a53a51085a3e829f235f6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137593
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-29 13:28:13 +02:00
Noel Grandin
7e3b3a9bd5 tdf#119840 make this loop a little more efficient
by breaking out early

Change-Id: I2444c9f8b79e0b517eb3ab3b19fed2d98c52a8e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137615
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29 13:21:18 +02:00
Noel Grandin
3df5be9210 use more SwPaM::StartEnd
which is more efficient than calling Start() and End() separately

Change-Id: I41c99527bcb37728bb9a87f63ed654e0be3d1f0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137614
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29 13:20:56 +02:00
Noel Grandin
af65e892dc clang-tidy modernize-pass-by-value in xmlreader
Change-Id: I448d3119129a864e79dbef336e46545f9aca8b25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137584
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29 13:10:15 +02:00
Julien Nabet
baf433a2f7 tdf#150187: Crash in Presentation Styles - Background objects - Modify
Regression from e85b482df3
(use SfxItemSet::GetItemIfSet in cui)

Change-Id: I74889f21f2bda248946269b0caf5ddc629002ae0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137580
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-29 11:05:52 +02:00
Caolán McNamara
047305b1dc gtk4: add an initial placeholder image to flag there will be one set later
Change-Id: Ib1696b16990d3ae08fd2be10cc9fe89322287369
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137576
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29 10:04:10 +02:00
Caolán McNamara
276bd8005c resave with latest glade
Change-Id: Ic47dd35a859723895d25ffa210d8cc8971c28e0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137575
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-29 10:03:36 +02:00
Balazs Varga
fe2d59a073 tdf#150100 sc import and UI: fix double cell border dialog
Hide "Hairline (0.05pt)", "Very thin (0.5pt)" and "Thin (0.75pt)"
predefined border types for Double cell borders, because it has a
minimum thickness 1.1pt, which means, we cannot allow to select them.
Also setting the Medium (1.5pt) predefined thickness to the border
width for Double borders as the thinnest possible predefined value.

TODO: tdf#146466: Inconsistent choices of borders between toolbar and sidebar

Change-Id: I46ccb206835a34a6dfaa39e63e614bb01bc6b02e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137441
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-07-29 08:53:49 +02:00
Xisco Fauli
4f61276dae svgio: Add support for clip-rule="evenodd"
Change-Id: I028aa88bdd72b4f87526a3d1edabd612d7686571
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137577
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-29 08:21:59 +02:00
Julien Nabet
d07f18e0c3 tdf#126754: Wrong OpenType tag for fractions in "font features" dialog
Opentype defines only "frac" and not parameters values like 1 or 2 for "frac"

See:
https://en.wikipedia.org/wiki/List_of_typographic_features
https://docs.microsoft.com/en-us/typography/opentype/spec/features_fj

So remove STR_FONT_FEATURE_ID_FRAC_PARAM_0/1/2
+ remove the extra ":" for STR_FONT_FEATURE_ID_FRAC

I gave a try with "Alegraya" font, it worked.
I also give a try with "Linux Biolinum G", there are still "None" (value "0"), "Diagonal fractions" (value "1") and "Nut fractions" (value "2").
It seems they're on the font itself like entry "'frac' Diagonal and nut Fractions".

So it shouldn't bring regression.

Change-Id: I2f46a3f4a53dc498b764dbeb1c1266589cc8d8c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137574
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-29 07:56:00 +02:00
Xisco Fauli
9507e96153 svgio: qa: add unittest for fill-rule
Change-Id: I76c0594d634c4154bd2b63027e93934b521998d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137573
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-29 02:32:03 +02:00
Justin Luth
fd428245bf tdf#148810 ppt import: Depth set by EE_PARA_OUTLLEVEL
It isn't enough to set Paragraph->SetDepth.
It must match the property set.

Change-Id: I96a22057c57ae869542b4ffbc069a7cd89bb06c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137543
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-29 01:45:55 +02:00
Justin Luth
be39a3d8c1 Revert "tdf#141652 partial revert "Reset ShapeProperty priority..."
This reverts 7.4 commit 18cc124056.

Someone backported it to 7.3 as well.

Change-Id: Ie04595e11dd9d2e15fa940b8ada71714bd434f6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137581
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-29 00:08:54 +02:00
Rafael Lima
cca8a19351 Update git submodules
* Update helpcontent2 from branch 'master'
  to fbbbb4dedd4e42ed16056ba9c98a829601f61833
  - Improve description of how to invoke Documents and Calc SF services
    
    Change-Id: Id9b9cc379bd838bdbae882554c8320f30595453e
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137416
    Tested-by: Jenkins
    Tested-by: Jean-Pierre Ledure <jp@ledure.be>
    Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2022-07-28 21:03:39 +02:00
Tomaž Vajngerl
89c7f5c5a8 oox export: export line/fill and text props. of a data table
Change-Id: I02a4c35693b599578e073d52a2d22ad59bc31786
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137409
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28 18:16:07 +02:00
Christian Lohmaier
67ed7f8e2d pdfium: fix build on windows aarch64 - no __popcnt
see https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics

Change-Id: I291f727c1aa6e00d02d2339fcb338159ae49d0c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137568
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-07-28 17:26:30 +02:00
Caolán McNamara
eaa0954fbf gtk4: don't attempt to create a visual junction between float and launcher
the alignment won't match when using GtkPopover to implement these,
there's an extra border+margin between the launcher and the contents

Change-Id: Idb78d903874fee5a28e87c89951d9b3f9063c547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137554
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-28 17:24:54 +02:00
Chris Sherlock
756ff6f6df vcl: Animation - cleanup pause functions and fields
Change-Id: I8a338a92823bd4e4c1f8123d52711d0925357ee6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76430
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28 16:27:19 +02:00
offtkp
a697296097 Use bitmap width instead of scanline size in combineScanlineChannels
Change-Id: I9f5de7ed1bdcd39e5d6e580a2edbd5c0dd2027e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137278
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28 16:25:49 +02:00
Chris Sherlock
2732115080 tdf#143148 tools: Use pragma once instead of include guards
Change-Id: Ie34bc66eb1dc475566b315db698976913c8aa37b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137390
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28 16:24:28 +02:00
Tomaž Vajngerl
6c2ae836aa chart2: set the char props. to the cells of a data table from model
This copies the char. properties from the model to the cells of
a data table, so the correct char width, font is used for text
when the table is rendered. Also add margin to the text, so it
looks better.

Change-Id: Ib74a8136459a31d64a86dec36a6ba14d2c313cf2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137408
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28 16:22:31 +02:00
Michael Stahl
0dcebde891 tdf#150181 vcl: first column is editable by default in SvTabListBox
(regression from commit fe38553aef)

Change-Id: I58e1afb228dfd87b7d642ccf1b58277960f01e14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137561
Tested-by: Jenkins
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-28 15:44:53 +02:00
Michael Meeks
a71a5cdb97 lok: add dumpState feature for better in-field diagnostics.
Always suspicious that some un-expected dialog / state can cause
strange behavior in a client. An initial cut at an API to make it
easier to unwind such problems by exposing the toolkit state.

Change-Id: If8f17943fa4837df4f9ca659a111dcdce5c23244
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137504
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-28 14:49:19 +02:00
Justin Luth
2b0626e2e9 remove unused SETBULLETTEXT flag in editeng
Already unused in initial import.

Change-Id: I423442a2b036c64727af608fa667f1f8a427391f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137542
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-28 13:27:58 +02:00
Julien Nabet
d39a6726b8 tdf#119246: Dimensions dialog has wrong values in several fields
Regression from a8dd49b9fc
Convert dimension lines tab page to widget UI

Min and max should be -10000 and 10000 (in mm).

Change-Id: I936857f4c10bd2b6fec7b0e492c069b88cc071dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137553
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-28 13:04:26 +02:00
Noel Grandin
156073b6ed these classes can be final
Change-Id: I84bb39b6365e445998a793798279c7f9f1064581
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-28 13:03:43 +02:00
Noel Grandin
031da439ac tdf#119840 elide some allocations
Change-Id: Ibff6a80a65463641337dc30d88c7ee8432cf816c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137551
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-28 13:03:30 +02:00