Commit graph

495515 commits

Author SHA1 Message Date
Noel Grandin
cc6e54736f replace createFromAscii with OUString literals in svtools
Change-Id: I51eb85b7beb850044d9e092989b7d34994588551
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167046
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-05-03 18:32:17 +02:00
Justin Luth
da86bfd89e tdf#160349: add .uno:ChangeTheme to notebookbar to toggle dark mode
A temporary (ugly, but appropriate) icon has been assigned.

The toggle can be customize-assigned to keyboard, menu, and toolbar,
and can be found by searching for "Dark Mode".

In the menu, it is checked when in Dark mode,
and in the toolbar it is "depressed" or highlighted as active.

Dark mode has been added to the view tab of notebookbar.ui.
I added it as NOT VISIBLE, for several reasons.
- dark mode is rather new and not so stable, so don't over-promote it.
- notebookbars cannot be infinitely customized by the end user,
  so developers have to add all items. Users only enable or disable.
- toggling dark mode really ought to be done at the OS level,
  and typically should be a one-time setting,
  therefore not appropriate to waste precious toolbar space.

The primary benefit of making it available in the menu
is for QA testers who want to easily switch back and forth.
WARNING: by customizing the notebookbar, you prevent seeing
any future NBB changes made to the program
(until you reset to defaults or blow away the user profile).

Dark Mode can easily be added to a menu, toolbar or keyboard shortcut
by the end user, so I didn't bother adding it anywhere else.

To avoid completely cluttering up this commit,
I only added Dark mode to the main notebookbar.
Once this commit has been finalized,
the other writer-apps and notebookbars can
also gain this command.

Change-Id: Ia7594ad81e305ead922abd0ad7b41d6fc0413053
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166781
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2024-05-03 17:58:15 +02:00
Miklos Vajna
9d95eb980e Related: tdf#160833 teach DOC export about DoNotMirrorRtlDrawObjs
See
<https://gerrit.libreoffice.org/c/core/+/167033/1#message-e1df9bf60b7b8b2acdf0c062484ddc572939a3d9>,
no need to undo the import-time mapping in case we know that the
mirroring is avoided at a layout level.

Change-Id: Idbdc10ad327540dc5045e9b19dd42160b5139470
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167049
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2024-05-03 16:28:04 +02:00
Christian Lohmaier
83c2ef7c78 turn gb_CustomTarget_get_workdir into error and remove old _repo_targets
separate commit since help submodule also uses the macro.

actually turn it into make error to prevent reintroducing it

the repo_target ones are from way back when the whole repo was
split up in many different ones and not used for many years,
no point in having those as errors

Change-Id: I9fd42529d08ea7859b33f8570936f06039cfa184
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167006
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-03 16:07:04 +02:00
Christian Lohmaier
9c4e0578ee Update git submodules
* Update helpcontent2 from branch 'master'
  to e8b21ab244345cea0a1d0b9190a8729ff3ea47b1
  - makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo)
    
    helpcontent2 portion
    
    Change-Id: I2e10bf8bf4cb39fa3a8f9a2c3eb8f22d8636560c
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167007
    Tested-by: Jenkins
    Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-03 16:06:40 +02:00
Christian Lohmaier
0c4c84a14b makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo)
…by a simple/static $(gb_CustomTarget_workdir)/foo

The build system has a lot of overly complicated leftovers from when it
was introduced and had not only deal with split repositories but also
had to coexist with another buildsystem. Along with lots of copy'n'paste
along the years the makefiles became hard to grasp for newcomers with
all our calls and evals.
As a first step to streamline that, the macros from TargetLocations that
simply prefix a static path to the argument (and similar of the same
kind) are a natural pick before simplifying the rules themselves/getting
rid of a bunch of eval statements.

Change-Id: Ia06dbbcd5d1994755a2ff05b84f72ccbc4e3cab5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167005
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-03 16:06:14 +02:00
Noel Grandin
d19b79e4b4 replace createFromAscii with OUString literals in sfx2
Change-Id: Ifc60fc260149106f257bf10551f081ce7d8fd6ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167039
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-03 15:57:46 +02:00
Moritz Duge
3bb9b0565a fix crash in CertificateChooser for GPG
mvUserData is still needed to keep it's content from being deleted.

Revert "Drop unused instance variable."

This reverts commit 687ae6ca01.

Change-Id: I689cfdaf8d4d62a3b53ff7fb318dc8c70b9e1c2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167020
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
2024-05-03 15:39:52 +02:00
Olivier Hallot
510e622495 Update git submodules
* Update helpcontent2 from branch 'master'
  to d5d56e1d29b65749978ae5e9801531200477761b
  - tdf#150760 Missing link for Column Width in Base.
    
    + refactor
    
    Change-Id: I30052dc59c9ec6de6f398b9052739b64396be3a6
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166878
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    Tested-by: Jenkins
2024-05-03 15:32:39 +02:00
Pierre
548fc442f5 tdf#160375 Base displays and gives the full name of the table
Change-Id: Icc8c6d85cc5a88461b7bd02487513e0e864bacef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166057
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-05-03 15:14:27 +02:00
Caolán McNamara
1425cbc50a WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I8a15be14850b9fe48f80820f4308c35748497727
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167034
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-03 15:01:33 +02:00
Noel Grandin
23d5c8ed00 replace createFromAscii with OUString literals in framework
Change-Id: I925d79877d477e6273e0ca8d8de7af391d72bb78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167038
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-03 14:03:57 +02:00
Miklos Vajna
0f41068046 tdf#160833 sw DoNotMirrorRtlDrawObjs: add UI in cui/
The UI code at lcl_ChangeResIdToVerticalOrRTL() was aware that
SwAnchoredObjectPosition::CalcRelPosX() mirrors the position when the
anchor paragraph is RTL, so swapped the "from left" label to a "from
right" label.

Don't do this when the compat option is enabled, so not only we render
correctly but the UI now correctly explains why we came up with the
correct position.

Change-Id: I479ed1f085b249d10be47b66d7a656dc1bd4f936
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167031
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2024-05-03 13:51:08 +02:00
Julien Nabet
62b08851dd Related tdf#150082: remove duplicate gssapi_client/gssapi_errmsg
Change-Id: I38be66163320c1408f5bbb846727994c92e3c246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167036
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-05-03 13:20:51 +02:00
Pierre
334585be92 tdf#160423 Base handle zoned time type correctly
Change-Id: Ib1b8f82295e861edb09e2f87deccc5b0edf8b296
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165560
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2024-05-03 12:35:58 +02:00
Jonathan Clark
14c6cde779 tdf#49885 Updated CJK BreakIterator to use ICU
Previously, the CJK BreakIterator used custom dictionaries for Chinese
and Japanese. This change removes these custom dictionaries in favor of
the upstream ICU implementation, which uses an externally-maintained
frequency dictionary for these languages.

This change also removes support code for dictionary-based break
iterators, as it is no longer used.

Change-Id: I55c4ce9c842d1751997309fd7446e0a6917915dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166136
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-03 12:30:59 +02:00
Xisco Fauli
d75a37a582 tdf#155651: Add support for "context-stroke"
Change-Id: Ib4f4a7b644d0d6c6b36e31b80fd7adc18999110d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167024
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-03 11:50:42 +02:00
Mike Kaganski
2aa310cfe0 tdf#160915: make own OLE objects obey AddReplacementImages setting
Change-Id: I25ce3c920dc8ba25d0ac14310ff9cba8a4c23c6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167026
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-03 11:19:04 +02:00
Xisco Fauli
9490972c04 Update git submodules
* Update dictionaries from branch 'master'
  to 0ca7301c3c00d6e7936fd912ba775d0008f7fee4
  - upgrade Ukrainian dictionaries to 6.4.4
    
    Change-Id: Idf246940bdf58844212420975ab52c19b08327ec
    Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166872
    Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
    Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
    Reviewed-by: Andriy Rysin <arysin@gmail.com>
2024-05-03 10:44:03 +02:00
Stephan Bergmann
9d84957863 Simplify condition
...after this got wrapped in an outer

> ifeq ($(OS),EMSCRIPTEN)

in cf0b0f0dd0 "Emscripten: Only add the --pre-js
code to the soffice executable"

Change-Id: Ic2b9ae7709a06146a206ebaa2ee8881387dae6b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166998
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-05-03 10:23:56 +02:00
Julien Nabet
68008d9f01 tdf#160916: typo "Checbox"
Change-Id: Ia06bc947cd1788850251b1386977ef0229dddd8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167030
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2024-05-03 09:51:04 +02:00
Caolán McNamara
8662a96c90 WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I9b2b86c26e08221c57735c6eda88727aa8a46b5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167021
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-03 09:17:09 +02:00
Caolán McNamara
3cc6384e41 WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: Ibca9433761e7a7f97383991429cf0d575b4ba3d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167018
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-03 09:16:48 +02:00
Noel Grandin
5edaca5c89 use boost::small_vector in cppuhelper
shaves 5% off startup time

Change-Id: I901e1112727eb7a50f70d1853386e0696fee7e5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167000
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-05-03 09:00:41 +02:00
Michael Weghorn
b7ba358d48 sd, svx: Return new annotation instead of using out param
Let `SdrPage::createAnnotation` et al. return the newly
created annotation rather than using an out parameter,
which makes this more straightforward.

Change-Id: Iee0561859756522ef33680c2cc9b492541a31d5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167019
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-03 08:11:53 +02:00
Noel Grandin
0c98269868 replace createFromAscii with OUString literals in framework
Change-Id: I4fccbfd57d942f64ce812c8a7e8e373296918af4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167011
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-03 08:00:49 +02:00
Noel Grandin
cea484870c replace createFromAscii with OUString literals in framework
Change-Id: Id6682230a08a21048879e739a2b1445210181c75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167012
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-05-03 08:00:38 +02:00
Noel Grandin
e0b159c1bc replace createFromAscii with OUString literals in filter
Change-Id: Ia3c4151a80be630d88b15dcb3de10ec4ddcca9d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167008
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-03 08:00:26 +02:00
Michael Weghorn
192bda8440 gtk4 a11y: Align role mapping with upstream GTK
Align the gtk4 a11y role mapping with what upstream
GTK 4 does with current git main (as of commit
0064500146fc080dae1ef2b30bebf7bb8b35a52f), see this
upstream GTK commit [0] and the one it refers to for
more details:

    commit ad8613876c753cea8695dc8b03dcd37eb8e723a5
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Tue Apr 30 14:44:11 2024 +0200

        a11y atspi: Improve mapping for container roles

        GTK_ACCESSIBLE_ROLE_GENERIC is for
        "a nameless container that has no semantic meaning of its own",
        for which AT-SPI role ATSPI_ROLE_PANEL [1]
        ("A generic container that is often used to group
        objects.") fits better than ATSPI_ROLE_FILLER
        ("A object that fills up space in a user interface."),
        so map to this one.

        With this in place, widgets like GtkBox are again
        reported with the panel role on AT-SPI level after
        commit a86923de943b6a42ba431be2a336972dca9c587d
        ("a11y: Change the role for many containers"),
        whose commit message suggests that the change
        on the AT-SPI level was unintended.

        For GTK_ACCESSIBLE_ROLE_GROUP, use the corresponding
        ATSPI_ROLE_GROUPING ("A group of related widgets.
        This group typically has a label.").

        [1] https://docs.gtk.org/atspi2/enum.Role.html

This causes the LO a11y roles `PANEL`, `SPLIT_PANE` and
`ROOT_PANE` to be mapped to the AT-SPI panel role again.

With the above-mentioned GTK upstream change, the native
GTK widgets now also use the panel role without having
to explicitly set anything on LO side rather than being
fillers, which removes the need to set them explicitly,
see the full commit message of

    commit f6ca163d3f
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Apr 26 12:43:24 2024 +0200

        gtk4 a11y: Don't create second AT context for OOoFixed

for more details.

Also, map the LO `FILLER` role to `GTK_ACCESSIBLE_ROLE_WIDGET`
which GTK maps to the AT-SPI filler role.
(The previously used `GTK_ACCESSIBLE_ROLE_GENERIC`
is now mapped to the AT-SPI panel role,  which
is for widget containers rather than fillers.)

[0] ad8613876c

Change-Id: I1d1a8f626911455481d2d722790e8915daa921c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166995
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2024-05-03 07:27:13 +02:00
Tomaž Vajngerl
6f7acc1486 jsdialog: support for LinkButton as an independent widget
This adds support for the (weld)LinkButton (FixedHyperlink) as an
independent widget and not part of FixedText to jsdialog. In addition
add "click" event that triggers activate_link method.

Change-Id: Id110b4a0fd60fc24592e00235243783d46ae4575
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166898
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-05-03 07:13:22 +02:00
Mike Kaganski
3f2d56d486 tdf#160901: partially revert 8557ea84c9
It turns out, that the horizontal scale is needed in the applied transform.

Change-Id: Ic07e015f0ddeee3d66653b683d83435d04b9ab81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167004
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-03 03:51:45 +02:00
Noel Grandin
3f4726c45e replace createFromAscii with OUString literals in forms
Change-Id: I688fbf8777736a3f55ab5c0d9c8acaf55f83d8b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167009
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-05-02 20:09:09 +02:00
Julien Nabet
e783a1c090 Extend silence strange -Wclobbered with GCC <= 14
See 2bcd9fe0fa
Silence strange -Wclobbered with recent GCC 14

Change-Id: Id51659cb8cd49b65c55b22ed0ac515a8ab609602
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166994
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-05-02 19:14:38 +02:00
Xisco Fauli
01f19161e9 CppunitTest_sw_uiwriter4: remove unneded Scheduler::ProcessEventsToIdle()
Added with 17b2f3d96f
"tdf#143320, tdf#143387: sw_uiwriter4: Add unittest"

Change-Id: I13dc9a540a37edf9e089df5af14342bc9032ee02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166999
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-05-02 19:10:28 +02:00
Noel Grandin
091c671832 replace createFromAscii with OUString literals in framework
Change-Id: I5209ab1b869492234946f8471a30c70121824198
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167010
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-02 17:51:30 +02:00
Olivier Hallot
694f63d27f Update git submodules
* Update helpcontent2 from branch 'master'
  to 92ee035a864bdd5691a589704a0b8cb609f2b0bb
  - tdf#159872 Help page for SEQUENCE Calc function.
    
    Change-Id: I76444cccc90320b2c774298f058c263fa30af51e
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166987
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-05-02 15:43:39 +02:00
Noel Grandin
d4c0e39d93 make the slot data constinit
because it takes a surprising amount of time to initialise it
at runtime during startup

(*) have to convert the std::function in SfxType to a
function pointer, because the std::function constructor
is not constinit compatible.

(*) the SfxType0..SfxTypeN types need some reinterpret_cast
to work around the lack of zero-sized trailing arrays in c++

(*) Sadly MSVC does not support taking the address of symbols
in constinit structures, so we cannot make the SfxSlot
array constinit.

Change-Id: I300ee770cc115d30bc25c819f2ad34b29633876c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166963
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-02 14:37:56 +02:00
Caolán McNamara
b26ff81a6f use [[noreturn]] instead of asserts that badUsage exits
Change-Id: I927434290b02b6cc0386b1e0038cd8385a762249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166996
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-05-02 13:21:40 +02:00
Samuel Mehrbrodt
62172db2d7 tdf#99528 Use vertical tabs in character style dialog
Change-Id: If6ae98f7d1ca1e92e38b1a277b528fa436791174
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166860
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-02 13:14:24 +02:00
Miklos Vajna
01dcc9a652 tdf#160833 DOCX import: use the DoNotMirrorRtlDrawObjs compat flag
The bugdoc has a shape which should be on the right page margin, but it
was on the left page margin.

Use the new compat flag to have a layout that matches Word.

This way we don't need to unmap the tweaked position at export time (a
limitation that the DOC filter has).

Change-Id: I38dfae370f275d9f0897198e7b0569f2d91dd352
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166993
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2024-05-02 12:08:31 +02:00
Miklos Vajna
ceaba8bf59 CppunitTest_sw_rtfexport5: avoid DECLARE_RTFEXPORT_TEST
No need to go via Writer-specific macros here.

Change-Id: I33d84275106ee3ff8a2f3356ae0c1c84d387cfd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166992
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-05-02 11:43:30 +02:00
Samuel Mehrbrodt
951562bc55 Save with newer Glade version
Change-Id: Id4d172ebb5265e418b9b3c8bea0a4dacf2ae27cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166745
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-02 11:18:00 +02:00
Arnaud VERSINI
7b8ef7cf92 i18npoool : use rtl::isAsciiDigit instead of local isnumber
Change-Id: I1e9df1b048169767e649fc825f7a49dac16c040f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166969
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-02 10:02:37 +02:00
Noel Grandin
fc7f871495 elide temporary OString in uui
Change-Id: I6510d930b13ee019d1a67810b02a5157834c7c24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166978
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-02 09:46:56 +02:00
Printf Debugging
09e135ab80 tdf#160780 Overlays should not cover EditView.
ScGridWindow::DrawContent(...) draws the spreadsheet elements.
ScTabView::SetNewVisArea() is called after DrawContent(...)
which calls UpdateAllOverlays(), and the overlays hide the EditView.
Redrawing EditView in SetNewVisArea() fixes the issue.

Change-Id: I768c8b7a1c9306fb94e82bca74ce0dcb2ced2782
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166784
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-05-02 09:32:39 +02:00
Caolán McNamara
41590e7d1f WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I8edb1fefe1b2b8a3db3ee8f3a0eed59c7f08a36e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166863
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-05-02 09:24:11 +02:00
Caolán McNamara
caf719c59c always check return of SfxViewFrame::Current()
Change-Id: If35fe03c775aec12ec534d02d58596aebcec764f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166985
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-02 09:23:59 +02:00
Caolán McNamara
50419ba811 cid#1596704 COPY_INSTEAD_OF_MOVE
Change-Id: I52867ef0a094e546a307b98089c259f9e8bbdabf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166984
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-02 09:23:52 +02:00
Mike Kaganski
0d82ddb39e tdf#160898: check for nullptr
Regression after commit d81379db73
(tdf#154877 sw: generalise ExtendedSelectAll(), 2023-05-09)

Change-Id: I9289171647fca8bd1b696399ff7c43a2ac7b8b30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166990
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-05-02 08:56:47 +02:00
Moritz Duge
687ae6ca01 Drop unused instance variable.
Change-Id: Iee32e4348526e54e0cc45a54e55eddb6479248e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166968
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-02 08:41:17 +02:00