This avoids re-entry to Document::handleParagraphNotifications, which
already was known to be problematic (see comments in Document::Notify,
and m_bSelectionChangedNotification introduced to avoid one such case).
Change-Id: I9e0b451f13ad109d08b1afc9cc0346cd6049b026
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175879
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Since
commit 4a4602ad75
Author: Michael Meeks <michael.meeks@collabora.com>
Date: Fri Mar 10 10:36:22 2023 +0000
lok: add trimMemory capability, and expand dumpState to caches
V625 Consider inspecting the 'for' operator. Initial and final values of the iterator are the same.
Change-Id: I9ddd2593ace4234f720a6561b0dcbd85dbc18ef2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175880
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
SfxStateCache had problems processing the extra Item
states disabled/invalid. Note that due to not using a
Pool here it is not possible to use an ItemSet or an
ItemHolder, those would automatically handle these
cases correctly.
In this cache, this currently needs to be done
handish. Also note that because of that this may break
again when changes in the Item/ItemSet/ItemHolder
mechanism may be done.
Change-Id: I007bc25c727e6432062fa0d2af8215a912cb2fff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175871
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to fd8e67a6f9d2cbf27e223f76bf96bc6cbae06b45
- Drop help for removed "Support assistive technology tools" option
This option no longer exists in the UI since LibreOffice core
commit [1]
commit 069d2c0796
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Oct 28 21:12:48 2024 +0100
win a11y: Drop "Enable AT Tool support" from options UI
, so drop the corresponding section from help, too.
[1] https://git.libreoffice.org/core/commit/069d2c079664cf44fc471216b1204cb71a6362cd
Change-Id: Icd48d2db877f18aa31500e590c485c7237a5d958
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175881
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Since
commit 1e58937522
Author: Szymon Kłos <szymon.klos@collabora.com>
Date: Wed Aug 10 14:43:51 2022 +0200
Make Autofilter MessageBoxes async
V763 Parameter 'nCol' is always rewritten in function body before being used.
Change-Id: Ibb8a8b63887d06913fffe310a6754fdbba8c61ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175875
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Sections and Objects are now toggled on/off independently from Text Boundaries. Both, single and multi-column sections receive a frame (multi-column in addition one for text boundaries).
Partially resolves 5bf7df62645f73ad69772f318ea3058dfd6fce12ommit.
Change-Id: I6d43f936c3d2e1c454fdc39f1bbbb2c6f7bef3e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175832
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
The iterators are invalidated on insertion / deletion;
store indices, and sanitize when obtaining iterators
Change-Id: I96ef4ca5bef4f686b5633cc736981dd5454dbca8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175852
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
IgnoreTabsAndBlanksForLineCalculation was added to the option->
writer->compatibility options with the label "Make whitespace
character height not affect line height"
Change-Id: I8b99409b01ba2af635018d15cde2e549dff92732
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175831
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
"On a specific file, when double-clicking multiple times on
different images in the navigator panel, LO crashes."
reported by Vladimir Tarakanov with a code pointer.
Regression since 3e0650fb16
"tdf#157533 sw: fix cursor position deselecting formula in table".
Change-Id: I550d61d8ee10205ff2357c2511ae0062077d651e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175865
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
If a CairoSDPR does directly render to a Window the changes
do not get reliably visualized due to the Cairo backend
and gtk/QT usage being dependent of being told what
'damage' is done to refresh the window accordingly.
The VCLCairoBackend is doing that, but without reach
from the outside.
Note that this is a rare case, in fact the 1st one discovered
where a CairoSDPR is painting to a Window directly, see
comments in the task. Even this occasion should not do
that - showing the Comments in Calc on the Overlay would
be major to just painting to the Window roughly.
There are other possible workarounds (also see comments in
the task), but just adding to be able to set the needed
'damage' in case target is a Window is simplest and
potentially the fastest way to do this.
Since usage of CairoSDPR is bound to use GetSystemGfxData
anyways it is okay to react there and call a method
ApplyFullDamage that exists on Graphics when the flag
USE_HEADLESS_CODE is active. That forwards to the
CairoCommon being responsible for that Window and does
the minimal necessary to apply 'damage' to the full
Window.
This is done when constructing the CairoSDPR, thus
from the timing that incarnation can then paint anything
and it seems that at the next occasion something can
handle the callback from gtk all is painted. If that
should change it may get necessary to separate
the usage of ApplyFullDamage from GetSystemGfxData,
but works as intended for now.
Change-Id: I5442f3413e43418954da29a18d66dea27e25e655
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175794
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
which allows us to eliminate a bunch of rounding at various layers, and
consequently maintain a lot more precision
Change-Id: I911dedd7c041c1d67396c082e5695346ea689acb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175814
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Records is not a very intuitive label for the the treeview section of
the dialog. Change to "Rows: " and "Columns: " based on what's being
displayed in the dialog
Change "Compare: " to "Compare by: "
Change-Id: Idff5f4a6935856f2c5a16f5b45bf8ce0ba169ca4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175704
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
This was seen when checking grammar checker suggestion.
When I click on the top element of the context menu of
underlined text (e.g. Grammar error), I get
warn:lok:1663798:1663791:desktop/source/lib/init.cxx:283:
lok exception 'Failed to dispatch .uno:None'
This .uno:None was introduced by Tamas Zolnai especially for
LOK: 3616bb68f2
His intention was to add an empty command that does nothing.
Change-Id: I12a9a1e17dcf65cdd78266f44e6201ed3d5fa01f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175102
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit bdb0dd485da24a95b61df6136362ab189803bc27)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175845
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins
V1048 The 'bDoIncrement' variable was assigned the same value.
Change-Id: Id5fd249b94429c80898e8ab1553ef32066313d1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175204
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 962, 979
Change-Id: Ic31a6129828a41bd3450567ca8cb8884d60691cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175220
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 944, 957
Change-Id: Ic637d4aa5e6024cc0011e8e51a0fba68c2644378
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175225
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
V1037 Two or more case-branches perform the same actions. Check lines: 579, 584
Change-Id: Ifccc082caa5d8c13c92f3d4098f03fbf3c9782a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175215
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
V1037 Two or more case-branches perform the same actions. Check lines: 981, 984, 1056
Change-Id: I5e1578341075dfb8f6699fca3f5468de1eeef70b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175212
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
broadcast was set from sw::UpdateFramesForRemoveDeleteRedline
which triggered SwPostItMgr::Notify
in that case SwFormatFieldHintWhich::INSERTED may have pField which maybe different from SwPostIt
fixed regression from 0b7a9c231f
problem:(in LOK)
with tracked changed on delete a merge field
then reject the changes
LOK will crash
Change-Id: Ic1fafa1408d7a238133f5b3d18bf948d539aa991
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175808
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175833
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
This is because the original label was taking a lot of space on the
notebookbar. Other suggestion was 'Manage Duplicates', which didn't
seem any better than 'Handle Duplicate Records' as when an icon for the
command is added, it will end up taking a good amount of space.
Change-Id: I852bd897d68648208102861de3d8131e103f4f14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175826
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
New option introduced under Formatting Aids to switch between full
and crop marks, which was done before via NPC
Change-Id: I920f68b571da740e47ae367ba1e8d28e03a131e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175828
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
New scroll distance was previous distance multiplied by speed factor, but distance was not reset to base values when mouse not moved (or outside app window on some platforms), resulting in continuous multiply amplification. Break out base scroll values to separate variables to prevent multiply feedback. Add comments to help future code maintenance.
Change-Id: If11baff3b25521abce7436b44aaf8e6a19e54f45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175657
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Since
commit 9f078ed7b6
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue May 7 10:04:16 2024 +0200
tdf#160971 gtk3 a11y: Set role for custom editable combobox
Set the combobox a11y role for the box in the .ui file
used for the custom gtk3 combobox implementation.
With this in place, moving focus to the "Font Name" or
another editable combobox in the Writer toolbar now
makes Orca announce that one as "editable combobox"
rather than just "text".
, the combobox a11y role is set for the GtkBox of
the custom combobox implementation used for gtk3.
That box contains the edit (for editable comboboxes)
and the button.
While this is needed for editable comboboxes for
AT to identify this as a combobox when the edit
receives focus (by the fact that the edit's parent
has a combobox role), this resulted in Orca no
longer announcing the combobox role when the
button receives focus for non-editable comboboxes.
While the button also has the combobox role, Orca
has logic to not announce the role of combobox
children. (`SpeechGenerator._should_speak_role`
returns `false` for that case [1].)
To avoid this problem and make announcement for both,
editable and non-editable comboboxes work as expected,
no longer set a combobox role for the box in the .ui
file, but set it only for the editable combobox
in the C++ code.
[1] 78e44c625e/src/orca/speech_generator.py (L365-366)
Change-Id: Ia3ff00688f47e61d5a98c79f1a256061b2fb18a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175823
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
...and just unused dummies since 3.1.58, so don't install them for >= 3.1.58,
even if the dummies would still be available for < 3.1.68
Change-Id: Ida55be2fa3b75982bfd764b7b2676e63c092fe79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175822
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
Add .ui file for the print progress dialog that gets shown when
starting a print job from the print dialog (Ctrl+P) to list of files
supported by QtInstanceBuilder, so that native Qt widgets are used for
that dialog now when using the qt5/qt6 VCL plugins, unless environment
variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
Change-Id: I4bfdd34fcdb6d5844e04d99235fbf3ad5ef9f66c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175817
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add a new QtInstanceProgressBar class that is
the weld::ProgressBar implementation using a native
Qt widget. The widget used is a QProgressBar.
This will be used e.g. by the print progress
dialog, for which support will be declared
in an upcoming commit.
Change-Id: Ic4b162014cd3a09801096cebd38dbdc923f5dbfa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175816
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Switch the order in which the children of the "grid3" grid in the
.ui file are defined so that the order matches the visual appearance,
which makes sure that tab focus order with the Qt-based VCL plugins is
correct as well in the "Tools" -> "Options" -> "LibreOfficeDev"
-> "Security" -> "Options..." dialog.
See
commit 02692566ad
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Oct 24 17:43:35 2024 +0200
tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
for more background.
Change-Id: Iffba59ba04ecfd3fcb900e09ad013e6f498beff8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175815
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add .ui file for the "Help" -> "Restart In Safe Mode" dialog that
asks whether to really restart in safe mode to list of files
supported by QtInstanceBuilder, so that native Qt widgets are used for
that dialog now when using the qt5/qt6 VCL plugins, unless environment
variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
Change-Id: Idec1c2dedd057aa2322453471c55022442941f7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175807
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
