Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ia1b6e58623b64b11cb1a5ac5c7fba73e8cc04d07
Reviewed-on: https://gerrit.libreoffice.org/75522
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
related to commit 4c30848c85
"tdf#123627 DOCX import: fix relative hyperlinks to documents",
until fixing possible profile-dependency of the unit test.
Change-Id: Ie75c5c7d8eeb467638f868fb727948f7f13fc113
Reviewed-on: https://gerrit.libreoffice.org/76332
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Reverse calculation of handle position of ooxml-parallelogram shape
has to follow the x/ss*100000 pattern. Error was, that it was not
listed in that section.
Change-Id: I846c21fe12c7e64e0c947e32d4b680fba60a5e50
Reviewed-on: https://gerrit.libreoffice.org/76311
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Issuing DOCUMENT_SIZE_CHANGED triggers document-loaded event.
This is accidental and historic, but the end result is that
the client assumes everything is invalidated and fires
initialization handlers, which are normally invoked the
first time a document is loaded. Undesirable when really
nothing has changed.
Change-Id: Ia4fa4479ca627b0f605e4ff5009f7e631a26f6d7
Reviewed-on: https://gerrit.libreoffice.org/76313
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This happens when we get multiple created events on
same window, interspersed with invalidations.
Change-Id: I2dbaa0f84306d770f1de047a23996209c28304fe
Reviewed-on: https://gerrit.libreoffice.org/76312
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Might help in some cases in the customer application.
Change-Id: Icdc13780d4623e9df8bc057760c1295d7d6ffd61
Reviewed-on: https://gerrit.libreoffice.org/76294
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins
This guarantees that the correct size of the window
is set on the client side. Some windows are created
with default (and invalid) size and rely on Resize
to be called right after. This doesn't happen
with message boxes and they need to get size_changed
right after the window is fully created and ready.
Change-Id: I8c281a31770de4b37b9de6d333159e5379344dff
Reviewed-on: https://gerrit.libreoffice.org/76293
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Apparently we did not have the pInputWin living in the background; but
now we have. There is no reason to treat it in an 'else' branch, these
checks should be separate either way.
Change-Id: Ibb8d92fb1e2803942460d2063847917d082fcb2e
Reviewed-on: https://gerrit.libreoffice.org/71863
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/76292
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This limits duplicate cursor invalidation removal to same
view only, which seems to have been left in error.
We should now remove any old cursor invalidations (for
the same view) and only keep the latest (current) one.
Change-Id: Ie2323d0c5fcf3977576a1bdc098c95351a5753e0
Reviewed-on: https://gerrit.libreoffice.org/71846
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 8e9c36dfc3)
Reviewed-on: https://gerrit.libreoffice.org/76286
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
We don't need to pop the Core Graphics context state stack completely
before releasing the context. The code that tried to do that failed
anyway when the context was a "foreign" one (from doc_paintWindowDPI()
in core's init.cxx) thad had already been released there.
Also removed another apparently unnecessary ifndef for iOS.
Change-Id: Idcd1e6edd06ab259ec850fd66fcbabc3df0ae3af
Reviewed-on: https://gerrit.libreoffice.org/76263
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Revert "tdf#86087 DOCX Import link as relative if preferred"
This reverts commit 40acf8d644.
Relative urls aren't converted to absolute urls, if the
"Save URLs relative to filesystem" setting is checked.
Change-Id: I209fa57e508dd425772e0019c1749a2bdc92e3ed
Reviewed-on: https://gerrit.libreoffice.org/75863
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
...as happens during `convert-to pdf doc/ooo107799-1.doc` (i.e., oracle apex.doc
attached at <https://bz.apache.org/ooo/show_bug.cgi?id=107799#c1>):
> ==29889==ERROR: AddressSanitizer: heap-use-after-free on address 0x61200034f548 at pc 0x0000002ebcaa bp 0x7fff9666f320 sp 0x7fff9666ead0
> READ of size 16 at 0x61200034f548 thread T0
> #0 in __asan_memcpy at /home/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:22:3
> #1 in SwRect::SwRect(SwRect const&) at sw/inc/swrect.hxx:313:5
> #2 in SwRootFrame::PaintSwFrame(OutputDevice&, SwRect const&, SwPrintData const*) const at sw/source/core/layout/paintfrm.cxx:2971:12
> #3 in SwViewShell::PrintOrPDFExport(OutputDevice*, SwPrintData const&, int, bool) at sw/source/core/view/vprint.cxx:542:30
> #4 in SwXTextDocument::render(int, com::sun:⭐:uno::Any const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) at sw/source/uibase/uno/unotxdoc.cxx:3026:32
> #5 in PDFExport::ExportSelection(vcl::PDFWriter&, com::sun:⭐:uno::Reference<com::sun:⭐:view::XRenderable> const&, com::sun:⭐:uno::Any const&, StringRangeEnumerator const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue>&, int) at filter/source/pdf/pdfexport.cxx:227:34
> #6 in PDFExport::Export(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) at filter/source/pdf/pdfexport.cxx:939:28
>
> 0x61200034f548 is located 8 bytes inside of 272-byte region [0x61200034f540,0x61200034f650)
> freed by thread T0 here:
> #0 in operator delete(void*, unsigned long) at /home/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cc:172:3
> #1 in SwPageFrame::~SwPageFrame() at sw/source/core/layout/pagechg.cxx:301:1
> #2 in SwFrame::DestroyFrame(SwFrame*) at sw/source/core/layout/ssfrm.cxx:389:9
> #3 in SwRootFrame::RemovePage(SwPageFrame**, SwRemoveResult) at sw/source/core/layout/pagechg.cxx:1426:5
> #4 in SwRootFrame::RemoveSuperfluous() at sw/source/core/layout/pagechg.cxx:1501:13
> #5 in SwLayAction::InternalAction(OutputDevice*) at sw/source/core/layout/layact.cxx:494:30
> #6 in SwLayAction::Action(OutputDevice*) at sw/source/core/layout/layact.cxx:349:5
> #7 in SwRootFrame::PaintSwFrame(OutputDevice&, SwRect const&, SwPrintData const*) const at sw/source/core/layout/paintfrm.cxx:2965:17
> #8 in SwViewShell::PrintOrPDFExport(OutputDevice*, SwPrintData const&, int, bool) at sw/source/core/view/vprint.cxx:542:30
> #9 in SwXTextDocument::render(int, com::sun:⭐:uno::Any const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) at sw/source/uibase/uno/unotxdoc.cxx:3026:32
Change-Id: I2931920d19d535f569c61fb9d7f1ce21bf7a0d88
Reviewed-on: https://gerrit.libreoffice.org/76270
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins
This is a problem since commit df9243626b
(fdo#73606: Avoid excessive and unnecessary heap allocation of array
objects., 2014-01-14), though it seems this uncovered a problem that was
introduced earlier.
Reading ScViewFunc::AdjustBlockHeight(), commit
64a36fd4f4 (ScUndoPaste to handle multiple
ranges., 2011-09-09) changed ScUndoPaste::DoChange(), so that
AdjustBlockHeight() is invoked in a loop, but always with the same
arguments. In case AdjustBlockHeight() doesn't get a mark data, the
function takes the mark data from the view data, which is empty in the
"undo of paste" case, so no row height gets updated.
Fix the problem by explicitly providing the mark data to
AdjustBlockHeight(), probably that was the intention in the second
commit.
[ Testing this from CppunitTest_sc_copypaste means ScImportExport has to
be dllpublic, but that seems still better than having a view shell in
CppunitTest_sc_ucalc. ]
Change-Id: I140b53588d59d231772152c0e820e5fdedf6894c
Reviewed-on: https://gerrit.libreoffice.org/76265
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
The patch handles the created QR code as a Customized Shape (Graphic
Object)
Change-Id: I1cee6f0e7fac585de880a9ac34e3bc441a4b7390
Reviewed-on: https://gerrit.libreoffice.org/74167
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
