Commit graph

475962 commits

Author SHA1 Message Date
Caolán McNamara
f90239263f tdf#117006 gtk: detect High Contrast
similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1606038

.e.g. gnome a11y menu, pick "High Contrast"

Change-Id: I60643b3a37b722230d5ed47082e4a6491d005ce4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135179
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-31 16:04:39 +02:00
Michael Stahl
225d8f31ad curl: remove curl-7.26.0_win-proxy.patch
There is no justification why this patch was added, upstream doesn't
want to add such a feature[1], and maintaining feature patches in LO
for bundled externals doesn't make sense.

Also, this doesn't respect the Inet::Settings::ooInetHTTPProxy*
settings from the configuration.

Let's remove it and hope nobody complains.

[1] https://curl.se/mail/lib-2022-05/0083.html

Change-Id: I1ccdefb76f69e6795a28d4d25bf443555c16ab0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135182
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-31 15:59:28 +02:00
Xisco Fauli
c5ca8b5bff crashreportScraper: use timeout in requests
Change-Id: I03f8740fc124c11d250368034bf6e14239df5abe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135180
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-31 15:43:36 +02:00
Noel Grandin
5ecdedbf81 clang-tidy modernize-pass-by-value in basic
Change-Id: I9034ab95a4ccb58e36e77d911dd33cc50857c03a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135176
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-31 15:11:27 +02:00
Noel Grandin
af44198d80 these can be stack allocated
Change-Id: Idd2e5e49ba4fcef2e80fd9c569f374a6a69f380e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135175
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-31 14:55:23 +02:00
Stephan Bergmann
6f26b6aeca Use more appropriate type for comphelper::internal::OPropertyAccessor::nPos
Change-Id: Ia7055dcc3832002fd10ae23a35fd08df5a98ae40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135177
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 14:53:25 +02:00
Stephan Bergmann
2a263cbdaf tdf#145527 Revert "Related tdf#116767: Call URLClassLoader.close"
This reverts commit 418533f0af.  Turned out that
closing the given URLClassLoader once the script's main class has been loaded
prevents the script from loading further classes located next to that main
class.  So abandon the Coverity suggestion that such class loaders should be
closed promptly to avoid resource leaks.

Change-Id: I1bcf83117836cfe317eac9850d413f2c3767bd8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135158
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 14:51:57 +02:00
Miklos Vajna
5f33515445 sw content controls, date: add insert UI
- handle the date case in SwWrtShell::InsertContentControl()

- expose this as a new .uno:InsertDateContentControl command

- add the new uno command to the default & MS-compatible menus

- hide the old .uno:DatePickerFormField from the menus that has the
  problems described in the sw::mark::DateFieldmark documentation.

Change-Id: If3c1050d6a8302be0da4a11067a67805396dec48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135153
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-05-31 14:39:26 +02:00
Olivier Hallot
2ad445acad Update git submodules
* Update helpcontent2 from branch 'master'
  to 4bbaecd77c87afee5453dc89a9e033d4048c909e
  - tdf#107078 New way to load color palette
    
    As color, hatching and gradient palettes are now handled by
    extensions, this patch include:
    - Refactor of xhp tags
    - move palette_file from simpress/ to shared/
    - adjust tree files
    - add entry to shared/guide tree
    
    Change-Id: Ied501dd86431d26d09ed91249c22f422620b16d6
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135096
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-31 13:17:14 +02:00
Attila Bakos (NISZ)
445d4ce232 tdf#147991 PPTX export: fix bullet indent regression
Instead of exporting the inherited master slide indent
values of the placeholders, export 0 indent value for
removed/disabled bullets to fix interoperability.

Regression from commit f57cfddb51
"tdf#145162 PPTX export: fix extra bullet regression".

Change-Id: Icbf823adc07f19fd10d1a60da9cff17616a2aef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135025
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-31 13:00:38 +02:00
Andreas Heinisch
b94275f6d2 tdf#149157 - Break multiline continuation in a comment after a new line
Change-Id: I3dd875152a6f2cfafb67f13f597c36f01a4759b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135018
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-05-31 12:30:21 +02:00
Martin Srebotnjak
7d25b8544b Update git submodules
* Update translations from branch 'master'
  to ed14d57f503d87230572addc845e16da818e530a
  - Updated Slovenian translation
    
    Change-Id: I80fee32feef0bc879ab0d0ff1b420074e9ea47d1
2022-05-31 11:43:32 +02:00
Xisco Fauli
bf6c74f1bb crashreportScraper: Add new column to show the stack code
Change-Id: Id6f9ed8540a8615a80de9cc561579ce069992e85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135142
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-31 11:10:00 +02:00
Michael Stahl
aa8ef74b47 g: we are not, in fact, in the BUILDDIR
For an out-of-tree build, "make fetch" poinlessly clones all git
submodules.

Change-Id: If4afb218946f49ba934f68b35806fd8143c39387
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135143
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-31 10:29:45 +02:00
Thorsten Behrens
49f62ab95e Revert 6eeb0942c3
Change-Id: I096f25d38f19fb728110e209a189f89a8e8d402f
2022-05-31 09:39:56 +02:00
Miklos Vajna
b0386e4d02 CppunitTest_sd_tiledrendering: reduce test doc size in testTdf104405
The actual image content is not interesting, so it can be a tiny one.

Change-Id: I74e404f53b9674b44963313b096ddd8e1c40e146
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135141
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-31 09:26:18 +02:00
Andras Timar
090ed6199e date picker should rather show the current date instead of February 14, 2019
Change-Id: Ie449873aad40b6f02198a8a44a7eae1aaba1cfae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135148
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-05-31 09:25:43 +02:00
Seth Chaiklin
caf924d1d9 Update git submodules
* Update helpcontent2 from branch 'master'
  to 1d8c6f2f81847b48e2c24b5ee1b0af8a7a5c0b5d
  - followup to 580f62a41db6366a3ab13bf16a96a643710605a3
    
       add a sentence -- mentioned in tdf#149253, comment 3
       -- but not included in
       580f62a41db6366a3ab13bf16a96a643710605a3 as intended.
    
    Change-Id: I8ff660372a8bfc62aff2082ed870c5d795d69d90
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135156
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
    Tested-by: Jenkins
2022-05-31 02:42:15 +02:00
Seth Chaiklin
95b673946c tdf#149253 improve tooltip for Anchor icon
* Tooltip explains the purpose of the command icon
     * Change "Label" to give better indication of the command
        function in Customize menu
     o no changes to label in menu and context menu

Change-Id: Ibffb673d5c37ebf7b38a1eea61affc22bdd3bf91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134791
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-05-31 02:21:19 +02:00
Eike Rathke
dfd5081ff3 InsertMatrixFormula: correct references for across sheets array formulas
Inserting an array/matrix formula across two or more
selected/marked sheets generated wrong matrix offset references
starting with the second sheet, pointing to the top left of the
first array formula. Only the top left cell of the inserted
formula on each sheet displayed the correct value. Deleting the
array formula on the first sheet then left all matrix offset
references on the remaining sheets with #REF! errors and those
cells could not be deleted anymore because their original parent
cell was gone.

Change-Id: If5d53311f9aabdcd7432ff26ab555bb91b0b121d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135147
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2022-05-31 00:11:20 +02:00
Stephan Bergmann
72c42be077 Use o3tl::make_unsigned, nCount is already asserted non-negative here
Change-Id: I7213e9f2e3a5a4a785d44932900496a791b1964a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135146
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-30 23:36:15 +02:00
Stephan Bergmann
26143512e5 Use more appropriate index variable type
Change-Id: Ieb3ed7931361e38ce62cd4dfa98b9712e4181d03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135145
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-30 23:32:55 +02:00
Stephan Bergmann
a9eed29a7c Fix linking Library_evoab
> ld.lld: error: undefined symbol: LanguageTag::~LanguageTag()
> >>> referenced by NResultSet.cxx:82 (connectivity/source/drivers/evoab2/NResultSet.cxx:82)
> >>>               /home/sbergman/lo3/core/workdir/CxxObject/connectivity/source/drivers/evoab2/NResultSet.o:(connectivity::evoab::ComparisonData::ComparisonData(std::__1::vector<connectivity::evoab::FieldSort, std::__1::allocator<connectivity::evoab::FieldSort>> const&))
> >>> referenced by NResultSet.cxx:82 (connectivity/source/drivers/evoab2/NResultSet.cxx:82)
> >>>               /home/sbergman/lo3/core/workdir/CxxObject/connectivity/source/drivers/evoab2/NResultSet.o:(connectivity::evoab::ComparisonData::ComparisonData(std::__1::vector<connectivity::evoab::FieldSort, std::__1::allocator<connectivity::evoab::FieldSort>> const&))

after 7b87afa899 "clang-tidy
modernize-pass-by-value in unotools" changed

> --- a/include/unotools/intlwrapper.hxx
> +++ b/include/unotools/intlwrapper.hxx
> @@ -61,7 +61,7 @@ private:
>      void                ImplNewCollator( bool bCaseSensitive ) const;
>
>  public:
> -    IntlWrapper(const LanguageTag& rLanguageTag);
> +    IntlWrapper(LanguageTag aLanguageTag);
>      ~IntlWrapper();
>
>      const LocaleDataWrapper*    getLocaleData() const

Change-Id: I29371b27c260c822c427dab70bcb29943e34dfc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135144
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-30 23:12:27 +02:00
Luboš Luňák
970ff17f47 fix setting cell borders for unallocated cells
First of all, it should not be clamped to allocated columns. Second,
06d3294502 incorrectly handled
unallocated columns by setting the attribute for all rows, instead
of handling the inner ones differently.

Change-Id: I3115b314971f8c152cbdeda674863a8a78ee12eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135131
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-30 21:20:54 +02:00
Luboš Luňák
3e738f53a6 first arg of ApplyFrame is never null
e4008dc0c3 did this for ApplyBlockFrame()
but didn't chagne ApplyFrame() which is only called from there.

Change-Id: I9f1dce3dc7fda23b42e90432c13dfca0aa7f267e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135130
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-30 21:20:39 +02:00
Xisco Fauli
ab1cc47d5f tdf#145178: sw: Add UItest
Change-Id: I5dbc302216b0d8b94ad29a336495856ce8cfc4b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135139
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-30 20:38:21 +02:00
Stephan Bergmann
80c5e962fd -Werror=maybe-uninitialized
> sw/source/core/text/guess.cxx: In member function ‘bool SwTextGuess::Guess(const SwTextPortion&, SwTextFormatInfo&, sal_uInt16)’:
> sw/source/core/text/guess.cxx:220:37: error: ‘bHyphenationNoLastWord’ may be used uninitialized [-Werror=maybe-uninitialized]
>   220 |         if ( bHyphenationNoLastWord && sal_Int32(m_nCutPos) > nLastWord )
>       |              ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sw/source/core/text/guess.cxx:201:14: note: ‘bHyphenationNoLastWord’ was declared here
>   201 |         bool bHyphenationNoLastWord;
>       |              ^~~~~~~~~~~~~~~~~~~~~~

since 8c018910ae "tdf#149248 sw offapi xmloff: add
option to not hyphenate last word"

Change-Id: Id3be25bf9f5d6769555bfe461a0f4e1e27e0e39e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135137
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
2022-05-30 19:47:11 +02:00
Noel Grandin
be86e93d9b these ScTokenArray can be stack allocated
Change-Id: I53d370bf6bc5133b7279e569516fc5a0a5ede1b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135135
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 19:18:02 +02:00
Noel Grandin
a57209bf4b no need to use unique_ptr for tokens in ScChartListener
since vector is a moveable type, and we always initialise this field

Change-Id: Icd598ad942dcfbdf77c7c8eef9fa0b6b7c6fe1be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135134
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 19:17:42 +02:00
Noel Grandin
353dbd9afe no need to allocate LocaleDataWrapper separately
Change-Id: Icceaf255a3a71d612b17dad41d04b1906550a7a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 19:17:23 +02:00
Noel Grandin
2e32150731 these can be stack allocated
Change-Id: Ief9a0732d50af95d679d1d6b66dec9d2e2d141df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135132
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 19:17:03 +02:00
Noel Grandin
7b87afa899 clang-tidy modernize-pass-by-value in unotools
Change-Id: Ifa67ab7198f5d3b06171869f57703acdaa959f7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135128
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 19:16:45 +02:00
Caolán McNamara
f3df14cc43 ofz#47664 OOM
Change-Id: If0d1ea55a194961fdb05ed2023bcfdaa6f933bfa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-30 17:57:01 +02:00
Caolán McNamara
9104861a41 tdf#147708 create floating menubutton on demand
and destroy when it is fully faded out. Otherwise windows runs out of
gdi handles with document with large number of page breaks

todo: rename some things in a follow up commit after this more easily
backportable commit is merged

Change-Id: Ibbe3cd00d1027ac34915c4bff73e3a330e300f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-30 17:56:45 +02:00
Miklos Vajna
99eab75edd offapi: fix util::XCacheInfo header/footer
Addresses
<https://gerrit.libreoffice.org/c/core/+/135114/2#message-6f69c01338150fe3114c2699b417fc7223154cd2>.

Change-Id: I36d48288be1456f06813befbb24e896767957eb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135126
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-05-30 16:37:36 +02:00
Noel Grandin
9b902cfa55 clang-tidy modernize-pass-by-value in sot
Change-Id: I1ff31ae1291a82630ae32185077e369bbdfd3a0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135127
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 16:12:34 +02:00
Noel Grandin
2c921f24c7 use more SfxWhichIter::GetItemState
Change-Id: Iae284fcad199684920aef0bd91ff39c407b48e0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 16:12:20 +02:00
Caolán McNamara
a685679526 cid#1504574 Resource leak
make an owner for the PropertyMapEntries

Change-Id: Ie915a8a312f2b24488566814ad67fdeef89b5941
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135123
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-30 16:00:35 +02:00
Olivier Hallot
5b676a480a Update git submodules
* Update helpcontent2 from branch 'master'
  to 76f954f62ccd344d1760970d13a84645ceb6dd5e
  - tdf#91344 help for Writer "View" menu is not updated
    
    Writer View menu Help page was already updated modulo
    one minor correction in an embedded file.
    
    Change-Id: I7eac912669a30b9d675a51b966dcf6497269f502
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135092
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-30 15:20:14 +02:00
Noel Grandin
3676fb9d7b these can be stack allocated
Change-Id: I7be63816fcdc3572d751fdd9ceab5931d0559ffc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135124
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 15:09:39 +02:00
Stephan Bergmann
f218429d0a CppunitTest_sd_filter_eppt also needs the ASan hack
...from e854abe076 "Avoid external processes
picking up instdir/program/libnspr4.so", to avoid

> Test name: (anonymous namespace)::testThemeExport::TestBody
> equality assertion failed
> - Expected: 0
> - Actual  : 32512
> - failed to execute: sh .../bin/officeotron.sh .../tmp/_anonymous_namespace___testThemeExport__TestBody_w8epm.tmp > .../tmp/_anonymous_namespace___testThemeExport__TestBody_w8epo.tmp 2>&1
> java: symbol lookup error: .../instdir/program/libnspr4.so: undefined symbol: __asan_init

Change-Id: Id6f49c08a8bcd0ad9b5600de147624d5cfc6019b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135122
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-30 14:08:36 +02:00
Attila Bakos (NISZ)
e1f6b136fd tdf#146272 sw: fix fly in fly hid by incomplete z-ordering
Fixing z-order was incomplete for textboxes
(shape + frame pair), because only the frame
moved to back, but not the shape, covering the
textbox.

Regression from commit 504d78acb8
"tdf#143574 sw: textboxes in group shapes - part 1".

See also commit 0e6d963fbc
"tdf#138141 sw: fix textbox z-order".

Change-Id: I03e3b55302c984e5968e579e77ccd5ed0a336dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134942
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-30 13:21:10 +02:00
Stephan Bergmann
bbcf26337c Avoid uninitialized temp_file_handle
...in case osl_create_temp_file_impl_ doesn't assign to it, for whatever
osl_error reason, which then apparently leads to
<https://crashreport.libreoffice.org/stats/crash_details/e47a9fbb-a6f1-4020-ade8-ab51549b727a>
SIGSEGV at (relative to libreoffice-7-1)

> 0  libuno_sal.so.3  osl_closeFile                               sal/osl/unx/file.cxx:1154
> 1  libuno_sal.so.3  osl_createTempFile                          sal/osl/unx/tempfile.cxx:330
> 2  libmergedlo.so   PackedFile::flush                           include/osl/file.hxx:310
> 3  libmergedlo.so   comphelper::BackupFileHelper::tryPush_file  comphelper/source/misc/backupfilehelper.cxx:2090
[...]

Change-Id: I2e81bbeab7daaaa3c19de4accce8a76ad24faa47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135111
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-30 12:48:28 +02:00
Tibor Nagy
c3f73f7577 tdf#149128 PPTX export: fix <stCxn> and <endCxn> connector properties
to avoid of detaching connections between shapes,
when these connections were created in Impress.

Change-Id: I1bc90bb8a408546b303b70bcfb27d3549d5e72d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134940
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-30 12:48:03 +02:00
Roman Kuznetsov
81aad6d53f tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro
Change-Id: Id91ca2d7002b3743ecaed7b40edda3f85e080884
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135061
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2022-05-30 12:24:17 +02:00
Roman Kuznetsov
d694b572c7 tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro
Change-Id: I86956ab4beaba6b2b0905123ccea76c8ffad57fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135063
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2022-05-30 12:21:52 +02:00
Miklos Vajna
b3f2ae52e3 framework: fix crash on Writer startup when using --enable-ext-wiki-publisher
As reported by Julien, once the mediawiki extension is installed, the
xHandler in framework::DispatchProvider::implts_searchProtocolHandler()
points to an UNO component implemented in Java, and we crash in
dynamic_cast<>(), at least on Linux with gcc 7.5 and libstdc++.

This dynamic_cast<>() call was added in commit
c0fa456436 (tdf#149261 sdext: fix crash on
starting the presenter console for the 2nd time, 2022-05-26), to allow
the presenter console to opt out from protocol handler caching. It was
expected that the proxy object created for a Java UNO component would
simply return nullptr when we try to dynamic_cast<>() it down to a C++
interface.

Fix the problem by moving the interface to an UNO one: this side-steps
the dynamic_cast<>() crash at the price of introducing an UNO interface,
which is not meant to be part of the public UNO API (but at least it's
not published).

It may still make sense to improve the bridges/ code at some stage to
not crash in dynamic_cast<>() on generated Java proxy objects.

Change-Id: Iaac44515339e0dc15dddc3be45ef7dee7331e47a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135114
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-05-30 12:08:03 +02:00
Vasily Melenchuk
e4e03e79fa tdf#149200: docx export: transparent color fix
If there is no color value we should not also try to write
transparency information: otherwise w:srgbClr will have no
parameter value and MS Word won't open such documents.

Change-Id: Id67f174c5ae9aadf90ae54c126aef9a43ff3ba17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134945
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-30 11:52:44 +02:00
Xisco Fauli
d471bfb112 fix another domain
Change-Id: I3a0c5aab62a7b6723df5820abb3f56e3f110d8b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135113
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-30 11:40:12 +02:00
Caolán McNamara
2896c5dad1 Related: tdf#89131 draw up/down spins disabled if value is at max/min
if there is a max/min set.

Change-Id: I2dc7ccccad9ec2aa7eb89d8b5fa137e077a846fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135105
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-30 10:17:07 +02:00