Test repository to check push and ssh key
Find a file
Szymon Kłos 70d054a3da lok: jsdialog: enable font name box after save
When we save - we block UI. In the lok we disable that for
some cases like in commit e005690e9c
lok: avoid sending jsdialog messages during background save.

But we also use save file to generate previews of shapes what happens
on eg. resize in Online. Then we trigger disable and enable cycle
for frames - and we end with FontNameBox enabled!

That was causing the JSDialog combobox still being locked - because
frame unlock was using direct VCL API, not weld:: one in the
InterimItemWindow. Let's fix that with proper StateChanged handling.

So now it is functional. But still I think there is some error in the
logic - as after save we should beg the "before save" state of control
not "always enabled". But it's different problem.

Change-Id: Ia8e5c8c864156271b5f68d482234e83eb57b0deb
(cherry picked from commit cbe229ec219e56ce1bb5dd9598f9052a98504249)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177489
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-11-29 06:47:19 +01:00
.configurations Fix typo 2024-10-11 14:01:05 +02:00
.git-hooks
.github
.vscode
accessibility a11y: Handle combobox subedit a11y name in VCLXAccessibleEdit 2024-11-26 12:04:14 +01:00
android android-viewer translated using Weblate 2024-11-27 10:54:51 +01:00
animations loplugin:ostr avmedia 2024-05-06 15:14:09 +02:00
apple_remote
avmedia consider VndSunStarExpand an exotic protocol 2024-11-19 20:20:03 +01:00
basctl Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
basegfx com::sun::star -> css 2024-11-10 10:50:15 +01:00
basic tdf#108189 inspection of object hangs LO 2024-11-14 18:02:03 +01:00
bean
bin bin: Add script to check the latest version of external libraries 2024-11-13 09:33:38 +01:00
binaryurp clang-tidy: performance-unnecessary-copy-initialization in binaryurp 2024-11-11 15:47:00 +01:00
bridges com::sun::star -> css 2024-11-10 10:50:15 +01:00
canvas canvas: simplify calcTransformedRectBounds 2024-11-19 16:14:13 +01:00
chart2 PVS: V560 A part of conditional expression is always true 2024-11-27 14:13:39 +01:00
cli_ure Simplify a bit 2024-11-08 05:34:20 +01:00
codemaker loplugin:reftotemp in codemaker..connectivity 2024-11-08 17:33:29 +01:00
comphelper comphelper: put each Crypto impl. in own file - minimize ifdefs 2024-11-28 09:50:08 +01:00
compilerplugins svx: unused return 2024-11-19 18:03:18 +01:00
config_host Fix Linux cppuhelper_detail_findSofficePath 2024-11-14 16:11:59 +01:00
configmgr drop a TODO 2024-11-27 17:16:36 +01:00
connectivity tdf#163486: PVS: Identical branches 2024-11-20 13:52:12 +01:00
cppcanvas canvas: simplify calcTransformedRectBounds 2024-11-19 16:14:13 +01:00
cppu Simplify a bit 2024-11-08 05:34:20 +01:00
cppuhelper Fix Linux cppuhelper_detail_findSofficePath 2024-11-14 16:11:59 +01:00
cpputools cid#1555171 Data race condition 2024-10-17 20:25:15 +02:00
cui tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
dbaccess weld: Rename weld::Dialog::{widget -> button}_for_response 2024-11-27 08:21:50 +01:00
desktop cool#4250 - add API to set per view options. 2024-11-28 15:09:27 +01:00
dictionaries@1ca6cb9f31 Update git submodules 2024-11-10 11:45:27 +01:00
distro-configs distro-configs/LibreOfficeFlatpak.conf lacks --without-system-java-websocket 2024-11-25 18:24:40 +01:00
docmodel
drawinglayer no longer need this svtools/drawinglayer hack 2024-11-21 14:31:49 +01:00
editeng tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
embeddedobj consider VndSunStarExpand an exotic protocol 2024-11-19 20:20:03 +01:00
embedserv
emfio Improve loplugin:dyncastvisibility to check for non-inline key functions 2024-11-14 12:49:22 +01:00
eventattacher Simplify a bit 2024-11-08 05:34:20 +01:00
extensions Spelling mistake in code 2024-11-23 13:17:13 +01:00
external tsan: use of freed mutex 2024-11-27 09:57:07 +01:00
extras for --without-templates still generate the template/common/presnt dir 2024-11-27 12:33:43 +01:00
filter tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
forms Let ESelection use EPaM for simplification 2024-11-24 08:12:55 +01:00
formula loplugin:reftotemp in drawinglayer..framework 2024-11-11 18:28:57 +01:00
fpicker clang-tidy: performance-unnecessary-copy-initialization in fpicker 2024-11-11 21:02:38 +01:00
framework cid#1607688 Check of thread-shared field evades lock acquisition 2024-11-27 21:45:21 +01:00
helpcompiler loplugin:reftotemp in helpcompiler..i18npool 2024-11-11 18:29:07 +01:00
helpcontent2@aa5fa6c008 Update git submodules 2024-11-29 00:49:02 +01:00
hwpfilter tdf#152299 - Remove unused define(s) from C/C++ files 2024-11-23 15:18:31 +01:00
i18nlangtag Related: tdf#163903 Add French (Republic of Guinea) {fr-GN} [0x940C] 2024-11-18 22:45:45 +01:00
i18npool Resolves: tdf#163903 Add French (Republic of Guinea) {fr-GN} locale data 2024-11-18 22:45:54 +01:00
i18nutil tdf#163486: PVS: Identical branches 2024-11-01 01:20:27 +01:00
icon-themes Resolves tdf148513 - Illustration for line break options 2024-10-24 10:04:17 +02:00
idl
idlc/test/parser
include tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
instsetoo_native Adapt to generation of .worker.js files gone from 3.1.68 2024-10-30 13:51:40 +01:00
io cid#1556875 COPY_INSTEAD_OF_MOVE 2024-10-26 21:54:56 +02:00
ios
javaunohelper
jurt
jvmaccess
jvmfwk clang-tidy: performance-unnecessary-copy-initialization in various 2024-11-11 21:02:55 +01:00
l10ntools add Tagalog (tl) langauge- & helppack 2024-10-23 18:22:36 +02:00
librelogo
libreofficekit PVS: V547 Expression 'aUnoArgs.empty()' is always false 2024-11-22 13:09:16 +01:00
lingucomponent Avoid assigning unused value 2024-11-25 05:33:01 +01:00
linguistic clang-tidy: performance-unnecessary-copy-initialization in various 2024-11-11 21:02:55 +01:00
lotuswordpro clang-tidy: performance-unnecessary-copy-initialization in various 2024-11-11 21:02:55 +01:00
m4
msicreator comphelper, msicreator, odk: fix issues found by Ruff linter 2024-07-27 15:42:26 +02:00
net_ure .NET Bindings: Native bridge for .NET 2024-09-18 08:10:36 +02:00
nlpsolver
o3tl Use good old string literals in assertXPath and friends 2024-10-05 10:06:44 +02:00
odk Parameterize lower case PRODUCTNAME in odk/config/setsdkenv_windows.bat 2024-11-13 23:04:53 +01:00
offapi tdf#36709 sw: Writer layout for font-relative first-line indent 2024-11-13 09:35:20 +01:00
officecfg Resolves tdf#126857 - Center object on page/slide 2024-11-26 18:19:32 +01:00
oovbaapi
oox tdf#161800 - I/O of '# of values in second plot' parameter not supported 2024-11-26 01:34:07 +01:00
opencl workaround segfault in compiler on macos-clang-intel 2024-07-25 15:03:36 +02:00
osx Remove archaic xmerge 2024-10-24 16:28:18 +02:00
package loplugin:unusedmethods 2024-11-22 20:03:48 +01:00
pch
postprocess show extension link on startcenter for macosxsandbox case 2024-11-26 18:05:02 +01:00
pyuno tdf#163486: PVS: variable was assigned the same value 2024-11-13 20:12:29 +01:00
qadevOOo cid#1557158 Unguarded read 2024-09-17 13:23:25 +02:00
readlicense_oo Some missing readme PRODUCTNAME parametrization 2024-11-13 08:03:53 +01:00
registry cid#1606852 silence Overflowed constant 2024-11-24 15:14:37 +01:00
remotebridges
reportbuilder
reportdesign tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
ridljar
sal tdf#152943: Add configure option to disable NaN payload related tests 2024-11-27 20:06:40 +01:00
salhelper
sax tdf#36709 sw: Writer layout for font-relative first-line indent 2024-11-13 09:35:20 +01:00
sc sc a11y: Make 2 members non-mutable 2024-11-28 23:11:22 +01:00
scaddins Some simplification 2024-11-26 05:47:32 +01:00
sccomp Fix typo 2024-10-09 22:41:42 +02:00
schema tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
scp2 add Santali (Ol-Chiki) languagepack (sat-Olck) 2024-11-22 19:08:52 +01:00
scripting loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
sd tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
sdext PVS: V560 A part of conditional expression is always true: bSuccess 2024-11-27 14:02:00 +01:00
setup_native
sfx2 PVS: V547 Expression '!bFoundCert' is always true 2024-11-27 17:37:06 +01:00
shell tdf#158237 Use C++20 contains() instead of find() and end() 2024-11-23 14:47:02 +01:00
slideshow slideshow: fix initVisible value 2024-11-25 10:36:31 +01:00
smoketest
solenv add Santali (Ol-Chiki) languagepack (sat-Olck) 2024-11-22 19:08:52 +01:00
soltools
sot loplugin:reftotemp in sot..svl 2024-11-12 16:06:24 +01:00
starmath starmath: fix deref nullptr 2024-11-27 08:49:11 +01:00
static Simplify a bit 2024-11-08 05:34:20 +01:00
stoc loplugin:reftotemp in sot..svl 2024-11-12 16:06:24 +01:00
store drop a static 2024-11-10 15:19:38 +01:00
svgio Simplify a bit 2024-11-05 06:36:16 +01:00
svl PVS: V612 An unconditional 'return' within a loop 2024-11-28 09:29:05 +01:00
svtools svtools a11y: Merge BrowseBoxImpl into BrowseBox 2024-11-26 17:49:13 +01:00
svx lok: jsdialog: enable font name box after save 2024-11-29 06:47:19 +01:00
sw tdf#146553 Enable additonal functions in editable section while in r/o mode 2024-11-29 01:15:51 +01:00
swext
sysui Adapt to RPM 4.20 2024-09-22 22:26:18 +02:00
test loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
testtools Simplify a bit 2024-11-08 05:34:20 +01:00
toolkit tdf#39468 translate German comments in ipwin.cxx 2024-11-27 11:14:58 +01:00
tools cid#1607163 silence Overflowed return value 2024-11-24 15:14:59 +01:00
translations@096ea21136 Update git submodules 2024-11-22 17:48:14 +01:00
ucb PVS: V547 Expression '!bNeedAction' is always false. 2024-11-27 20:17:32 +01:00
ucbhelper loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
udkapi
uitest Document LIBO_TEST_DEFAULT_DESKTOP environment variable 2024-10-21 10:48:29 +02:00
UnoControls XTopWindowListener is unused here 2024-11-09 19:33:09 +01:00
unodevtools cid#1607989 Overflowed constant 2024-09-23 09:32:54 +02:00
unoidl cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
unoil
unotest no need to take a copy of the getProcessComponentContext return value 2024-11-08 15:23:52 +01:00
unotools Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
unoxml loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
ure
uui tdf#130857 uui: Drop empty GtkSizeGroup from password.ui 2024-11-19 07:53:18 +01:00
vbahelper Turn SC_MOD macro to a function 2024-11-24 07:43:02 +01:00
vcl tdf#163913 Implement font-relative margins 2024-11-28 22:10:05 +01:00
winaccessibility com::sun::star -> css 2024-11-10 10:50:15 +01:00
wizards tdf#144702 Base Fields in Report Label Display Clipped 2024-10-23 07:47:34 +02:00
writerperfect loplugin:reftotemp in writerperfect 2024-11-13 06:35:08 +01:00
xmlhelp clang-tidy: performance-unnecessary-copy-initialization in xmloff 2024-11-12 11:15:26 +01:00
xmloff tdf#158237 Use C++20 contains() instead of find() and end() 2024-11-29 01:37:10 +01:00
xmlreader
xmlscript no need to take a copy of the getProcessComponentContext return value 2024-11-08 15:23:52 +01:00
xmlsecurity Operator should be logical AND instead of OR 2024-11-26 16:26:26 +01:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
.vsconfig winget configuration files for installing Visual Studio Community 2022 2024-10-10 23:49:19 +02:00
antivirusDetection.vbs
autogen.sh wsl-as-helper: fix paths to module/Makefile in builddir!=srcdir case 2024-10-14 19:48:15 +02:00
BUCK
config.guess
config.sub
config_host.mk.in tdf#152943: Add configure option to disable NaN payload related tests 2024-11-27 20:06:40 +01:00
config_host_lang.mk.in don't export the various language lists and consolidate them 2022-12-15 21:07:37 +00:00
configure.ac tdf#152943: Add configure option to disable NaN payload related tests 2024-11-27 20:06:40 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint sw: drop DECLARE_FODFEXPORT_TEST macro 2024-10-16 15:28:13 +02:00
download.lst openldap: upgrade to 2.6.9 2024-11-27 12:47:44 +01:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch Bundle fonts of Google's DocRepair Project 2024-07-05 15:37:11 +02:00
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md README: mention PVS-Studio 2024-10-18 14:31:08 +02:00
README.Solaris remove use of Archive::Zip 2016-06-04 08:09:56 +02:00
Repository.mk for --without-templates still generate the template/common/presnt dir 2024-11-27 12:33:43 +01:00
RepositoryExternal.mk don't need to use dlsym for cairo_surface_set_device_scale... 2024-10-17 17:49:07 +02:00
RepositoryFixes.mk Emscripten: For executables, only build .js files, not .html files 2024-10-10 10:21:42 +02:00
RepositoryModule_build.mk
RepositoryModule_host.mk Remove archaic xmerge 2024-10-24 16:28:18 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER Make it clear that the text is in addition to the previous 2021-01-27 08:02:35 +01:00
tsan-suppress.txt update tsan suppressions 2024-07-11 13:04:30 +02:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.

SAST Tools

PVS-Studio - static analyzer for C, C++, C#, and Java code.