Per the RFC, the server must set the 'Connection'
header to 'close' to signify that the current
request is the last.
With this patch, we now properly notify all the
clients when we do not intend on resuming communication.
Although, technically, there is no reason why we
shouldn't allow the client to reuse the connection,
we may consider that in the future.
See https://tools.ietf.org/html/rfc7230#section-6.3
Change-Id: Ic6250c0afe8124314a9122452040f6a75728a525
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
According to the RFC, HTTP/1.1 assumes persistent
connection unless the client or server sends
'Connection: close' header. See
https://tools.ietf.org/html/rfc7230#section-6.3
Now we fully support disconnecting when we
get this header, which is important for when
reusing the same http::Session (we need to
reconnect in such a case).
Change-Id: Ib278eff21be32c1414478296e90e2e807ab24132
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Since the return value of syncRequest and syncDownload
was derived from Response anyway, there is no reason
to have multiple values for callers to look at.
This simplifies the API.
Change-Id: I0f136e515dd0ef6eda84f6a7cd662b260809d2f1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Fix some issues it found and disable the following checks for now. Some
of them needs module support to work and some of them needs project
compilation using tsc rather than per file compilation.
cypress_test/ extends loleaflet's eslintrc so, its package.json needs to
have the typescript lint plugin as well.
Disabled checks:
@typescript-eslint/no-unused-vars // This can be enabled after fixing
all places it finds.
@typescript-eslint/no-inferrable-types // Lets do explicit typing
whenever we can.
no-var // This needs a lot of conversion of var to let.
@typescript-eslint/no-explicit-any
@typescript-eslint/no-namespace // ES5 has no module support
no-inner-declarations // ,,
no-constant-condition // This is sometimes useful
@typescript-eslint/triple-slash-reference // ES5 no module support.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ib4fd8b4fcee42216d4322fd043a1873302db375a
A black tile pixel is 0xff000000 (alpha channel must be 255) should not
be confused with empty Calc tile pixels whose alpha is 0. This is true
since we disabled grid+background painting in core and do it in client
canvas.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I94eac4748f28a4d9a01c4a3b73b71f2ce7efc5ea
Ensure grid lines drawn for specified area confines to that.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I9b294db3e9cdf4721717b695aead35bce5333c08
./test/helpers.hpp:211:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]
Perhaps it could go further and even call LOK_ASSERT_FAIL().
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I4f68f6d290bcb0a832ea71153d5f699d5366def9
use window instead of document.
now it works also in chrome.
always show curos on add.
Change-Id: Id58b8810fb6a8d5ba00369308cce1dd201b7340a
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
When Points were created with floating point numbers
the overlay wasn't shown on the right side of the chart.
Change-Id: I069927c5e6a97a7155878bdd8f4645b11dbe8493
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
- Fix positions and backgrounds
- Draw: no need to hide presentation controls anymore (was affecting position)
- Make sure scroll bar is not getting different styles from browser thus affecting position
- happening on FF
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I479cf7d01023ffc611a3cfa6a5fb90fb0dbda1d7
Currently translated at 6.9% (26 of 372 strings)
Translated using Weblate (Malayalam)
Currently translated at 40.0% (2 of 5 strings)
Co-authored-by: Ron Stephen Mathew <ronstephenmathew@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/code-welcome-text/ml/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ml/
Translation: Collabora Online/CODE welcome text
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I086eb775b52118a37a426e1300bc46108062add9
Currently translated at 100.0% (18 of 18 strings)
Translated using Weblate (Basque)
Currently translated at 100.0% (420 of 420 strings)
Translated using Weblate (Basque)
Currently translated at 77.7% (14 of 18 strings)
Translated using Weblate (Basque)
Currently translated at 100.0% (371 of 371 strings)
Co-authored-by: Gontzal Manuel Pujana Onaindia <thadahdenyse@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/eu/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/eu/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/eu/
Translation: Collabora Online/Android lib
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I03404b92f62f11b8bbbc6d549a3370873a5461bb
