There are costs to many threads, and diminishing returns.
Change-Id: I4d4dc0491c48af303375d09d8eb19ffebedcad83
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
fixes wrong value from
Mobile: calc: formulabar element: align to top on expanded
8b378e99653064348fccffd029c66aa378aa8da5
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8b5706957dff007137e3aa1ce677b825ada3e261
In some browsers addressinput was misaligned (no initial margin)
- Remove FF specific margin-left
- Add non LTR specific margin to every browser
- Use the same dimension (8px) as used in the .formulabar.toolbox's
grid-column-gap
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a2e86a9a56f05bbf514d12a080fbcb2408cb816
- Make sure all elements within formulabar toolbox fit even
on smaller devices
- Do not user margins to position, use instead grid
- Remove Equal sign (startformula). Before this commit the
startformula icon was visible and then invisible once the user
enter the cell to type -> it seems this was initially intended to save
space but the truth of the matter is that it causes a flicker and
where the position of the elements shift making even harder to write
on mobile.
- Solution: do not create that element in the first place on
mobile. Plus when the user enter the cell can always press the "="
right via the native keyboard anyhow.
note: avoid multiple instances of the same condition in FormulaBarJSDialog
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic4f3b7fddb9d862170a0e95243f4b19a89340575
Before this commit:
- Images (coming from link preview) could brake html parent element
- Metadata (p element) could brake html parent element
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I362afe9eadd86b88dc6afc584f635d50fac0ad03
The setModified is on an internal, AdminModel
specific, Document object. It is not the
DocumentBroker.
This reverts commit e33d6aa2ca.
Change-Id: Ib706927051678cfc19dc1246d679ef530eb8d586
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We prevent using uno commands multiple times to open the same
dialog - let's do this also for dispatch() which executes
commands used in Online, eg. for custom dialogs like Add Citation.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia022ac4c1b7223c630f3d83eb9b3ce2f1a2e2e1a
We had this for tunneled dialogs but also for jsdialog it
should be done. When trying to execute uno command when any
dialog is opened - blink dialog to indicate that user has to
close it to open next one. This blocks possibility to open
multiple instances of the same dialog.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1777ce23292799edc3bbb896bf63872a354d7ad7
avoid an allocation and some pointer chasing
Signed-off-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I29711075d4bf840c2ef992341a6dadeeb87c6edd
this prevents from creating additional containers for
text views with multiple child nodes
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id65fbe805c58e30ffa5ff86e3fdfaab5dc3a0153
in labels(classes):
- .no-color-control-label
- .auto-color-control-label
the value of padding-left property is
increased from 4px to 8px.
Signed-off-by: Bayram Çiçek <bayram.cicek@libreoffice.org>
Change-Id: Ide0b810cab18d63748678e3007b8ee8c7234114e
Add an empty callback for the busypopup window.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I84ed797feed93cfad6a66f1a4981ecacce23f104
Passing non-ASCII, UTF-8 text from native to JavaScript works
fine, but images become corrupted if any non-ASCII bytes are
not escaped.
The Socket._extractTextImg() JavaScript function assumes that,
in the iOS app, the first newline separates text from image data
so assume all bytes after the first new line are image data.
Signed-off-by: Patrick Luby <patrick.luby@collabora.com>
Change-Id: I06f4377bb3b7002a76041a198076decfee9e3733
This is a near duplicate of pull request #5898
Signed-off-by: Patrick Luby <patrick.luby@collabora.com>
Change-Id: Ib05a285f3642ec0ca745b0c74157190fda5bd3ed