This is needed because we have to separate the init. for both
encryption methods and we have to init both when the password is
entered. Currently we only prepared this, to make this possible
when we introduce the other encryption method.
Change-Id: Id6556ddc6a6218164a93bb689f03d6ec6dbad8b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176454
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177873
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Rename weld::TreeView member + methods to clarify
that these are about selection changes:
* m_aChangeHdl to m_aSelectionChangedHdl,
* signal_changed to signal_selection_changed
* connect_changed to connect_selection_changed
In GtkInstanceTreeview, also rename the
related methods calling signal_selection_changed
accordingly for consistency.
Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
its an out only param, not in-out
Change-Id: I4e969bf06bed41a7e04497880f8ea51a3f784feb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177612
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
DocBookTemplate.ott
Simply copy makefile of extra/templates
fix bug tdf#161930: mimetype is zipped only once
Modifications to DocBookTemplate.stw:
- change fonts to bundled fonts: Liberation Serif, Noto Sans CJK, Noto Sans Devanagari
(not so useful as used fonts are defined in
docbooktosoffheadings.xsl and sofftodocbookheadings.xsl)
- remove language and country tags
- remove page size
- remove writing mode tags
- remove content.xml
- remove meta.xml
- simplify settings.xml
- remove unused namespaces
Change-Id: Ic2a2284c3d890b8a6b7b4e29bdab18c33d40dcee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174847
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
adding two A11y issue level: Error and warning level, and
categorizing our accesibility issues based on how the
PAC 2024 tools and WCAG behave with the different warnings/errors.
Change-Id: If4e4800497340318bb990326c64de655f24a47e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177389
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
This change adds loext:margin-left and loext:margin-right, which
implement margins that support font-relative units.
See tdf#36709 for additional details.
Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
And drop EPosition, which duplicates EPaM, except for its default
ctor (used in a single place).
Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Previously, the direction attribute was not set on text tags when
exporting RTL text to SVG. This change adds the missing attribute.
Change-Id: I57770c1cc44f10c3c43ccac2f5a17c1422c34d35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176869
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
This change extends layout for font-relative paragraph first-line
indentation into Edit Engine.
Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Text frames anchored as characters, containing inline
headings were exported without display:inline using
the XSLT XHTML filter (see File->Export As), resulting
separated paragraphs for inline headings.
Note: both div and heading elements need display:inline.
This reverts commit d2e8705c9c
"tdf#153839: add newline after certain tags" partially
(and conditionally), because fancy printing is bad here:
the new line between the div element was converted to a space
at display:inline, resulting double space with the original
space between the inline heading and the other text content
of the following part of the paragraph line.
Follow-up to commit 7a35f3dc74
"tdf#48459 sw inline heading: apply it on the selected words",
commit d87cf67f8f
"tdf#131728 sw inline heading: fix missing/broken DOCX export"
and commit a1dcbd1d1c
"tdf48459 sw inline heading: add Inline Heading frame style".
Change-Id: I6623066354a70a69faf14cd30fc2b917c9ec9c90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176511
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
we can just take a "const &".
(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)
Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Added PDF 2.0 and PDF/A-4 version to enums. Write the PDF 2.0
support for the file headers. Add the identical considitons as
for the PDF/A-4 as they were for PDF/A-3.
Change-Id: Iccf5afbf09c4cd0cd1ae7122c860e8cbefe3a6fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176023
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
Just a simplification and clean-up as this is easier to read.
Change-Id: I8a920849d2bac7ae89d0d7b5f90421a7fac3a0c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176021
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 91, 94
Change-Id: Ie7c803398eb1ce016a2f7a2a71b5d1a283266cc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175237
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Since image/pdf compression does not always reduce image
or pdf resolution, change the misleading label from
"reduce" to "change" wherever possible.
Keep identifiers having "reduce" in their name as is
as of now, only change the string values containing
"reduce" to "change".
Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
It controlled how the FilterConfigCache initialized, and also how
the unused aFilterPath was initialized. The FilterConfigCache is
reused, when there are other instances of GraphicFilter - so that
means, that the "bUseConfig" flag doesn't necessarily mean that
the initialization will happen as intended: the existing instance
could have been initialized using the other value.
Avoid this indeterministic behavior, and always use the config,
except in fuzzing. The VCL tests, that could possibly once depend
on that, now use config, so this is not an issue - and that means
testing the same thing as used in the working code, not something
different.
Change-Id: I6555dc47328b362e020138cf454f5ede7f39d063
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175894
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
which allows us to eliminate a bunch of rounding at various layers, and
consequently maintain a lot more precision
Change-Id: I911dedd7c041c1d67396c082e5695346ea689acb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175814
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
V1037 Two or more case-branches perform the same actions. Check lines: 702, 710
Change-Id: I7a36383e2d5f19d5dbf0f8bb8d0b6a0c7880eaee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175342
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
Interactive signing via the .uno:Signature command parameters were
possible, but headless PDF export had no similar parameters.
The primary difference is that the interactive signing works with the
sign certificate of the SfxViewShell, while PDF export has its own
vcl::PDFWriter::PDFWriterContext::SignCertificate.
Fix the problem similar to what commit
80723fccbb (filter: allow PDF export to
sign from the cmdline, 2022-02-03) did, but here we don't refer to an
already configured sign certificate by name, we take the sign cert/key
from parameters instead.
Test this in the NSS case where it's known to work, ignore the mscng
signing case for now.
Change-Id: Ib0c171736d2554fb3678ae4b8842541c43f9f3dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175644
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Since
commit f1ec5dcfca
Author: Rohit Deshmukh <rohit.deshmukh@synerzip.com>
Date: Mon Jan 6 11:26:46 2014 +0530
fdo#69616: Fix for VML part missing for group.
V766 An item with the same key 'u"ooxml-rect"' has already been added.
Change-Id: Iaf14b61d596102c18033a763f8a357d242760f69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175325
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
This ctor is meant to set the value of nTime directly; and that value
is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK.
But in some places, this ctor was misused for setting of nanoseconds,
which would only accidentally work for values less than one second.
All places that initialized tools::Time with 0, now use EMPTY.
This makes the ctor private; and for the very few cases where really
the encoded value of nTime is stored / restored, fromEncodedTime is
introduced.
Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
V668 There is no sense in testing the 'pCommentAction' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: I3fa6619f80edefd852693190ebf463f694c8b55c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175108
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
When using the Signing tab on the "Export as PDF" dialog, the TSA URLs will be
appended to the ComboBox each time a certificate is selected. Thus, if a user
selects a certificate and then another (or the same) is selected the ComboBox
will end up with duplicated values.
This patch moves the code to append the TSA URLs to the function that sets up
the signing page, fixing the problem.
Change-Id: I93d9cb61e10f18b0c33765d63a5ce47c92e588bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174424
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Since commit 872dba61a1 (INTEGRATION:
CWS xmlfilter01 (1.1.2.3.2.1.16); FILE MERGED, 2003-04-04),
XMLFilterDetect service uses Clipboardformat field in filterdetect.
Thus, it detects any file starting with "<?xml" and having string
"pwi" as "writer_PocketWord_File", because writer_PocketWord_File.xcu
has the text "doctype:pwi" as the value of its ClipboardFormat.
The problem is: since commit 1e6e891016
(restore PocketWord filter, this time backed by libwps, 2020-09-27),
this format is not handled by XMLFilterDetect service. So the filter
mis-detects some else filter's data, which then isn't accepted there.
This change makes the code of FilterDetect::detect to make sure that
it only processes its own data, checking DetectService property, too.
I didn't remove the ClipboardFormat property value from the mentioned
XCU, because (1) I don't know if it may be used by other code; and
(2) because it allows to have the sensible unit test.
Change-Id: I02fafe8df10f64640305d45cf1461b0a37552630
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174607
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
These are only sent to an external API expecting char*-like strings,
or for comparison. Having every assertXPath having three of _[ou]str
is too much syntactic noise, making the unit tests almost unreadable.
Change-Id: Ic004a36ea75e7bfe0b96f405c40f926a957b51cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174416
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
drop mutex, only allowed to be called from ctor
Change-Id: I1878cf368caacafdcee96a7112a6cc768ce87520
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174207
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
