Test repository to check push and ssh key
Find a file
Mike Kaganski 3d236177be Deduplicate O(U)StringConcatenation
And use an overloaded helper function with a better (?) unified name
to show that the result is not an O(U)String.

Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-11 12:46:01 +02:00
.git-hooks replace egrep/fgrep calls with grep -E/grep -F 2022-09-08 14:43:53 +02:00
.github rdm#3572 update github-repo lockdown 2022-05-10 10:24:33 +02:00
.vscode Fix typos 2022-03-13 19:17:37 +01:00
accessibility use more string_view in accessibility..configmgr 2022-09-27 13:31:20 +02:00
android replace egrep/fgrep calls with grep -E/grep -F 2022-09-08 14:43:53 +02:00
animations Animations : no need to use the global mutex here 2022-07-17 19:29:22 +02:00
apple_remote
avmedia unique_ptr->optional for Graphic 2022-09-10 12:19:13 +02:00
basctl use more string_view in accessibility..configmgr 2022-09-27 13:31:20 +02:00
basegfx basegfx: remove global ImplB2DPolyPolygon 2022-09-21 17:06:05 +02:00
basic use more string_view in accessibility..configmgr 2022-09-27 13:31:20 +02:00
bean
bin Drop unused gen-iwyu-dummy-lib.awk script 2022-09-30 08:15:04 +02:00
binaryurp cid#1500596 silence Resource leak 2022-08-27 13:13:29 +02:00
bridges Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
canvas basegfx: replace typedef with a class B2DSize based on Size2D 2022-09-11 17:16:59 +02:00
chart2 Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
cli_ure Drop obsolete preprocessor directives from UNOIDL files 2022-06-13 16:27:45 +02:00
codemaker Drop obsolete preprocessor directives from UNOIDL files 2022-06-13 16:27:45 +02:00
comphelper vcl: AnimationBitmap -> AnimationFrame 2022-09-16 10:08:43 +02:00
compilerplugins Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
config_host Revert "Use libo_CHECK_SYSTEM_MODULE for eot" 2022-10-01 14:21:28 +02:00
configmgr Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
connectivity Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
cppcanvas basegfx: replace typedef with a class B2DSize based on Size2D 2022-09-11 17:16:59 +02:00
cppu Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
cppuhelper Drop obsolete preprocessor directives from UNOIDL files 2022-06-13 16:27:45 +02:00
cpputools clang-tidy modernize-pass-by-value in various 2022-08-13 19:11:49 +02:00
cui Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
dbaccess Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
desktop Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
dictionaries@0416c229fe Update git submodules 2022-10-05 09:14:13 +02:00
distro-configs explicitly build for x86_64 in jenkins' mac-tinderbox configs 2022-08-20 01:22:37 +02:00
drawinglayer tdf#151104 correct missing ColorModification 2022-09-26 09:49:20 +02:00
editeng Check acor_langtag for language-script fallback instead of only language 2022-10-04 19:15:45 +02:00
embeddedobj split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
embedserv tdf#143148 embedserv: Use pragma once instead of include guards 2022-07-10 14:25:57 +02:00
emfio Rework of SoftEdgePrimitive2D 2022-09-08 13:33:58 +02:00
eventattacher clang-tidy modernize-pass-by-value in various 2022-08-13 19:11:49 +02:00
extensions tdf#126917 menu: OpenXMLFilterSettings != Macros 2022-10-05 06:59:36 +02:00
external Adapt external/pdfium/gcc-c++20-comparison.patch to P2468R2 2022-10-10 15:00:02 +02:00
extras tdf#139962 make shellnew files 0-bytes 2022-09-25 16:21:15 +02:00
filter tdf#148806 doc vba: only autoOpen PUBLIC macros 2022-10-11 03:08:13 +02:00
forms tdf#122319 - Don't allow nullable form components if input is required 2022-10-05 15:31:51 +02:00
formula use more string_view in formula 2022-09-28 11:28:53 +02:00
fpicker use more string_view in svtools 2022-09-21 14:21:28 +02:00
framework Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
helpcompiler loplugin:moveit 2022-06-24 08:22:44 +02:00
helpcontent2@91c56d4860 Update git submodules 2022-10-11 12:08:21 +02:00
hwpfilter split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
i18nlangtag Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
i18npool Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
i18nutil Introduce unicode::getScriptClassFromLanguageTag() 2022-10-05 12:05:01 +02:00
icon-themes tdf#151071 Revise Sifr (Impress display view, slide layout & transition) 2022-10-11 04:09:44 +02:00
idl clang-tidy modernize-pass-by-value in idl/idlc 2022-05-18 18:18:14 +02:00
idlc/test/parser Use idlc/test/parser/conversion.tests in CustomTarget_unoidl/unoidl-write_test 2022-06-11 09:58:17 +02:00
include Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
instsetoo_native windows packaging: remove unused msp creation 2022-08-18 16:07:43 +02:00
io no need to allocate MemRingBuffer separately in OMarkableOutputStream 2022-09-11 21:47:48 +02:00
ios
javaunohelper clang-tidy modernize-pass-by-value in io..jvmfwk 2022-06-21 12:59:41 +02:00
jurt
jvmaccess clang-tidy modernize-pass-by-value in jvmaccess 2022-05-23 11:46:13 +02:00
jvmfwk Fix a misuse of two-argument std string_view rfind 2022-09-23 15:52:21 +02:00
l10ntools Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
librelogo LibreLogo: fix ast, gug, hsb and sid language support 2022-09-30 14:28:44 +02:00
libreofficekit apply ui-rules 2022-09-07 15:56:05 +02:00
lingucomponent Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
linguistic Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
lotuswordpro ofz#51149 avoid Timeout 2022-09-09 13:40:46 +02:00
m4 configure: default to --with-system-nss on Linux 2022-04-29 20:24:58 +02:00
nlpsolver Related tdf#137145 tdf#137569 Capitalization + punctuation fixes 2022-07-05 18:18:46 +02:00
o3tl remove the o3tl::lru_map "unlimited" hack 2022-05-03 06:54:54 +02:00
odk cid#1500416 Resource leak 2022-09-15 15:30:35 +02:00
offapi tdf#148806 doc vba: highest priority is ThisDocument AutoOpen 2022-10-08 16:14:05 +02:00
officecfg [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
onlineupdate
oovbaapi VBA Add conversion methods to global 2022-08-06 14:16:50 +02:00
oox Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
opencl clang-tidy modernize-pass-by-value in various 2022-08-13 19:11:49 +02:00
osx Add all vcl subdirs to soffice.xcodeproj 2022-09-01 11:51:38 +02:00
package split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
pch
postprocess windows signing: use sha256 (instead of the default sha1) 2022-08-03 11:05:40 +02:00
pyuno tdf#150982: properly unquote (URL-decode) vnd.sun.star.expand payload 2022-09-16 12:55:06 +02:00
qadevOOo cid#1509284 DMI: Dubious method invocation 2022-09-06 16:28:30 +02:00
readlicense_oo update credits 2022-10-05 19:40:31 +02:00
registry cid#1500700 silence Resource leak 2022-08-22 13:12:49 +02:00
remotebridges
reportbuilder Fix typos 2022-08-12 13:24:49 +02:00
reportdesign tdf#151260, tdf#84930: Use static_assert to check contiguous item ids 2022-10-10 17:41:55 +02:00
ridljar warning: empty <p> tag 2022-08-13 00:35:17 +02:00
sal Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
salhelper
sax avoid some ref-counting in a hot path 2022-09-28 11:03:09 +02:00
sc Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
scaddins Resolves: tdf#151165 Function Wizard: ISODD()/ISEVEN() truncate to integer 2022-09-25 17:39:53 +02:00
sccomp remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
schema sw content controls, combo box: add ODT filter 2022-09-22 09:34:38 +02:00
scp2 tdf#132576 Remove unused template categories 2022-10-01 18:27:56 +02:00
scripting tdf#151076 Create callable Python script using InsertText 2022-10-07 15:13:27 +02:00
sd Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
sdext Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
setup_native tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro 2022-09-07 22:18:04 +02:00
sfx2 Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
shell Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
slideshow cid#1515521 Dereference before null check 2022-09-21 13:29:12 +02:00
smoketest clang-tidy modernize-pass-by-value in various 2022-08-13 19:11:49 +02:00
solenv Revert "android: add Grammar Checker component to native-code.py" 2022-10-06 11:55:05 +02:00
soltools Revert "Better use size_t for malloc_size" 2022-06-03 15:09:09 +02:00
sot split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
starmath tdf#126917 menu: OpenXMLFilterSettings != Macros 2022-10-05 06:59:36 +02:00
static tdf#151197: Remove EmojiControl 2022-09-29 14:39:17 +02:00
stoc Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
store clang-tidy modernize-pass-by-value in various 2022-08-13 19:11:49 +02:00
svgio use more string_view in svgio 2022-09-28 16:04:46 +02:00
svl Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
svtools Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
svx Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
sw Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
swext
sysui Related tdf#132398 - Remove Hicolor Assets for Future Revamping 2022-09-26 17:04:42 +02:00
test [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
testtools clang-tidy modernize-pass-by-value in various 2022-08-13 19:11:49 +02:00
toolkit tdf#150786 use a 'standard' theme for form controls 2022-10-04 21:17:46 +02:00
tools ofz#52191 Integer-overflow 2022-10-07 15:49:16 +02:00
translations@a06c7f55db Update git submodules 2022-10-10 14:43:38 +02:00
ucb Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
ucbhelper ucb: remove unnecessary comments 2022-09-12 18:49:28 +02:00
udkapi Replace dead langtag.net reference link with Wikipedia and W3C 2022-09-27 22:57:14 +02:00
uitest Use Markdown instead of reStructuredText 2022-09-26 00:26:05 +02:00
UnoControls Recheck modules [uU]* with IWYU 2022-04-12 15:20:47 +02:00
unodevtools use more string_view in unodevtools 2022-04-28 11:45:30 +02:00
unoidl Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
unoil
unotest Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
unotools [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
unoxml libxml2: upgrade to release 2.10.2 2022-09-14 21:35:59 +02:00
ure Drop obsolete preprocessor directives from UNOIDL files 2022-06-13 16:27:45 +02:00
uui move ErrCode to comphelper and improve debug output string 2022-09-14 08:34:38 +02:00
vbahelper tdf#148806 doc vba: only autoOpen PUBLIC macros 2022-10-11 03:08:13 +02:00
vcl Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
winaccessibility tdf#117173 wina11y: Send EVENT_SYSTEM_ALERT when notification shows 2022-09-26 16:15:06 +02:00
wizards ofz#1509303 DCN: Don't Catch NullPointer Exception 2022-09-12 20:43:47 +02:00
writerfilter Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
writerperfect Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
xmerge cid#1509209 DCN: Don't Catch NullPointer Exception 2022-09-15 15:29:57 +02:00
xmlhelp Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxx 2022-08-18 17:10:19 +02:00
xmloff split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
xmlreader clang-tidy modernize-pass-by-value in xmlreader 2022-07-29 13:10:15 +02:00
xmlscript split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
xmlsecurity Deduplicate O(U)StringConcatenation 2022-10-11 12:46:01 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs tdf#123936 Add formatting commit to .git-blame-ignore-revs 2022-07-04 09:09:50 +02:00
.gitattributes SVG is a textual XML format after all 2022-06-24 16:36:36 +02:00
.gitignore Add generated lo.xcent to .gitignore 2022-07-01 23:12:02 +02:00
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in Revert "Use libo_CHECK_SYSTEM_MODULE for eot" 2022-10-01 14:21:28 +02:00
config_host_lang.mk.in
configure.ac Allow building libeot on any platform 2022-10-01 18:14:30 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint Add a VisualStudio cpp.hint file 2022-08-22 16:01:16 +02:00
download.lst tdf#144348: Remove EmojiOne Color font 2022-09-27 11:30:44 +02:00
g g: we are not, in fact, in the BUILDDIR 2022-05-31 10:29:45 +02:00
hardened_runtime.xcent.in
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
lo.xcent.in allow to specify a macOS provisioning profile 2022-06-29 17:06:35 +02:00
logerrit
Makefile.fetch tdf#144348: Remove EmojiOne Color font 2022-09-27 11:30:44 +02:00
Makefile.gbuild
Makefile.in [COVER] add first set of ODF feature test files 2022-09-11 21:32:07 +02:00
README.cross
README.help.md Fix typo 2022-07-30 23:26:39 +02:00
README.md Bump minimum macOS to 10.14 2022-06-15 08:20:59 +02:00
README.Solaris
Repository.mk remove obsolete sfx2_emojiconfig from Repository.mk 2022-09-30 21:38:01 +02:00
RepositoryExternal.mk Revert "Use libo_CHECK_SYSTEM_MODULE for eot" 2022-10-01 14:21:28 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk [COVER] add first set of ODF feature test files 2022-09-11 21:32:07 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt add more tsan supress 2022-09-02 10:58:42 +02:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.14
    • Build: 11.0 + Xcode 12.5
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 8.0.1 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 11 or later. It is possible to build LibreOffice with JDK version 9, but it is no longer supported by the JDK vendors, thus it should be avoided.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.