Test repository to check push and ssh key
Find a file
Noel Grandin 93bea3531c clang-tidy modernize-pass-by-value in writer*
Change-Id: Ib08c971eb3e859e7b04cdd408af7966d83c2955b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137585
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-31 08:33:13 +02:00
.git-hooks
.github
.vscode
accessibility move wintypes.hxx from tools to vcl 2022-07-20 12:20:59 +02:00
android
animations
apple_remote
avmedia
basctl move wintypes.hxx from tools to vcl 2022-07-20 12:20:59 +02:00
basegfx
basic loplugin:moveit 2022-07-25 10:04:06 +02:00
bean
bin Add help and list executables options for bin/run script 2022-07-30 06:35:50 +02:00
binaryurp
bridges rename GODSON/GODSON64 to MIPS/MIPS64 2022-07-27 11:52:23 +02:00
canvas
chart2 chart2: set the char props. to the cells of a data table from model 2022-07-28 16:22:31 +02:00
cli_ure
codemaker
comphelper
compilerplugins remove unused SETBULLETTEXT flag in editeng 2022-07-28 13:27:58 +02:00
config_host
configmgr elide some makeStringAndClear() calls 2022-07-21 11:01:40 +02:00
connectivity elide some makeStringAndClear() calls 2022-07-21 11:24:10 +02:00
cppcanvas
cppu elide some makeStringAndClear() calls 2022-07-21 11:24:10 +02:00
cppuhelper
cpputools
cui Fix typo 2022-07-30 04:43:59 +02:00
dbaccess tdf#149944 Do away with some excessive, unwarranted horizontal spacing 2022-07-31 02:00:06 +02:00
desktop lok: add dumpState feature for better in-field diagnostics. 2022-07-28 14:49:19 +02:00
dictionaries@68b272ec16
distro-configs
drawinglayer tdf#144916: expand range to avoid unwanted effects on viewport edges 2022-07-21 20:04:52 +02:00
editeng remove unused SETBULLETTEXT flag in editeng 2022-07-28 13:27:58 +02:00
embeddedobj
embedserv
emfio loplugin:moveit 2022-07-25 10:04:06 +02:00
eventattacher
extensions use more o3tl::span 2022-07-25 10:00:23 +02:00
external pdfium: fix build on windows aarch64 - no __popcnt 2022-07-28 17:26:30 +02:00
extras Fix typo 2022-07-30 23:27:12 +02:00
filter Fix typo 2022-07-30 23:25:48 +02:00
forms use more o3tl::span 2022-07-25 10:00:23 +02:00
formula
fpicker
framework elide some makeStringAndClear() calls 2022-07-21 11:01:22 +02:00
helpcompiler
helpcontent2@fbbbb4dedd Update git submodules 2022-07-28 21:03:39 +02:00
hwpfilter ofz#49217 height_sp member, etc unused 2022-07-24 20:37:40 +02:00
i18nlangtag
i18npool Resolves: tdf#150011 Add HRK Croatian Kuna conversion to EUR Euro 2022-07-22 23:04:58 +02:00
i18nutil
icon-themes
idl
idlc/test/parser
include Verify signing certificate cryptographically before use in tests 2022-07-29 22:55:07 +02:00
instsetoo_native
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk elide some makeStringAndClear() calls 2022-07-21 11:01:22 +02:00
l10ntools
librelogo
libreofficekit
lingucomponent
linguistic use more o3tl::span 2022-07-25 10:00:23 +02:00
lotuswordpro Fix typos 2022-07-21 16:16:44 +02:00
m4
nlpsolver
o3tl
odk
offapi
officecfg sw content controls, plain text: add insert UI 2022-07-26 09:50:37 +02:00
onlineupdate
oovbaapi VBA: Add Select Method to ActiveDocument 2022-07-20 14:46:37 +02:00
oox cid#1507491 cut and paste typo triggering 'Constant' variable guards dead code 2022-07-29 20:53:05 +02:00
opencl
osx
package
pch
postprocess rename GODSON/GODSON64 to MIPS/MIPS64 2022-07-27 11:52:23 +02:00
pyuno elide some makeStringAndClear() calls 2022-07-22 11:14:37 +02:00
qadevOOo
readlicense_oo
registry
remotebridges
reportbuilder
reportdesign move wintypes.hxx from tools to vcl 2022-07-20 12:20:59 +02:00
ridljar
sal tdf#141421 xml export: default stacksize for threads on macOS is too small 2022-07-20 21:52:52 +02:00
salhelper
sax tdf#119840 remove some OUString allocation 2022-07-28 08:47:41 +02:00
sc sc: allow undo of typing in 2 views independent from each other 2022-07-30 09:02:07 +02:00
scaddins
sccomp
schema sw content controls, date: add ODT filter 2022-07-22 09:39:00 +02:00
scp2
scripting
sd tdf#118696 better fix for sd Navigator object selection 2022-07-30 05:24:38 +02:00
sdext elide some makeStringAndClear() calls 2022-07-22 11:14:37 +02:00
setup_native
sfx2 tdf#117967 Fixes Save confirmation dialog for user cancel 2022-07-30 06:27:05 +02:00
shell tdf#150161: senddoc: use corrected name url: original can be a file path 2022-07-27 14:27:03 +02:00
slideshow
smoketest
solenv rename GODSON/GODSON64 to MIPS/MIPS64 2022-07-27 11:52:23 +02:00
soltools
sot
starmath tdf#150045 Set secondary/explanatory labels apart 2022-07-30 04:21:21 +02:00
static
stoc
store
svgio svgio: Add support for clip-rule="evenodd" 2022-07-29 08:21:59 +02:00
svl A bit of RAII 2022-07-25 12:13:26 +02:00
svtools tdf#147868 Disable add sheet when structure is protected 2022-07-24 15:53:39 +02:00
svx svx: manipulate SdrObject::m_aOutRect indirectly 2022-07-29 20:48:49 +02:00
sw Assert downcast 2022-07-30 07:07:22 +02:00
swext
sysui
test Better report unknown constant names by including their values 2022-07-27 17:35:03 +02:00
testtools
toolkit Make AccessibilityTools available more widely and use it 2022-07-27 10:41:03 +02:00
tools
translations@9d3310b0b0 Update git submodules 2022-07-26 13:11:46 +02:00
ucb
ucbhelper
udkapi
uitest
UnoControls
unodevtools
unoidl elide some makeStringAndClear() calls 2022-07-22 11:13:45 +02:00
unoil
unotest Verify signing certificate cryptographically before use in tests 2022-07-29 22:55:07 +02:00
unotools elide some makeStringAndClear() calls 2022-07-22 11:13:45 +02:00
unoxml
ure
uui tdf#150045 Set secondary/explanatory labels apart 2022-07-30 04:21:21 +02:00
vbahelper
vcl Improve vcl scheduler documentation 2022-07-30 20:34:50 +02:00
winaccessibility
wizards Related: tdf#150011 Add HRK Croatian Kuna to Euro conversion wizard 2022-07-23 02:18:41 +02:00
writerfilter clang-tidy modernize-pass-by-value in writer* 2022-07-31 08:33:13 +02:00
writerperfect clang-tidy modernize-pass-by-value in writer* 2022-07-31 08:33:13 +02:00
xmerge
xmlhelp cid#1507489 Big parameter passed by value 2022-07-29 20:53:40 +02:00
xmloff crashtest: fix crash on ODT export of forum-mso-de-84211.docx 2022-07-26 13:00:01 +02:00
xmlreader clang-tidy modernize-pass-by-value in xmlreader 2022-07-29 13:10:15 +02:00
xmlscript clang-tidy modernize-pass-by-value in xml* 2022-07-28 10:42:37 +02:00
xmlsecurity Verify signing certificate cryptographically before use in tests 2022-07-29 22:55:07 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in
config_host_lang.mk.in
configure.ac HPPA is 32bit 2022-07-27 12:44:52 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst external: update pdfium to 5187 2022-07-20 20:06:12 +02:00
g
hardened_runtime.xcent.in
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
lo.xcent.in
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.help.md Fix typo 2022-07-30 23:26:39 +02:00
README.md
README.Solaris
Repository.mk
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.14
    • Build: 11.0 + Xcode 12.5
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 8.0.1 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 11 or later. It is possible to build LibreOffice with JDK version 9, but it is no longer supported by the JDK vendors, thus it should be avoided.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.