There is no general solution to this that I am aware of, so just
implement a rather specific solution that will need periodic extending
to check for other dangerous properties
Change-Id: Ie09d89416fea5b7cdf782319ed9921657faa5a5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176593
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This change includes GUI element changes to support viewing and editing
first-line indent values with font-relative units in the paragraph style
dialog.
Change-Id: I72ada2565f51d70475eb17096a1317be9316b770
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176595
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
Execute getCommandValues('Signature') on the same document twice, you
get different hashes, because the content includes a timestamp, which
changes, so it's not possible to know if the hash is stable or not.
Also, working with a provided timestamp will needed for
<https://docs.eideasy.com/electronic-signatures/api-flow-with-file-hashes-pdf.html#_4-add-the-signature-to-the-pdf-file>
anyway.
Fix the problem by adding a signatureTime parameter and this way we can
have a test that makes sure we get the same hash if the time is
provided.
With this, the hash extraction part is meant to be ~complete.
Change-Id: If5e1e5bcf84c3b777f26b2ded24dcca48ea9ad94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176601
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
V668 There is no sense in testing the 'm_pRelStorElement->m_xStorage' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: Ie195de78b48c3766ef08a2d3666f778f75d2ca6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176596
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V668 There is no sense in testing the 'pUndo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: I3eeff673f5c0862e0b3c7f0a5338ddb0882ab31d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176594
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
...so that it looks for the /usr/bin/ symlink with the name with which it is
created by sysui/CustomTarget_share.mk via sysui/desktop/share/create_tree.sh
Change-Id: I46c2bb9d8df936fd5c7bd52bbee86da959d5c6cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176597
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
V560 A part of conditional expression is always true: mpPage.
Change-Id: If132fa2d5116ec3517846e026bfd3f76ef2cd9a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176591
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit ecd615ab32
Author: Armin Le Grand (Allotropia) <Armin.Le.Grand@me.com>
Date: Thu Nov 18 18:06:39 2021 +0100
VCL implement GetGlyphOutline fallback
V557 The 'aDXArry' container is empty, the access to its elements is impossible.
Change-Id: Ib67bbbf21f215bc27aa03b1a61dd7195c93e5311
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176589
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V560 A part of conditional expression is always true: pFlyFormat.
Change-Id: I9cc68a314dcdf98857eaf39aacf613d6fa67b720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176584
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V560 A part of conditional expression is always false: pPap.
V560 A part of conditional expression is always false: pSty.
Change-Id: I37a2cce02f303b9a3944c232d57f89b9087375ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176586
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V560 A part of conditional expression is always true: pView.
Change-Id: I6c01996c66a0c1488080da532734c3c05820337d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176581
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit 9cddf9da7f
Author: Vladimir Glazounov <vg@openoffice.org>
Date: Tue May 22 15:33:44 2007 +0000
INTEGRATION: CWS chart2mst3 (1.1.2); FILE ADDED
V560 A part of conditional expression is always false: (!(pTableFormat && pUnoCursor)).
V560 A part of conditional expression is always true: pTableFormat.
V560 A part of conditional expression is always true: pUnoCursor.
Change-Id: Id690161e2a64a82f94530142879bf291bd8df743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176583
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V560 A part of conditional expression is always true: pFormatItem.
Change-Id: I82009191496573e7f9dd1a6ab7f19df2243a30b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176582
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V560 A part of conditional expression is always true: pItem->mbVisible.
Change-Id: Id9c55e610fa81003a5ad7661d98962aa6d48c062
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176579
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This would have caught the issue discussed in
709b1f3ddb "Make sure VCLXPopupMenu has unique
RTTI". (The commit message talks about RTTI there, while what Clang actually
compared for an optimized implementation of a dynamic_cast to a final class is
vtable pointers, but the overall picture remains the same. Both RTTI and
vtables are emitted along the key function, and if that is missing or inline,
they are emitted for each dynamic library individually, and as internal symbols
on macOS.)
This commit also addresses all the issues found by the improved
loplugin:dyncastvisibility on Linux. See the newly added TODO in
compilerplugins/clang/dyncastvisibility.cxx and
86b86ac87e "Give DocumentEventHolder (aka
EventHolder<DocumentEvent>) a key function" for an issue with key functions for
class template instantiations.
Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression.
Change-Id: I31edbbc7ce3b10085c5f1404e74485ea180ddec3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176577
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Instead of using slideshow module to render the slide layers, use
the VCL / drawinglayer instead, which makes it possible to render
transparency correctly and fast.
Change-Id: Idfc9fcc8bc0e2bc139df93d1805f7a19fb1bce1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176575
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
...that is not inline, so that RTTI and vtable are not emitted for each dynamic
library individually. (Where they would be internal on macOS, which could break
optimized uses of dynamic_cast for that final class just checking vtable pointer
identity, as could happen for the dynamic_cast at
dbaccess/source/core/dataaccess/documenteventnotifier.cxx:232:51,
> 232 | const DocumentEventHolder& rEventHolder = dynamic_cast< const DocumentEventHolder& >( _rEvent );
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
And with the extern explicit template instantiation, EventHolder needs to be
SAL_DLLPUBLIC_TEMPLATE instead of just SAL_DLLPUBLIC_RTTI now, so that
Library_comphelper will export the DocumentEventHolder ctors and
DocumentEventHolder::getEventObject.)
(This would ideally have been caught by an upcoming improvement of
loplugin:dyncastvisibility, but might be complicated to check there for template
instantiations.)
Change-Id: I1e6280b185535968a870fbfadaff6238d38858e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176547
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
and
cid#1634807 Null pointer dereferences
Change-Id: I9a100651a744cb77ff89769e8c98afcfb771f593
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176563
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
problem:
The issue here is that the table does not have a fill style set,
but using the fill tool from the menubar does not give any error
or warning, either, which confuses the user.
Change-Id: Ib7d6ecdbb315b6eb2eca21423fba28d3cb086450
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176245
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit c0623158f010e08e0bfadaffb988eac14e1ff34e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176238
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
The intent of this patch is to address an issue with the Writer
Navigator page change control reported at https://
ask.libreoffice.org/t/writer-display-single-page/111050
"I have selected View > Normal and View > Whitespace and View> Zoom>
Entire Page. On the bottom right, I’ve chosen the single page icon."
... "It is odd that the page number displayed as you click the
[Navigator Page control spin button] up and down arrows does not
change.."
The patch changes the function used by the page control to determine
the page number of the page in the view to that used by the status
bar page control. It also disables page tracking by the control when
the view is set to Multiple-page view or Book view.
Change-Id: I439bb4493061528f87eaeca3c08a33095adb8192
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173888
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
V614 The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
V614 The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
Change-Id: Ic84af8c395c4b3f86017eb83be17a6fbd628e5d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176553
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Since
commit 400d5d8a90
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date: Wed Nov 13 10:35:36 2013 +0100
oox: initial import of wps:wsp
V614 The 'pMasterShape' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it. Consider checking the third actual argument of the 'WpsContext' function.
Change-Id: I1e14be0a528e01acbfa2d3e79d5a4d03e4b3e268
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176552
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Since
commit 2387c2a46e
Author: Matthew J. Francis <mjay.francis@gmail.com>
Date: Wed Jul 29 15:22:54 2015 +0800
Give PyUNO structs/exceptions their own separate type
V1048 The 'me' variable was assigned the same value.
Change-Id: Ia75c524c9cf459ff2961206c9a17dac1de0125a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176530
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Since
commit d4087b13fa
Author: Rüdiger Timm <rt@openoffice.org>
Date: Fri Apr 18 13:32:32 2008 +0000
INTEGRATION: CWS xmlfilter04 (1.2.12); FILE MERGED
V614 The 'pMasterShape' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it. Consider checking the second actual argument of the 'GraphicalObjectFrameContext' function.
Change-Id: I3d4241e8c88ee80c95a93d0e08d5498d87e7853b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176551
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit 63cd67e5e1
Author: Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>
Date: Fri May 14 13:53:32 2021 +0200
tdf#92525 tdf#142398: fix export of simple custom shapes
V649 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains function return. This means that the second 'if' statement is senseless. Check lines: 733, 738.
Change-Id: I92bff7ef8472c1774e6def78c5f1a165ea6a0153
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176550
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V614 The 'pEffect' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
Change-Id: Ic93aa42fa34af873f8dced5da0c1f55a8dcbd58d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176554
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
per the current template in TEMPLATE.SOURCECODE.HEADER
Change-Id: I06b36a22d0a62c46e0e0c99f27e1035e9f24e1a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176549
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
V1048 The 'm_bDelete' variable was assigned the same value.
Change-Id: Ib324ee9473de6b8ce8d4e6e073265580c8a3ba68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176546
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(and some places need a lower case LCPRODUCTNAME; plus some more clean up)
Change-Id: I7e97fcbe2e59ef22dffa7c0b47f076446873d09e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176539
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
Since
commit 85a47bbb83
Author: László Németh <nemeth@numbertext.org>
Date: Fri May 12 17:03:57 2023 +0200
tdf#155328 sw tracked table column: add DOCX export/import
V501 There are identical sub-expressions 'pRedline->GetRedlineData().GetType()' to the left and to the right of the '==' operator.
Change-Id: Ib53d20f102e64cd716245d558d6fd7754f62d9a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175403
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This change extends layout for font-relative paragraph first-line
indentation into Edit Engine.
Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
